From patchwork Tue Jun 23 19:59:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 223354 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7B9C433DF for ; Tue, 23 Jun 2020 20:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EAF520702 for ; Tue, 23 Jun 2020 20:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945588; bh=dgYiHx/8l9R33fw+vlvYho62cYUh2ayEQV1E/YH40C0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BHY36FUII394QPzmNQwThZRq7s6QE/e00DC3nn5jVaRsXgl1DQEtnVkJCITEq34MC APksPjlobAU3uYHVGcazPXigRv28umwOPMZgG/ShcnhIgVE78iSAj2CZcx5g+wV9IM CdWBA8Uq0kDzyJI91VapUVywOvNVylUXex4owJlI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392906AbgFWUrE (ORCPT ); Tue, 23 Jun 2020 16:47:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:45296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392634AbgFWUrB (ORCPT ); Tue, 23 Jun 2020 16:47:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A11F214DB; Tue, 23 Jun 2020 20:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945222; bh=dgYiHx/8l9R33fw+vlvYho62cYUh2ayEQV1E/YH40C0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SXe30OdjiGTh9+yZz98WLTK3Um9OFS5kawpYj7hnZnbvsFEoP04vkYJwIeCQy0Orq mIywH2ZqMB+D+R32Bn3SdWlSwh6xtyfYihgJ0fsFM8Bd0arllh48Ay7npu7rzGtYY+ BregfcgCduu6Q5XrYUBfVY1hPb93Smfg4zhqBBDs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bob Peterson , Andreas Gruenbacher , Sasha Levin Subject: [PATCH 4.14 086/136] gfs2: Allow lock_nolock mount to specify jid=X Date: Tue, 23 Jun 2020 21:59:02 +0200 Message-Id: <20200623195308.016767362@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Bob Peterson [ Upstream commit ea22eee4e6027d8927099de344f7fff43c507ef9 ] Before this patch, a simple typo accidentally added \n to the jid= string for lock_nolock mounts. This made it impossible to mount a gfs2 file system with a journal other than journal0. Thus: mount -tgfs2 -o hostdata="jid=1" Resulted in: mount: wrong fs type, bad option, bad superblock on In most cases this is not a problem. However, for debugging and testing purposes we sometimes want to test the integrity of other journals. This patch removes the unnecessary \n and thus allows lock_nolock users to specify an alternate journal. Signed-off-by: Bob Peterson Signed-off-by: Andreas Gruenbacher Signed-off-by: Sasha Levin --- fs/gfs2/ops_fstype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index 057be88eb1b42..7ed0359ebac61 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -922,7 +922,7 @@ fail: } static const match_table_t nolock_tokens = { - { Opt_jid, "jid=%d\n", }, + { Opt_jid, "jid=%d", }, { Opt_err, NULL }, };