From patchwork Tue Jun 23 19:59:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 223375 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E55C433DF for ; Tue, 23 Jun 2020 20:48:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 157EC2158C for ; Tue, 23 Jun 2020 20:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945339; bh=KBuvIhyZm/BBg+Kcj7ctVvYIWsJYksyAeju6FUxkpnI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=E3HHGQceP1Un57+O4DjfIdYGL+cMznjn5wpgt5zTRIjIusLSX4dv5QoLVeDHhvhNb Ap3FDMRhnRDLOM2tuWvMr3pSBRjt8YncfmNTwoFI0dVuPBZUgRwspj7Lg02F6cfEX7 5irSeScWPaOpX87ww5yJUorjBPSDTeYFURIRh784= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404130AbgFWUsz (ORCPT ); Tue, 23 Jun 2020 16:48:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:48120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404127AbgFWUsy (ORCPT ); Tue, 23 Jun 2020 16:48:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7978B2098B; Tue, 23 Jun 2020 20:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945334; bh=KBuvIhyZm/BBg+Kcj7ctVvYIWsJYksyAeju6FUxkpnI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UHIGWtapR1qMdctt5UuEKesetjy347Ovrircn/uY5+rsRQLXv2GRo13w3XfGJVI6l sh+OOG51doJT3o6DWgTM5+1Zb2poYPaXyX+PlbdWzI/IDLPr4WYYV4rIWf8KOUp2XI 5h4zX3a6JxoI6tPGx88iorC6N8XCKRA5/rLiTji8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal , Sasha Levin Subject: [PATCH 4.14 129/136] mtd: rawnand: tmio: Fix the probe error path Date: Tue, 23 Jun 2020 21:59:45 +0200 Message-Id: <20200623195310.293718504@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Miquel Raynal [ Upstream commit 75e9a330a9bd48f97a55a08000236084fe3dae56 ] nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. There is no real Fixes tag applying here as the use of nand_release() in this driver predates by far the introduction of nand_cleanup() in commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") which makes this change possible. However, pointing this commit as the culprit for backporting purposes makes sense even if this commit is not introducing any bug. Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-57-miquel.raynal@bootlin.com Signed-off-by: Sasha Levin --- drivers/mtd/nand/tmio_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/tmio_nand.c b/drivers/mtd/nand/tmio_nand.c index 5a082d9432f96..51f12b9f90ba1 100644 --- a/drivers/mtd/nand/tmio_nand.c +++ b/drivers/mtd/nand/tmio_nand.c @@ -448,7 +448,7 @@ static int tmio_probe(struct platform_device *dev) if (!retval) return retval; - nand_release(nand_chip); + nand_cleanup(nand_chip); err_irq: tmio_hw_stop(dev, tmio);