From patchwork Tue Jun 23 19:52:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 191618 Delivered-To: patch@linaro.org Received: by 2002:a54:3249:0:0:0:0:0 with SMTP id g9csp1374930ecs; Tue, 23 Jun 2020 14:38:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxA6dNTcqECdxq6vMqL82CrSuP9kL180LGVOSb2Dr7dj0dzxylUKzAVRLUaG8VeTTnV2pnP X-Received: by 2002:a17:906:d933:: with SMTP id rn19mr22695151ejb.158.1592948337379; Tue, 23 Jun 2020 14:38:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592948337; cv=none; d=google.com; s=arc-20160816; b=V9DArqLxSaw36rQ8fVeosuP6sQJFrR4wEag7EO4UXSPOP8zYWpXJ+EdZmDbIGj8nCk Y3hFwT1uDh/xjn0gaUfP3GHyC3Tfv7l+xTp5xaJGpFsOm3wgZ80FW5MPWHo1Mp83FqKF svuFBSwh6faoEzJ6GYnFk7taOkaawUQRJb+ewMYgMECzVrvPnDWUjXrFZ0p/sTMN/INc LQnFFst8hqSuH+5nDs+vFMg9svQnJGEQk95jCHQQtpET+T0u6BoMrROLVXMD3K3jK6pP uT6QYCyz0woDxCJQpXe++s7sUTB956Vdy2VzrXrfnlsgCV4EA8v3x1zbSsGnzTNWY836 NHtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HLIX0YrW7hZ4bXEtpG3gJlf/2hza8dxla2NAoQafABE=; b=serVIxd/ogjdnchV1eR2ZEequdl/1KLe8giavDCJUhe6xTCt1f/87Gw+MgmgS+7sj2 1e7K4x3TwFUST0rUB6DXwAReIKKmF8zUQLSYHlPrL2rDi4A1p+tmrQrhK3hO9xgr52SR xYyCJQtuBmSIzry0yCHe//FUJTtdVW1egi08TnB1Socpn6NdUl1pnTCFXHXPLFXwMzN6 BXEEBjJcRr28AL27J4Sg0g73Ov4UI6A/WTC1Aztyr7f851lfL0JwcYlSWsibDjZ1FDIy Zb2mutTM83S/kM0H0cm6u+MFqj5x6q1M2utrsd3wWNi4W+RGJnuhXqne6YZWm9DLiVgS Miug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iW5BYNsH; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u9si12363765edl.529.2020.06.23.14.38.56; Tue, 23 Jun 2020 14:38:57 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iW5BYNsH; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388478AbgFWViv (ORCPT + 15 others); Tue, 23 Jun 2020 17:38:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:48358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387862AbgFWUHn (ORCPT ); Tue, 23 Jun 2020 16:07:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B8FF02064B; Tue, 23 Jun 2020 20:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592942862; bh=9IyFQ1LxdVrwBZSwUEShij5X2ILrV9XEJsqS8gNrNjQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iW5BYNsHP9+PEBJIpi6boq/XGOhmjvhrtcpQQJBiWZo2417SQa5uKB6JfCQpDREPg WsaZ9xKW498CUwv/sJxH8SubaLq6R3y22pmH74V8wZjeyr8crROxzfzlsVpKnqX5YG NooegOHpjUoSSMIcneovmd3Q2m6qT5Gu5EbnF7hw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Srinivas Pandruvada , Jiri Kosina , Sasha Levin Subject: [PATCH 5.7 163/477] HID: intel-ish-hid: avoid bogus uninitialized-variable warning Date: Tue, 23 Jun 2020 21:52:40 +0200 Message-Id: <20200623195415.292043791@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195407.572062007@linuxfoundation.org> References: <20200623195407.572062007@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 0b66fb3e6b7a53688f8e20945ac78cd3d832c65f ] Older compilers like gcc-4.8 don't see that the variable is initialized when it is used: In file included from include/linux/compiler_types.h:68:0, from :0: drivers/hid/intel-ish-hid/ishtp-fw-loader.c: In function 'load_fw_from_host': include/linux/compiler-gcc.h:75:45: warning: 'fw_info.ldr_capability.max_dma_buf_size' may be used uninitialized in this function [-Wmaybe-uninitialized] #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ drivers/hid/intel-ish-hid/ishtp-fw-loader.c:770:22: note: 'fw_info.ldr_capability.max_dma_buf_size' was declared here struct shim_fw_info fw_info; ^ Make sure to initialize it before returning an error from ish_query_loader_prop(). Fixes: 91b228107da3 ("HID: intel-ish-hid: ISH firmware loader client driver") Signed-off-by: Arnd Bergmann Acked-by: Srinivas Pandruvada Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 diff --git a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c index aa2dbed30fc36..6cf59fd26ad78 100644 --- a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c +++ b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c @@ -480,6 +480,7 @@ static int ish_query_loader_prop(struct ishtp_cl_data *client_data, sizeof(ldr_xfer_query_resp)); if (rv < 0) { client_data->flag_retry = true; + *fw_info = (struct shim_fw_info){}; return rv; } @@ -489,6 +490,7 @@ static int ish_query_loader_prop(struct ishtp_cl_data *client_data, "data size %d is not equal to size of loader_xfer_query_response %zu\n", rv, sizeof(struct loader_xfer_query_response)); client_data->flag_retry = true; + *fw_info = (struct shim_fw_info){}; return -EMSGSIZE; }