From patchwork Mon Jul 20 15:35:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 237512 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp2114347ilg; Mon, 20 Jul 2020 09:09:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcbPtcCpc6K2HLQSmQU+K9PmYy1euzYic9D5D9M7AWjtnibDFUz0PfLRPZTFQjh2mHLMrN X-Received: by 2002:aa7:dd10:: with SMTP id i16mr22628656edv.227.1595261350831; Mon, 20 Jul 2020 09:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595261350; cv=none; d=google.com; s=arc-20160816; b=JKTDzskdE1sZG8gxDCMbRAczZmAIQ3XVjqIuOpVu799n23PgubJAYh2F7kcJ6CGQrW n0Bn7f0zQidMd/w+itQrccG6gVUTTl7+MrcamoIMt3yJG0nOkZGheZvGFrOWYigmWXOY SimZ+Ih3zBXidn1xFafml2wWeHP4fI+YUCz05lU/mbtTd8IqVgF0JTJD6PInp3v/zfz6 szcUJvAGnqRnIa2RsHqKi7rdL96IzbUO3J0l9ptsNJKDfwN4ccKpcSHrCBFMQSJB256k XIdz4Ru8KZ8/87pMxPqz97WER9M2m4OXhSTO6d3avRvZlPvJiuFkOJF34kWpuHo284VN GHGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Vc+wC6hnnQ3a0k/dpA6J8TDjltFpVPBhohRYN/OG8N0=; b=V5mHhmH0Ux9d70wc9ThgkaR2ZjMw2Q/bJubzsliHX+wOHHdAOmM5j++JnicdiR/mVQ jQ0VgFYKSmWZ3b+GXe2OFrjHQm6j1T7EmHRTHAOZ9AwQxS3tSE6yjNrhI+7CCQzcOYl4 dtW7VrSf3WeRQU3SVUnmvrpyaQnuqr7z+tclfn/UfFWiP9ez4Pxy0wogueVWhzaxJDd5 GjxiL5Szv0tDAtONmkJAbepL17LCzLS4rLIn6A1S4fQNmZrYmY7KWBuB4nVB6TsJt9Fu sIo4vz7lT2ceyTtlwjh0VixeAFThhfaQIwtjgdXU+AQ/Nl3WZfqrr5zM/pPW3cU7rikc TCfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JSXrEGdD; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si10785724eds.105.2020.07.20.09.09.10; Mon, 20 Jul 2020 09:09:10 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JSXrEGdD; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733109AbgGTQJJ (ORCPT + 15 others); Mon, 20 Jul 2020 12:09:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:46842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387486AbgGTQJG (ORCPT ); Mon, 20 Jul 2020 12:09:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDDBB206E9; Mon, 20 Jul 2020 16:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595261345; bh=iD4Sr9OwlsNAX3ujfe/kkTFXiAMIi4ON05yukDyDDUE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JSXrEGdDgJLLP0/ZAGfTkqDnE8WL+6CPsU13YTcow1Xc4mlnyz8vxRmv777xuJ8Pr uZrX5TvkCr12hERUUZpXA3rF0rMoJF8lOZS79116A5ZTmS899dBSaS5Q2Vt1vffgva xHxHD3ajQ/9FqYE8DR1uXxtjmzSekbF9QZLQefFQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Peter Ujfalusi , Vinod Koul , Sasha Levin Subject: [PATCH 5.7 083/244] dmaengine: ti: k3-udma: Fix delayed_work usage for tx drain workaround Date: Mon, 20 Jul 2020 17:35:54 +0200 Message-Id: <20200720152829.789699554@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152825.863040590@linuxfoundation.org> References: <20200720152825.863040590@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Peter Ujfalusi [ Upstream commit d964d5ff68dba21b53368656adec3fb5f50426bb ] INIT_DELAYED_WORK_ONSTACK() must be used with on-stack delayed work, which is not the case here. Use normal delayed_work for the channels instead. Fixes: 25dcb5dd7b7c ("dmaengine: ti: New driver for K3 UDMA") Reported-by: Tomi Valkeinen Signed-off-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20200618114004.6268-1-peter.ujfalusi@ti.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/ti/k3-udma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c index baf7ab64f1d7d..9760d67aa612a 100644 --- a/drivers/dma/ti/k3-udma.c +++ b/drivers/dma/ti/k3-udma.c @@ -1925,8 +1925,6 @@ static int udma_alloc_chan_resources(struct dma_chan *chan) udma_reset_rings(uc); - INIT_DELAYED_WORK_ONSTACK(&uc->tx_drain.work, - udma_check_tx_completion); return 0; err_irq_free: @@ -3038,7 +3036,6 @@ static void udma_free_chan_resources(struct dma_chan *chan) } cancel_delayed_work_sync(&uc->tx_drain.work); - destroy_delayed_work_on_stack(&uc->tx_drain.work); if (uc->irq_num_ring > 0) { free_irq(uc->irq_num_ring, uc); @@ -3727,6 +3724,7 @@ static int udma_probe(struct platform_device *pdev) tasklet_init(&uc->vc.task, udma_vchan_complete, (unsigned long)&uc->vc); init_completion(&uc->teardown_completed); + INIT_DELAYED_WORK(&uc->tx_drain.work, udma_check_tx_completion); } ret = dma_async_device_register(&ud->ddev);