From patchwork Mon Aug 17 15:12:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 247871 Delivered-To: patch@linaro.org Received: by 2002:a54:3b12:0:0:0:0:0 with SMTP id j18csp2593872ect; Mon, 17 Aug 2020 12:39:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9kPPZJJpBq23MOXoZHwq+DJbIxht9PG6uuIgBH03/KjcupD5tfZO+3PRD+q7FgYEMr059 X-Received: by 2002:a05:6402:1bc1:: with SMTP id ch1mr16647148edb.142.1597693184308; Mon, 17 Aug 2020 12:39:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597693184; cv=none; d=google.com; s=arc-20160816; b=giUG5IzkXFERyhL2/jK+XOo1kD4/6jfu6NQqG5LBn9nXXihtWrUC4CfoNQ+fOtRJhD A4BLWhCeN7Bc+tBeWQ84cdN+vjTwlSMkb75HbB4TCN/t54SPZmlbz+6Pf65uq4/B4zGO NhB3J8p8t4e3d4R4xxA7BDl7zHdoLqC8CYUd6Ev5lnn9Jd5fgfnVt8XN/d8IDyP6lD92 uIBgzrMqtf/s+q8vg3pG/E/wplJscVdpyLIkaR+wFasvaHa6n4uTS4cXimDBycoeIIe4 k/ceHiTpbNUPWBSedbqCgAYUdO3X5crMgvPxTWSdkZMLCQN06FWZ6VFH2p8ufEHvPk/g 2HhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=V24jOAuVX9fG59wpQimWJPvTq2nTkVrZ3hLDtZDtNnc=; b=CRpY4lq7Nuc0zyvvQFitutdrstPngyMqHCh2NNJsxoUlgQhSNGEkOKl7G0kamLvSO8 mSfbZNGQkb7Z55woHjvvc417heT5bB8j435wEx9fRfjT2q2+6dVhQCyUl3B9nzw4peNZ Q0YB9EDzUCFs/B7FdwBG3MZeZoVWj+gHZGtzw0Ueahpum38ZPpKe8FoQFM3n9zlSJvTj QDToxbkM5yjB1uexR/coTaF2c1ioX3SZ+FG4Od9VQbmvkMHTEovjrNv75a5KvFytGDn3 XAziL9wmaJAGpQlPrX/WJM5LUk32xiKdXCuxvFWPtb45JH0Y6ymnEwI6goKw91pAo/ED aR7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=syh2bieL; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a5si11826335ejb.582.2020.08.17.12.39.44; Mon, 17 Aug 2020 12:39:44 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=syh2bieL; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404181AbgHQTjn (ORCPT + 15 others); Mon, 17 Aug 2020 15:39:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:33888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729757AbgHQP0G (ORCPT ); Mon, 17 Aug 2020 11:26:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B481E23A69; Mon, 17 Aug 2020 15:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597677966; bh=ZYPj2n3jUoY+wTP3dDHarfWLSbwuShn8ynurOvqVWv8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=syh2bieLBy6o38vHlAXzmDDHRwVV1nG2npqNnzJ+cdEwu0pSi3Nknc0tR4G3HxAYz FRF5PtXbGyuE7JkRmIQbejWvwanDo4rRpFFw8bNnJq15oK34COsnYab1xH7Cfm2Apa I8/MCDu1PBnTgMGgELdWIhHZ9jxhjk8Q2/W/jbAQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.8 172/464] media: cxusb-analog: fix V4L2 dependency Date: Mon, 17 Aug 2020 17:12:05 +0200 Message-Id: <20200817143842.057548641@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143833.737102804@linuxfoundation.org> References: <20200817143833.737102804@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 1a55caf010c46d4f2073f9e92e97ef65358c16bf ] CONFIG_DVB_USB_CXUSB_ANALOG is a 'bool' symbol with a dependency on the tristate CONFIG_VIDEO_V4L2, which means it can be enabled as =y even when its dependency is =m. This leads to a link failure: drivers/media/usb/dvb-usb/cxusb-analog.o: In function `cxusb_medion_analog_init': cxusb-analog.c:(.text+0x92): undefined reference to `v4l2_subdev_call_wrappers' drivers/media/usb/dvb-usb/cxusb-analog.o: In function `cxusb_medion_register_analog': cxusb-analog.c:(.text+0x466): undefined reference to `v4l2_device_register' cxusb-analog.c:(.text+0x4c3): undefined reference to `v4l2_i2c_new_subdev' cxusb-analog.c:(.text+0x4fb): undefined reference to `v4l2_subdev_call_wrappers' ... Change the dependency only disallow the analog portion of the driver in that configuration. Fixes: e478d4054054 ("media: cxusb: add analog mode support for Medion MD95700") Signed-off-by: Arnd Bergmann Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/dvb-usb/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/media/usb/dvb-usb/Kconfig b/drivers/media/usb/dvb-usb/Kconfig index 15d29c91662f3..25ba03edcb5c6 100644 --- a/drivers/media/usb/dvb-usb/Kconfig +++ b/drivers/media/usb/dvb-usb/Kconfig @@ -151,6 +151,7 @@ config DVB_USB_CXUSB config DVB_USB_CXUSB_ANALOG bool "Analog support for the Conexant USB2.0 hybrid reference design" depends on DVB_USB_CXUSB && VIDEO_V4L2 + depends on VIDEO_V4L2=y || VIDEO_V4L2=DVB_USB_CXUSB select VIDEO_CX25840 select VIDEOBUF2_VMALLOC help