From patchwork Tue Sep 8 15:23:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 309898 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 194E7C433E2 for ; Tue, 8 Sep 2020 19:34:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7F862145D for ; Tue, 8 Sep 2020 19:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599593646; bh=8oOtyPkdf47pnN5G7/BrbY1fcYbqtcbHjJaAtLsYWFw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rXmVT9pBqVadnodvPU3m0oTghRKKG6W8Vw5WSE7K4E6iuT9o7CtfDscRIt7C4iy8Q aBgpogQAUnedWZzcWBDwuwlEtBIWRV4YxJWScX3h30QGbmXlfzNYK+G5wAIAwbGoEW AGeGvtXyn8HqmwP1r+ash7lknjcwk9Hn0tT3D/uI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732019AbgIHTdb (ORCPT ); Tue, 8 Sep 2020 15:33:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:48750 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731017AbgIHP6F (ORCPT ); Tue, 8 Sep 2020 11:58:05 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 784FA22574; Tue, 8 Sep 2020 15:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599579425; bh=8oOtyPkdf47pnN5G7/BrbY1fcYbqtcbHjJaAtLsYWFw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QDiCfrPAIY2P8K5MmCe6iewLX79+L3PuXeCtC28XZWIfVSQx2gWgBs1zwVJvOHrT/ SfXljKcjGOOHxWlw6j5borOxU/vKZkU25fENBqmIIfHWV9dcsCqA4m+I6oxjzHR9zc 2BZisAz2/JTP8gzGx/50G/pwwiSN7m/L2JOMqzfE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yu Kuai , Vinod Koul , Sasha Levin Subject: [PATCH 5.8 045/186] dmaengine: at_hdmac: add missing kfree() call in at_dma_xlate() Date: Tue, 8 Sep 2020 17:23:07 +0200 Message-Id: <20200908152243.844522114@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200908152241.646390211@linuxfoundation.org> References: <20200908152241.646390211@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yu Kuai [ Upstream commit e097eb7473d9e70da9e03276f61cd392ccb9d79f ] If memory allocation for 'atslave' succeed, at_dma_xlate() doesn't have a corresponding kfree() in exception handling. Thus add kfree() for this function implementation. Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding") Signed-off-by: Yu Kuai Link: https://lore.kernel.org/r/20200817115728.1706719-4-yukuai3@huawei.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/at_hdmac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index c91642b5f1037..626819b33a325 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -1691,6 +1691,7 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec, chan = dma_request_channel(mask, at_dma_filter, atslave); if (!chan) { put_device(&dmac_pdev->dev); + kfree(atslave); return NULL; }