From patchwork Tue Sep 29 10:56:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 290907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D689C4727F for ; Tue, 29 Sep 2020 12:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB70721531 for ; Tue, 29 Sep 2020 12:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601381677; bh=Z4tig6aruIz6mfjORxDavK1YfVzLhAsu1xNUQFQhaos=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=SO36XWGJpu+AcGYM2+YEPi23mjQCmZgr6etWsVcsWg4TkYWci7UTSWO7yhMWQoek3 iQQrs7fTHrzTrloJP2Rjp7vk8ARs4+54FTmEY4uFKRZSRzwRblKrlMAA8/hwFaEhY8 RkdFJu++1SpDihT0UaZYNSFsup2GTpWGXHJDkRA8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732178AbgI2MOI (ORCPT ); Tue, 29 Sep 2020 08:14:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:53442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730115AbgI2Lh3 (ORCPT ); Tue, 29 Sep 2020 07:37:29 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C98E523B40; Tue, 29 Sep 2020 11:34:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601379246; bh=Z4tig6aruIz6mfjORxDavK1YfVzLhAsu1xNUQFQhaos=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nRmfL4xUMMKzUeaXshMxw/ozBjZGJ4CvlUQDc2iDQ+FxF69EV8+8aReRWxeRPqQ1c UIz9Y+7Tq4o0ejJLDSAob3qa4RfZvcVYMu46eLImZ6ZJiytvEoKXHS7IxXZAYr/gwY i8yjGWeqCfmvOTPZtLFal+kqXKkrsV4bCY/M9MXk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Averin , "David S. Miller" , Sasha Levin Subject: [PATCH 5.4 077/388] neigh_stat_seq_next() should increase position index Date: Tue, 29 Sep 2020 12:56:48 +0200 Message-Id: <20200929110014.215670147@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929110010.467764689@linuxfoundation.org> References: <20200929110010.467764689@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vasily Averin [ Upstream commit 1e3f9f073c47bee7c23e77316b07bc12338c5bba ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/core/neighbour.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 7b40d12f0c229..04953e5f25302 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -3290,6 +3290,7 @@ static void *neigh_stat_seq_next(struct seq_file *seq, void *v, loff_t *pos) *pos = cpu+1; return per_cpu_ptr(tbl->stats, cpu); } + (*pos)++; return NULL; }