From patchwork Tue Sep 29 10:59:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 291114 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A1FDC4741F for ; Tue, 29 Sep 2020 11:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F8C922262 for ; Tue, 29 Sep 2020 11:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601379701; bh=hWxEemS0CtcU8+GmrUgxR9sUWie9zveuyVgl/2YQdms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uyciPGW8D7ept7DUCwSFrxyQY5uyxrLCRwi8t5iPkSITICKvzYDaVeJU+szfd4b7v hGe2nPtOnRGT4f/OskC4sg1YhUr+2b0T8S4wzxuMTpF4lZjD5TVGIncI/+hHJrqBp/ sg5T0h2T5suFl4GEK6Eiay0NlvQ37ORkTuP4jvgw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729336AbgI2Llj (ORCPT ); Tue, 29 Sep 2020 07:41:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:37036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728909AbgI2LlE (ORCPT ); Tue, 29 Sep 2020 07:41:04 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 01CF520702; Tue, 29 Sep 2020 11:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601379663; bh=hWxEemS0CtcU8+GmrUgxR9sUWie9zveuyVgl/2YQdms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iDOc+BsTagOxuPjecLeTACFmtlyNoR7GGyJrnQ4bQEizAMRToAp8a/JbEUJ+ADbf2 NF5XrKcqr3FgQi7xbrFbhFNf0jqcaAEgtrPYTF48OrYfLj+03KTn7pdida/HAQbIBW MrI1gtO2uFpvNf23XSZ5XiDebK9pRVvaNBnop8wk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matthew Wilcox , Miklos Szeredi , Sasha Levin Subject: [PATCH 5.4 264/388] fuse: dont check refcount after stealing page Date: Tue, 29 Sep 2020 12:59:55 +0200 Message-Id: <20200929110023.249410150@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929110010.467764689@linuxfoundation.org> References: <20200929110010.467764689@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Miklos Szeredi [ Upstream commit 32f98877c57bee6bc27f443a96f49678a2cd6a50 ] page_count() is unstable. Unless there has been an RCU grace period between when the page was removed from the page cache and now, a speculative reference may exist from the page cache. Reported-by: Matthew Wilcox Signed-off-by: Miklos Szeredi Signed-off-by: Sasha Levin --- fs/fuse/dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 06dd38e76c62a..f9022b7028754 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -764,7 +764,6 @@ static int fuse_check_page(struct page *page) { if (page_mapcount(page) || page->mapping != NULL || - page_count(page) != 1 || (page->flags & PAGE_FLAGS_CHECK_AT_PREP & ~(1 << PG_locked | 1 << PG_referenced |