From patchwork Tue Oct 27 13:48:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 311779 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A2FCC4363A for ; Tue, 27 Oct 2020 18:15:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB1B321556 for ; Tue, 27 Oct 2020 18:15:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603822537; bh=JChFd0gn/hhL+kqbOL4AvOcrrDnDlUyDzEVHjw3Bthw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PyJmicXg1sKdgkB4uInFb9Vv6kdYnBDkUTmMpRtxOtFPj2XEPwnQz7A4Jg0fEDfT4 9R+ZD/CuqdDX3FXRN+62MInkr/asSRxSbwjh0HknlpnD8EoEQI8OSsnnhQNHRcZX+P dihgnaB3DdPZpCb6njfn7EvJ86VIo2FbtzW5cUBg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2507449AbgJ0OMe (ORCPT ); Tue, 27 Oct 2020 10:12:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:60090 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2506305AbgJ0OLI (ORCPT ); Tue, 27 Oct 2020 10:11:08 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20EC0218AC; Tue, 27 Oct 2020 14:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603807867; bh=JChFd0gn/hhL+kqbOL4AvOcrrDnDlUyDzEVHjw3Bthw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZhpSC0+JZOWLmxqP/5noi7DeXeYwzkFl+27EU8zuMD2Q86H6q6iOJSN0R7nwJj1vZ Fleu0CGj8/kRPGiLXtfYXtx/cNSujenYxO/5GLxWPorFMgHpn8Upi+Mlrfe4zq1lr5 BOYR+kBvWU3QoLcK+i+lpShytVGuS5dG9iAeyByY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiushi Wu , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 039/191] media: ti-vpe: Fix a missing check and reference count leak Date: Tue, 27 Oct 2020 14:48:14 +0100 Message-Id: <20201027134911.617138227@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027134909.701581493@linuxfoundation.org> References: <20201027134909.701581493@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Qiushi Wu [ Upstream commit 7dae2aaaf432767ca7aa11fa84643a7c2600dbdd ] pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. And also, when the call of function vpe_runtime_get() failed, we won't call vpe_runtime_put(). Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails inside vpe_runtime_get(). Fixes: 4571912743ac ("[media] v4l: ti-vpe: Add VPE mem to mem driver") Signed-off-by: Qiushi Wu Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/ti-vpe/vpe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 2e8970c7e22da..bbd8bb611915c 100644 --- a/drivers/media/platform/ti-vpe/vpe.c +++ b/drivers/media/platform/ti-vpe/vpe.c @@ -2470,6 +2470,8 @@ static int vpe_runtime_get(struct platform_device *pdev) r = pm_runtime_get_sync(&pdev->dev); WARN_ON(r < 0); + if (r) + pm_runtime_put_noidle(&pdev->dev); return r < 0 ? r : 0; }