From patchwork Tue Oct 27 13:49:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 311770 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA586C56201 for ; Tue, 27 Oct 2020 18:16:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C9002224A for ; Tue, 27 Oct 2020 18:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603822566; bh=JNX1b1s1S8/slQjwsPJ324lvjzzJASKZch41UK6bUss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=F7hXBMzo4+UJ7G24woUG2szBY3Cr9t98i5HWZVTIe7qG8+N+yuGwwLVpAcmTPEbtJ Upe46HtoxybRKXQ5E299SJv54v8e2fFwvVKewjKkE9g2uxWTySpOJITKcJo6X9I8fd GpJlpgne8jJa03ZD9+AfxeLMxRLWHmlpRp/Ys928= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756248AbgJ0SQF (ORCPT ); Tue, 27 Oct 2020 14:16:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:33246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756236AbgJ0OMJ (ORCPT ); Tue, 27 Oct 2020 10:12:09 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8FD882072D; Tue, 27 Oct 2020 14:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603807929; bh=JNX1b1s1S8/slQjwsPJ324lvjzzJASKZch41UK6bUss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f6AwSWZ6+aGw4ogLiB4noR134+LYtaUIJnGzAgCk/NVkxWC7iTS3V+6Rt2CKb4SmL Epoayvlj/dN6RsoSL9iBfAqUWeYb6cz31Z/WGgv8MBUVwB7OfBwZZTq5cYKB+E9hAV 8ylRwt4u7AYwLuPgTR+94bTXGlWCOekmKnqygjiY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Darrick J. Wong" , Christoph Hellwig , Chandan Babu R , Sasha Levin Subject: [PATCH 4.14 093/191] xfs: limit entries returned when counting fsmap records Date: Tue, 27 Oct 2020 14:49:08 +0100 Message-Id: <20201027134914.166848771@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027134909.701581493@linuxfoundation.org> References: <20201027134909.701581493@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Darrick J. Wong [ Upstream commit acd1ac3aa22fd58803a12d26b1ab7f70232f8d8d ] If userspace asked fsmap to count the number of entries, we cannot return more than UINT_MAX entries because fmh_entries is u32. Therefore, stop counting if we hit this limit or else we will waste time to return truncated results. Fixes: e89c041338ed ("xfs: implement the GETFSMAP ioctl") Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Reviewed-by: Chandan Babu R Signed-off-by: Sasha Levin --- fs/xfs/xfs_fsmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/xfs/xfs_fsmap.c b/fs/xfs/xfs_fsmap.c index 43cfc07996a43..e7622e0841868 100644 --- a/fs/xfs/xfs_fsmap.c +++ b/fs/xfs/xfs_fsmap.c @@ -273,6 +273,9 @@ xfs_getfsmap_helper( /* Are we just counting mappings? */ if (info->head->fmh_count == 0) { + if (info->head->fmh_entries == UINT_MAX) + return -ECANCELED; + if (rec_daddr > info->next_daddr) info->head->fmh_entries++;