From patchwork Tue Oct 27 13:46:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 312643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FF3C388F9 for ; Tue, 27 Oct 2020 15:24:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4AC92224A for ; Tue, 27 Oct 2020 15:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812276; bh=6z1GlKEHSp5e5ACyIwqWZepobB9Kxm65ZQa/XjTzVns=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yTNFXvMgyceoWtFg8NC0APpqrZ1vKgpQoUhIhmzlmuo5HbA5CJx3r58rgO+Gfzfz8 ZURXk7We8nkHCFFFkb5fDyFn/WZJeiBQCAOn8mLxJggmKfqJxEJBJY8mwUtmokjBs6 X1bK7mucrgc+c4bSlR+dQyLgjxqasFQ5EfJhvkBs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1797332AbgJ0PYf (ORCPT ); Tue, 27 Oct 2020 11:24:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:39862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1797601AbgJ0PYb (ORCPT ); Tue, 27 Oct 2020 11:24:31 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C8D4E2225E; Tue, 27 Oct 2020 15:24:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603812271; bh=6z1GlKEHSp5e5ACyIwqWZepobB9Kxm65ZQa/XjTzVns=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mFhjwQ4/cMYc5g7YF03tnpINHkTxQQr+5vmJNQ9H46l10u/GvLRhBJdRRXvbvdmAH AjAv/FykK4ZBSvbwt/WqSynVvM4Od+4+XS3pR03i4yQYEh5oI6T8Sngdedn9W0oyhr wyK1CWFKgCs7X4aCyqpqy1jH1nVC9dKZXpBkD0OQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Herbert Xu , Sasha Levin Subject: [PATCH 5.9 151/757] crypto: sa2ul - Fix pm_runtime_get_sync() error checking Date: Tue, 27 Oct 2020 14:46:41 +0100 Message-Id: <20201027135457.692771286@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit 2baace5feb86c6916221911f391f11fcd8e1a259 ] The pm_runtime_get_sync() function returns either 0 or 1 on success but this code treats a return of 1 as a failure. Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") Signed-off-by: Dan Carpenter Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/sa2ul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index ff8bbdb4d235d..039579b7cc818 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -2331,7 +2331,7 @@ static int sa_ul_probe(struct platform_device *pdev) pm_runtime_enable(dev); ret = pm_runtime_get_sync(dev); - if (ret) { + if (ret < 0) { dev_err(&pdev->dev, "%s: failed to get sync: %d\n", __func__, ret); return ret;