From patchwork Tue Oct 27 13:56:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 312347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC5C1C63777 for ; Tue, 27 Oct 2020 16:02:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CA5521D7B for ; Tue, 27 Oct 2020 16:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603814535; bh=DdVhnljRUtl+cIhvvuIZwihVhPauS9K7dhmPnfcjnRE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zWE83oYhoUVMWQXB8Mfu5ykVwcs3bzOHzWueoblUt7zGWVZoMTzv9holjGwHmW+BL LFsr9Blgkrvc4cXXBzjWjJxyJCjFs8nQkRRNbrYE8b439LwxgVI2+xXCJWEdxrNooD DDF8f6myi2tYvBMNEvMIvt7Q1KGR/r43nByiNni8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1789744AbgJ0QCA (ORCPT ); Tue, 27 Oct 2020 12:02:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:54164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1803318AbgJ0Pwf (ORCPT ); Tue, 27 Oct 2020 11:52:35 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F4B120678; Tue, 27 Oct 2020 15:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603813953; bh=DdVhnljRUtl+cIhvvuIZwihVhPauS9K7dhmPnfcjnRE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bgJT6BLHvfqp4Eh+4k3dWgW0+5Dkca/EQEPiXFhf8xzKeRhMKxmUm30cTYuxsHcZX 6F53YmOKE3Fhl8GJc+lLJNMhhVRIDjA6NJaAFyXo3vOMv1umGJ5UPIXDTNWKXcUWM6 CgrnlbQ2M6c8P7SMuqo8gStCdtN09WlGFiOYCkME= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dinghao Liu , Marcel Holtmann , Sasha Levin Subject: [PATCH 5.9 727/757] Bluetooth: btusb: Fix memleak in btusb_mtk_submit_wmt_recv_urb Date: Tue, 27 Oct 2020 14:56:17 +0100 Message-Id: <20201027135524.611262484@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dinghao Liu [ Upstream commit d33fe77bdf75806d785dabf90d21d962122e5296 ] When kmalloc() on buf fails, urb should be freed just like when kmalloc() on dr fails. Signed-off-by: Dinghao Liu Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 8d2608ddfd087..f88968bcdd6a8 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -2896,6 +2896,7 @@ static int btusb_mtk_submit_wmt_recv_urb(struct hci_dev *hdev) buf = kmalloc(size, GFP_KERNEL); if (!buf) { kfree(dr); + usb_free_urb(urb); return -ENOMEM; }