From patchwork Mon Dec 28 12:49:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 352623 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp9740040jai; Mon, 28 Dec 2020 05:19:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJwS0uuCQYxKHiHM1QbrpWXBmuaIS2AMwTZvtSXTqwZcqtm4jxxkeiLD0ZGDdCIauJZoteuA X-Received: by 2002:a05:6402:2da:: with SMTP id b26mr42552359edx.350.1609161554750; Mon, 28 Dec 2020 05:19:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609161554; cv=none; d=google.com; s=arc-20160816; b=fFKGUS/ZOGDlNmrtvbUYoZKGVj8wMBzuiYuLiFy0+xEIBtKOXctwALgHlopJfptYhG t38jO8f4/HDvOPHpz0mMugOIWVWCOOKGyfZMZI89wrAeIE13twbsdtRP04zO59nLI7Nx q/6/TEZTJWtc3I00bcVqBf12catkBiGIiRw/i92ZQbe6Ep7rFQr7MGPANn8CmT4mTe0u WSGoz0nZZeaQuUdDSp0D1x+8Oq0GuUBNvKx2kWCpd3SppyviJfvOPXV86gsh8//hUVaC EwA/rGpHjb9i9zpRm+QPiMVVXybi8xha7zpZRAn0HEveTQrd1ZXXa8Pjp6vCHg5Me4RJ YSAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uucUfe2zCjocnN+wbSFCnhAlDVc71tqPEXLgwaeltH0=; b=hUt9eC6SNQMb/mlDZNXx27aLjAx0guKpwNQcD3imTUASgk7ayZ8WgywnhcKvslZHUv BSdfYuR9pNnWfI6kMS7imyCCF5j5OTwX+70dNyA4NDZA+jmBYC1HuWo9PN4lKbMJXK6s xM3ppMxO1iXYZviJBm4F9qNQ3MLPT58P7HIBSp1DN38gtiwP+bVToiL6Vz+cnUf7GmFv 5WeK8Ad/sJlifWf4Utm2z0DtDZs4A/JTQXhDItpvQDLFdpudtLOPvmwLzRsaLYG1PEMV QossQMMqVu6HN8Xf6vKGiY+B9nvJZr0BjTj1aDI6yz9GWM2hur9NWoy0oa203A4XpLyt hpHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ubMcuKju; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y15si20053052edu.550.2020.12.28.05.19.14; Mon, 28 Dec 2020 05:19:14 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ubMcuKju; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732821AbgL1NQS (ORCPT + 14 others); Mon, 28 Dec 2020 08:16:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:44004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732835AbgL1NQB (ORCPT ); Mon, 28 Dec 2020 08:16:01 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3355022583; Mon, 28 Dec 2020 13:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609161345; bh=JevaJKgB0OQZVfFrtoZeKjvd2DOI6bStpsdjPtf2Kkk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ubMcuKju+q2r5TiykRdJOgI+us1K53YmT5FRK9XEOi+t3ASiHl5T3oTAuLfImM8z1 odsfxI7Vay0Cq0HgnNeoSEUCShopf9caP3qgmlGJ0dqo2hjQEKPfvsu6odQ/NOtkFD 0NztR1QZHhPq+k70OsS7hCbuEZJtbeThBAD3+QiY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Dmitry Torokhov Subject: [PATCH 4.14 184/242] Input: cyapa_gen6 - fix out-of-bounds stack access Date: Mon, 28 Dec 2020 13:49:49 +0100 Message-Id: <20201228124913.747270605@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228124904.654293249@linuxfoundation.org> References: <20201228124904.654293249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann commit f051ae4f6c732c231046945b36234e977f8467c6 upstream. gcc -Warray-bounds warns about a serious bug in cyapa_pip_retrieve_data_structure: drivers/input/mouse/cyapa_gen6.c: In function 'cyapa_pip_retrieve_data_structure.constprop': include/linux/unaligned/access_ok.h:40:17: warning: array subscript -1 is outside array bounds of 'struct retrieve_data_struct_cmd[1]' [-Warray-bounds] 40 | *((__le16 *)p) = cpu_to_le16(val); drivers/input/mouse/cyapa_gen6.c:569:13: note: while referencing 'cmd' 569 | } __packed cmd; | ^~~ Apparently the '-2' was added to the pointer instead of the value, writing garbage into the stack next to this variable. Fixes: c2c06c41f700 ("Input: cyapa - add gen6 device module support") Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20201026161332.3708389-1-arnd@kernel.org Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/mouse/cyapa_gen6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/mouse/cyapa_gen6.c +++ b/drivers/input/mouse/cyapa_gen6.c @@ -573,7 +573,7 @@ static int cyapa_pip_retrieve_data_struc memset(&cmd, 0, sizeof(cmd)); put_unaligned_le16(PIP_OUTPUT_REPORT_ADDR, &cmd.head.addr); - put_unaligned_le16(sizeof(cmd), &cmd.head.length - 2); + put_unaligned_le16(sizeof(cmd) - 2, &cmd.head.length); cmd.head.report_id = PIP_APP_CMD_REPORT_ID; cmd.head.cmd_code = PIP_RETRIEVE_DATA_STRUCTURE; put_unaligned_le16(read_offset, &cmd.read_offset);