[07/18] mm/vmalloc: separate put pages and flush VM flags

Message ID	20210205023224.fy2bx0YLU%akpm@linux-foundation.org
State	New
Headers	show Return-Path: <stable-owner@kernel.org> Date: Thu, 04 Feb 2021 18:32:24 -0800 From: Andrew Morton <akpm@linux-foundation.org> To: akpm@linux-foundation.org, dja@axtens.net, hch@lst.de, linmiaohe@huawei.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, rick.p.edgecombe@intel.com, stable@vger.kernel.org, torvalds@linux-foundation.org, willy@infradead.org Subject: [patch 07/18] mm/vmalloc: separate put pages and flush VM flags Message-ID: <20210205023224.fy2bx0YLU%akpm@linux-foundation.org> In-Reply-To: <20210204183135.e123f0d6027529f2cf500cf2@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk
Series	[01/18] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page \| expand [01/18] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page [02/18] mm: hugetlb: fix a race between freeing and dissolving the page [03/18] mm: hugetlb: fix a race between isolating and freeing page [04/18] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active [06/18] mm, compaction: move high_pfn to the for loop scope [07/18] mm/vmalloc: separate put pages and flush VM flags [09/18] mm: thp: fix MADV_REMOVE deadlock on shmem THP [10/18] memblock: do not start bottom-up allocations with kernel_end [13/18] mm/filemap: add missing mem_cgroup_uncharge() to __add_to_page_cache_locked() [17/18] mm: hugetlb: fix missing put_page in gather_surplus_pages()

Message ID

20210205023224.fy2bx0YLU%akpm@linux-foundation.org

State

New

Headers

Date: Thu, 04 Feb 2021 18:32:24 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: akpm@linux-foundation.org, dja@axtens.net, hch@lst.de,
	linmiaohe@huawei.com, linux-mm@kvack.org,
	mm-commits@vger.kernel.org, rick.p.edgecombe@intel.com,
	stable@vger.kernel.org, torvalds@linux-foundation.org,
	willy@infradead.org
Subject: [patch 07/18] mm/vmalloc: separate put pages and flush VM
 flags
Message-ID: <20210205023224.fy2bx0YLU%akpm@linux-foundation.org>
In-Reply-To: <20210204183135.e123f0d6027529f2cf500cf2@linux-foundation.org>
User-Agent: s-nail v14.8.16
Precedence: bulk

Series

[01/18] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page | expand

Commit Message

Andrew Morton Feb. 5, 2021, 2:32 a.m. UTC

From: Rick Edgecombe <rick.p.edgecombe@intel.com>
Subject: mm/vmalloc: separate put pages and flush VM flags

When VM_MAP_PUT_PAGES was added, it was defined with the same value as
VM_FLUSH_RESET_PERMS.  This doesn't seem like it will cause any big
functional problems other than some excess flushing for VM_MAP_PUT_PAGES
allocations.

Redefine VM_MAP_PUT_PAGES to have its own value.  Also, rearrange things
so flags are less likely to be missed in the future.

Link: https://lkml.kernel.org/r/20210122233706.9304-1-rick.p.edgecombe@intel.com
Fixes: b944afc9d64d ("mm: add a VM_MAP_PUT_PAGES flag for vmap")
Signed-off-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
Suggested-by: Matthew Wilcox <willy@infradead.org>
Cc: Miaohe Lin <linmiaohe@huawei.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Daniel Axtens <dja@axtens.net>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/linux/vmalloc.h |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

--- a/include/linux/vmalloc.h~mm-vmalloc-separate-put-pages-and-flush-vm-flags
+++ a/include/linux/vmalloc.h
@@ -24,7 +24,8 @@  struct notifier_block;		/* in notifier.h
 #define VM_UNINITIALIZED	0x00000020	/* vm_struct is not fully initialized */
 #define VM_NO_GUARD		0x00000040      /* don't add guard page */
 #define VM_KASAN		0x00000080      /* has allocated kasan shadow memory */
-#define VM_MAP_PUT_PAGES	0x00000100	/* put pages and free array in vfree */
+#define VM_FLUSH_RESET_PERMS	0x00000100	/* reset direct map and flush TLB on unmap, can't be freed in atomic context */
+#define VM_MAP_PUT_PAGES	0x00000200	/* put pages and free array in vfree */
 
 /*
  * VM_KASAN is used slighly differently depending on CONFIG_KASAN_VMALLOC.
@@ -37,12 +38,6 @@  struct notifier_block;		/* in notifier.h
  * determine which allocations need the module shadow freed.
  */
 
-/*
- * Memory with VM_FLUSH_RESET_PERMS cannot be freed in an interrupt or with
- * vfree_atomic().
- */
-#define VM_FLUSH_RESET_PERMS	0x00000100      /* Reset direct map and flush TLB on unmap */
-
 /* bits [20..32] reserved for arch specific ioremap internals */
 
 /*

[07/18] mm/vmalloc: separate put pages and flush VM flags

Commit Message

Patch