From patchwork Wed May 12 14:45:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 435662 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp5126070jao; Wed, 12 May 2021 12:37:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3shb8QhWv+2Sc1a9NPgBvb6N1j1LHPFb7fUwyt1KxVXqlLCRu3pkK8XglVdBLQ2v5P7dV X-Received: by 2002:a02:91c1:: with SMTP id s1mr33572011jag.61.1620848240188; Wed, 12 May 2021 12:37:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620848240; cv=none; d=google.com; s=arc-20160816; b=xjLT5BA8U5mqorrHBKL0siAsOM2WYuUGSjoXKZ9Bfq2kn703rDP6C3g7V5fdUkbz/q NPxpdwu8wcrbxDpFJpYbo2btdK/Rs0sNrdGlJ3ugsvYxV5BGMfbY1u7AtLjSvyBwvLWK I0U8p73+VMLT/xbPlZ/C+1Tx2zZqkxakspSQxpSrcYV4jCXKQMKBIEvS2LwzOvJrBJ5+ mjlVQdziyH+r+qEs+l0apRqTXeFD2R1/6rMba7r/HTcYaYNYMr0Cc0/VTl5JegAgHxRn tvbVS7GLr9CwxGWpf5xvvwfHknmx/mHZpiV4ZKufmZpR/gwbfRw7i8nXtofBbwyPuu59 UVmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JD/OJSVOkAxdRWq6datypAJHO7a2mOauubOjDD8X1Cs=; b=GJcli7N7b8YY/kJeQUsehK1hTkOkiNzsaasWgjNeqaMrhUCXnFHco/Y2gQvkeKKFcF vb1XoZ5JAyjyj43mahMxnlVtEV0xDXwYYmSSXCtD7zD9UYiSZamaWawfKkze4HJrM96s kZD/fFPXuo96v7q34DAiUBhEjvInoEwoOMhh46T9PzXe8zezrbdmhYeWODAxuzOBA0eK KcaNxr05UK4zudEAirAEr0/roir8OyTJOvVhCkcDoSZMLugG7+C4GITs0VkKs/NeFsm6 3CDeVG1ndEDb6Y1AAmzoqdYQvlDi7Uc9kqc3UA7iuaUllMpvucFu3xzVotCqo7Nh0bnA t0OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fap4ADOu; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si330223ior.12.2021.05.12.12.37.20; Wed, 12 May 2021 12:37:20 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fap4ADOu; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242568AbhELQpW (ORCPT + 12 others); Wed, 12 May 2021 12:45:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:57410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239372AbhELQhG (ORCPT ); Wed, 12 May 2021 12:37:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C7F6C61E26; Wed, 12 May 2021 16:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620835324; bh=e3OOcQJpqFZGaR6u1gY8aZUXjS+i30BuumWbEPhDvuQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fap4ADOuZ02YaAWqaz2AlCO/HJV/K1qfnccKWqIAbkaLMpyXg8lSSYSa+8wif2RR8 BhgDr6uw75r44TWdvHEZXWtKOQ3E3nQWq6WMXbz1GKt5DCVWXrVCKjAkR0RoWk3xgt CWRiGr2X4lMeZmlDcETK93cWA53NWlnvXB1B8oi0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Marc Zyngier , Sasha Levin Subject: [PATCH 5.12 263/677] irqchip/gic-v3: Fix OF_BAD_ADDR error handling Date: Wed, 12 May 2021 16:45:09 +0200 Message-Id: <20210512144845.971783232@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144837.204217980@linuxfoundation.org> References: <20210512144837.204217980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 8e13d96670a4c050d4883e6743a9e9858e5cfe10 ] When building with extra warnings enabled, clang points out a mistake in the error handling: drivers/irqchip/irq-gic-v3-mbi.c:306:21: error: result of comparison of constant 18446744073709551615 with expression of type 'phys_addr_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (mbi_phys_base == OF_BAD_ADDR) { Truncate the constant to the same type as the variable it gets compared to, to shut make the check work and void the warning. Fixes: 505287525c24 ("irqchip/gic-v3: Add support for Message Based Interrupts as an MSI controller") Signed-off-by: Arnd Bergmann Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20210323131842.2773094-1-arnd@kernel.org Signed-off-by: Sasha Levin --- drivers/irqchip/irq-gic-v3-mbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/irqchip/irq-gic-v3-mbi.c b/drivers/irqchip/irq-gic-v3-mbi.c index 563a9b366294..e81e89a81cb5 100644 --- a/drivers/irqchip/irq-gic-v3-mbi.c +++ b/drivers/irqchip/irq-gic-v3-mbi.c @@ -303,7 +303,7 @@ int __init mbi_init(struct fwnode_handle *fwnode, struct irq_domain *parent) reg = of_get_property(np, "mbi-alias", NULL); if (reg) { mbi_phys_base = of_translate_address(np, reg); - if (mbi_phys_base == OF_BAD_ADDR) { + if (mbi_phys_base == (phys_addr_t)OF_BAD_ADDR) { ret = -ENXIO; goto err_free_mbi; }