From patchwork Mon May 31 13:13:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 450504 Delivered-To: patch@linaro.org Received: by 2002:a02:c735:0:0:0:0:0 with SMTP id h21csp869481jao; Mon, 31 May 2021 07:16:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxikpeMEuSZXZL0sjBqFE4YSXSZrVdQKhCKag+Bvt9XQd5T+akYPvlWvhU4/56BXiPMWLk5 X-Received: by 2002:a17:906:2510:: with SMTP id i16mr1992121ejb.218.1622470572175; Mon, 31 May 2021 07:16:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622470572; cv=none; d=google.com; s=arc-20160816; b=ULdcpNNg7zUg8jlP483hLb6fkr84oKXCPWxvKO0+EdQuLxE2cxnKogQiO/K6xSB2Zu gXPCJa0gHh/RIq82wUQWcXSRykEWe6SgowqhWOHn4ayEeDaFVAvGrq6vvV+0K/vxcYTx ayf8Et0H1Bv5PcPluRL+oZ/RpjRlxNou5q1bF3bSO0c+QqoMEzJ6a6pK2s1d6DXTVFXb 1CcK64HOVbo4LxnaP6HECiNFb+zn4qBR6WRQ5zGTCCDW5qus2dOKwpe2b0uw8054vsmL F48L8CK8qZuEw2q4uzAGgyBAUeDoT3ZaTO/eDJHUPChj3yqR1/8kYN4ia5U5hmTKtM7f mY8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GIu4cYHhP9VKpUuekjcUnxMN4NUhWCyy0VHbKCsR724=; b=enccGpfVAiarV1iMs0VUxU0lD8jijL3tm/2EsPuL4lnU1Wqq2L4DkYl0YV7C9yS148 2mFOX0r7GZtdbQtIPr9GvPqFUmYOTek3A+MUxNRlUPTgue/RssDY8sfqYJTmEEylW3Jk ImZkmIXfyBqj1w0nT5VnG8NtkMz3Q2OGChw465ffAba+jtlQvUjd00uGw1bzXeMmzoC4 2fIYd9zJoFAOkMWShEj4rpBg2rQO7gqjwMMy4xqgdbZgt4mizdoRA1oJcO+p62yk2swL XP2NgrLCrMJPtDeow+52V8cbdX6tYWLXrsvCdgp6/j4m6AiaKoW9DQih4cXBOrn5T9Fm Qq+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IycZef0m; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y9si9695198edd.548.2021.05.31.07.16.11; Mon, 31 May 2021 07:16:12 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IycZef0m; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231977AbhEaORn (ORCPT + 12 others); Mon, 31 May 2021 10:17:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:43312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233795AbhEaOPk (ORCPT ); Mon, 31 May 2021 10:15:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8D1E561482; Mon, 31 May 2021 13:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622468581; bh=WYKlr1WpWyge+aGeXdCxj0ZJSnge1bGb/5m24pQGkeM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IycZef0mqPCKgZGLij7kJlzdYkt1kSExgf2jNXl0PeR6HRC8pm9iLI4liP1ePjRbs f8hTqmR4old3cUKu/rquEWm5nNoCGK6lW0bB5w7iqqietknlXaYzV/AjvayNNYn1vp P/vFv3C6msYYEgfWz6Rd9/Imm5d06+GFjkzWzjDw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mauro Carvalho Chehab , Rui Miguel Silva , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.4 044/177] iio: gyro: fxas21002c: balance runtime power in error path Date: Mon, 31 May 2021 15:13:21 +0200 Message-Id: <20210531130649.436435309@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210531130647.887605866@linuxfoundation.org> References: <20210531130647.887605866@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Rui Miguel Silva commit 2a54c8c9ebc2006bf72554afc84ffc67768979a0 upstream. If we fail to read temperature or axis we need to decrement the runtime pm reference count to trigger autosuspend. Add the call to pm_put to do that in case of error. Fixes: a0701b6263ae ("iio: gyro: add core driver for fxas21002c") Suggested-by: Mauro Carvalho Chehab Signed-off-by: Rui Miguel Silva Link: https://lore.kernel.org/linux-iio/CBBZA9T1OY9C.2611WSV49DV2G@arch-thunder/ Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/gyro/fxas21002c_core.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/iio/gyro/fxas21002c_core.c +++ b/drivers/iio/gyro/fxas21002c_core.c @@ -333,6 +333,7 @@ static int fxas21002c_temp_get(struct fx ret = regmap_field_read(data->regmap_fields[F_TEMP], &temp); if (ret < 0) { dev_err(dev, "failed to read temp: %d\n", ret); + fxas21002c_pm_put(data); goto data_unlock; } @@ -366,6 +367,7 @@ static int fxas21002c_axis_get(struct fx &axis_be, sizeof(axis_be)); if (ret < 0) { dev_err(dev, "failed to read axis: %d: %d\n", index, ret); + fxas21002c_pm_put(data); goto data_unlock; }