From patchwork Mon May 31 13:12:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 450499 Delivered-To: patch@linaro.org Received: by 2002:a02:c735:0:0:0:0:0 with SMTP id h21csp850113jao; Mon, 31 May 2021 06:53:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWS5wpBq/i62sqD4D0S2OkZfnubaOW4TpUHMLodlJomiuEebx7mDUmgELhIPhzGWXoMRop X-Received: by 2002:a02:a316:: with SMTP id q22mr20214555jai.26.1622469210449; Mon, 31 May 2021 06:53:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622469210; cv=none; d=google.com; s=arc-20160816; b=z95m86F2OpeTn2ZJP/zpWXods0340vyUmi06m4d4UafIfxpsYPnuq8x2GTHukOocMo CEgVL7R6yBFekJGQ76jYM0szoiswBB5mA0jHon4NRY9sCiypIAyCJn1e8i5na8JErn84 s5Y1mVvN5qQu4x8tyeid/4eVW2w9TyZemDhoo0u6poBtFtEY7DD8H9v2I8enIkqwZ49P RpGRpcNyinJMwhl7cxEi/acVRiZ5ic5abZutu7IfQRbYoZnClvCPkbnr0o4+CYzrytBN IPRqJnUAV9Olwo3OzXbbcsdEKMd+FbwkeclEpescBw+Y5/HrzAbALyPSLQkRESm7FCiD emmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0DUi4w49LGQq7ZddOjIgqe2iR9bZC9cDkh6aHXPJoQM=; b=m66I75DPhrUuxU16KbqURlGnrZ62aQelwpnNO+TUasUqviyUdchwF1srwOkudbYxDt UlOiuxz9raYtWrEuDp4Ys6KKXLcFEjhsm3maVP0AONf1NbuAuEZiG7zleZCbDGLXm4lk X5YWYFOqSL/0OiqOvtDen8ql1naB1lz+qHIB3/kYkuM81W0dlfDUtZZY4Fn7krDrMHRG 1jDSS46NR9nVJmliljxzg8htaJ2Duo9skK1npwlfxhKWeuoZvbo+IVBYElWW1AWirK1e 5bOIBTTDipbT45tDl+E4xT7vW/pJ/VKH6+Aw2vTGVgomCDb32GIaGBXiceFflZp5NgdN IQFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iDpzHtGg; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si16461652ili.90.2021.05.31.06.53.30; Mon, 31 May 2021 06:53:30 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iDpzHtGg; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232130AbhEaNyK (ORCPT + 12 others); Mon, 31 May 2021 09:54:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:55328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232460AbhEaNvl (ORCPT ); Mon, 31 May 2021 09:51:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5DB5F616EB; Mon, 31 May 2021 13:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622467951; bh=DSf4XqPjzvaq/zKi0DCw4Gh+8Dfiy3EAaMlzty3/gvc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iDpzHtGgKSbG4Rxqzm7a3gO0cWXYbeA877YypDrj/O/+HLyGkKxLnPvOliSTaKVpi QrEHQdszT+OWO05+teKqaS1Z/AvzEJ57+fTo1B7tUYhY40f+R8Hlmv7cegexslzL7N gsqV7RVU4djkXTP0Ztn1lt0/XU9MVahCY3HOsPB8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mauro Carvalho Chehab , Rui Miguel Silva , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.10 061/252] iio: gyro: fxas21002c: balance runtime power in error path Date: Mon, 31 May 2021 15:12:06 +0200 Message-Id: <20210531130700.050104168@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210531130657.971257589@linuxfoundation.org> References: <20210531130657.971257589@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Rui Miguel Silva commit 2a54c8c9ebc2006bf72554afc84ffc67768979a0 upstream. If we fail to read temperature or axis we need to decrement the runtime pm reference count to trigger autosuspend. Add the call to pm_put to do that in case of error. Fixes: a0701b6263ae ("iio: gyro: add core driver for fxas21002c") Suggested-by: Mauro Carvalho Chehab Signed-off-by: Rui Miguel Silva Link: https://lore.kernel.org/linux-iio/CBBZA9T1OY9C.2611WSV49DV2G@arch-thunder/ Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/gyro/fxas21002c_core.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/iio/gyro/fxas21002c_core.c +++ b/drivers/iio/gyro/fxas21002c_core.c @@ -399,6 +399,7 @@ static int fxas21002c_temp_get(struct fx ret = regmap_field_read(data->regmap_fields[F_TEMP], &temp); if (ret < 0) { dev_err(dev, "failed to read temp: %d\n", ret); + fxas21002c_pm_put(data); goto data_unlock; } @@ -432,6 +433,7 @@ static int fxas21002c_axis_get(struct fx &axis_be, sizeof(axis_be)); if (ret < 0) { dev_err(dev, "failed to read axis: %d: %d\n", index, ret); + fxas21002c_pm_put(data); goto data_unlock; }