From patchwork Tue Jun 8 18:26:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 455799 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp4004924jae; Tue, 8 Jun 2021 11:39:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6JJMaP3mRAVAbPkEYJMYyMNq8F41Z2CCCTO0sQySjY2d8NGP+9nMgpnenu1RgbeEJ2Aew X-Received: by 2002:a50:a413:: with SMTP id u19mr22376031edb.251.1623177576889; Tue, 08 Jun 2021 11:39:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623177576; cv=none; d=google.com; s=arc-20160816; b=piQrgovJj/1SVxG37maz6j3713FpxlGyCQnRG3/s4Hfq11WNlEJ62u5p1OWuWG2jt/ xPQi/0JY7kZxQCGopZ+B/Lr7uUFJNlHh09MW1Gttdtt+5XIMHQG+Y+G/Pbhmx9YR8++t ErbsVjqcNm62qV2s7q1pUwd5bdvmsSE7Z8TPNu3QSyVFFk//H+vXFxzvA6JiVnAK8dyr KcvSgNWRiXDhN9W7QkIsBtjJ3O1iHI5w0kCI+a3nrrDZg2QPZn2iEX6SI5cLu+9Ayl8+ 2n7Y5AEISfncFqUUFeMGwm626rw2+zyz60qb2GLkVdgcehjr2135KYs4PHbaCHPsiqOt ykSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=J7UZByMJSOAY6reM4//XCQ6dn1xKG/ywPwyWwiZHH0M=; b=fOas9zJygwKSPZEmJFK6qMhiSO4AjkfE+r6Tyizs8Eva5dBq7hudwmSeNWB7SIpp30 3ir1uNhG83/z3a20z89u+AASN3vH5udUzVjld1jEyFKomO3JDIcBqw6n3zfWrrRZVErd zM8blaSZ5WaJvbo18bcZff85EdpWxrIbpRIjG33uQXjdnCFArdJ4c6vC9lq4EWmoHnr4 vNdZXh1qsi4CWhvEPi4Fv+Da5fyR2D+gUXK/KHf23kvy6iQ28uWHm1qNRaychvOZNVxe /8l17vSVLblqFEe3ms1tPy/hMMaaRJrIIQti9yleWbKDCA3NCWuIFHDAqT0JZHDyJXPj 9AGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=F6ZOoREq; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f26si395533ejl.276.2021.06.08.11.39.36; Tue, 08 Jun 2021 11:39:36 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=F6ZOoREq; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234996AbhFHSk4 (ORCPT + 12 others); Tue, 8 Jun 2021 14:40:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:36824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235274AbhFHSjk (ORCPT ); Tue, 8 Jun 2021 14:39:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E5186142C; Tue, 8 Jun 2021 18:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623177256; bh=lKpCVtXD3B8w7NgXNJYxyJ62U+u4UoNXBhi14EH6Lao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F6ZOoREq2gAYmUqy6BskpO7Hps2VnZYGq8+4VMwiEKij1B3g6hBtKKN98e8e7zU2x C58ddZXQFoyOAg0zLMzyhB5I3pc4U/ARapWrtsGI1hOlRbGlftRnoccEQMnVH4ENq6 VLA8vE2y2qvSk8O8xxdFy4W5ih5MiYAwdOd05yJw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Jiri Kosina , Sasha Levin Subject: [PATCH 4.19 11/58] HID: pidff: fix error return code in hid_pidff_init() Date: Tue, 8 Jun 2021 20:26:52 +0200 Message-Id: <20210608175932.653779039@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210608175932.263480586@linuxfoundation.org> References: <20210608175932.263480586@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit 3dd653c077efda8152f4dd395359617d577a54cd ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 224ee88fe395 ("Input: add force feedback driver for PID devices") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/usbhid/hid-pidff.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 08174d341f4a..bc75f1efa0f4 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -1304,6 +1304,7 @@ int hid_pidff_init(struct hid_device *hid) if (pidff->pool[PID_DEVICE_MANAGED_POOL].value && pidff->pool[PID_DEVICE_MANAGED_POOL].value[0] == 0) { + error = -EPERM; hid_notice(hid, "device does not support device managed pool\n"); goto fail;