From patchwork Tue Jun 8 18:27:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 455811 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp4020518jae; Tue, 8 Jun 2021 11:59:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvVzTvwcuaKze1Cdm+pGiJ9uV/IIhCZcKWYSJ2LX69bl1zujtZRNgZMWIrVsuoikxmmpRm X-Received: by 2002:a50:ff16:: with SMTP id a22mr26887974edu.143.1623178780479; Tue, 08 Jun 2021 11:59:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623178780; cv=none; d=google.com; s=arc-20160816; b=ahFbgNYDv0jvClfZj9GZrfGDfwOjTV+qn8jnIWX5gwlgQGWx1a2qEMONWuWy50GGPT cDJs2kmoDbBv/QU+t66pb6lg6L2NmaZ4NTOa0I/2Xa+e2kqqrTGsZ7J/zmJCEC/WaYr3 nRc3vVkWFnjT+EdbTydLxN4GpJt0CvDs4FwM3uMBXLloYwVs6Dc6bZ+8fyhUA8J6Eqyj Ed2LR5X7A0U854xoVw5SId9wF706VF3M8mJb90TwRbEJbvrnjKdmekBztuXJ0IO89gdV i8dm6dlYlyvogfNIk+tb32WdGAtDj3aBrLlUM6J7T4QBc7lDWCdg7kd8mMl+5wfREL7p LFZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uzUv3C7lBHQr1geg8Ub36SmmFRG+oK2Zfa1YNYuSl40=; b=D29P82dQvYCLRnYV5t2EPh1FzmmY+rWbLzv0e5OPRzLEM8WsRfrT9CE4WpmDlZYkIL 8CT7se2DX0tCe7sLuI6cD19sO+UOheb0hTz8L0xAuMH+ZQSQMMuKJItL4Po++51JyPDE y1fdcczg6tyOex315fc32R/j5yGY7HJTqtKR4q0ce4RAXmDJ6xGTKTvJ1WRBOW5s14Lb MlpBv7ehS/8vvax4TVLq4ndhsmN1mLZQI11sgnIxedE2NvnH891w5dmOG5ljK6XXvdPf qXeT3a9F0K+bBSRXRPhzUyRuy84WHMgD2s9uQW8DO5UmcY/FAZwDubpjgseQdoXzu0HK lfBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JF8wI4yY; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e3si288626ejm.412.2021.06.08.11.59.40; Tue, 08 Jun 2021 11:59:40 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JF8wI4yY; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236266AbhFHTB0 (ORCPT + 12 others); Tue, 8 Jun 2021 15:01:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:33092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237128AbhFHS5Y (ORCPT ); Tue, 8 Jun 2021 14:57:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F1D6961622; Tue, 8 Jun 2021 18:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623177746; bh=CAnlmVg2OB/1ByO4Wsm94f5zmagty4A3TeD/u65t30k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JF8wI4yY7xETEez5DSUV9kEVGPXq/eWEVSnKFx6z9M/UUOYiWSQJrt4MaXtFUrGOk LpCgWEl7skgVTp7SHT9ODmSazjg0wYTjApyluJBkcaMl3WHa4m3P4mPLQszMJWtohK 5POyJ9Dw7OV4GuvUCMNXgL3txD2+Vurmd1kLgcxA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Jason A. Donenfeld" , "David S. Miller" Subject: [PATCH 5.10 085/137] wireguard: allowedips: initialize list head in selftest Date: Tue, 8 Jun 2021 20:27:05 +0200 Message-Id: <20210608175945.242677364@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210608175942.377073879@linuxfoundation.org> References: <20210608175942.377073879@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jason A. Donenfeld commit 46cfe8eee285cde465b420637507884551f5d7ca upstream. The randomized trie tests weren't initializing the dummy peer list head, resulting in a NULL pointer dereference when used. Fix this by initializing it in the randomized trie test, just like we do for the static unit test. While we're at it, all of the other strings like this have the word "self-test", so add it to the missing place here. Fixes: e7096c131e51 ("net: WireGuard secure network tunnel") Cc: stable@vger.kernel.org Signed-off-by: Jason A. Donenfeld Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireguard/selftest/allowedips.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/wireguard/selftest/allowedips.c +++ b/drivers/net/wireguard/selftest/allowedips.c @@ -296,6 +296,7 @@ static __init bool randomized_test(void) goto free; } kref_init(&peers[i]->refcount); + INIT_LIST_HEAD(&peers[i]->allowedips_list); } mutex_lock(&mutex); @@ -333,7 +334,7 @@ static __init bool randomized_test(void) if (wg_allowedips_insert_v4(&t, (struct in_addr *)mutated, cidr, peer, &mutex) < 0) { - pr_err("allowedips random malloc: FAIL\n"); + pr_err("allowedips random self-test malloc: FAIL\n"); goto free_locked; } if (horrible_allowedips_insert_v4(&h,