From patchwork Tue Jun 8 18:25:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 455822 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp4025838jae; Tue, 8 Jun 2021 12:05:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxeec9nbGfKxZX0I+B0EN3UwzXrZtInHU0dchrVwTo0cYchJ+bg+6UO19TVO5HrNNJH+5W X-Received: by 2002:a17:906:2844:: with SMTP id s4mr24531946ejc.263.1623179147416; Tue, 08 Jun 2021 12:05:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623179147; cv=none; d=google.com; s=arc-20160816; b=pwX633wTge9XObOxFXKImRWB4nQIJzfJQjjqyEvSVBiNH5zsM3yPj/g8QsHDeMY/zz UvM5AzXAIW6WOFHD8Trgyy2C+eFehUzGtZfi6l8DZi1DUxwYRXrL/I5PPSnWIlPtBO9v bMmGYAJ515OAm+X/Xm/a96RnHBqMWYpUCCRmfwC5uQl8FSHadIqT4azOyIhESZeNEzD0 fW6Cbc1siSIsjXAG2QHK5Yu8SXKqPyw7UbuPA9QUaDrN9BIq+tQ6R5CEZK6ga+gxOVI7 fRFjPL1X3zOHGLW4y9wUHjXaVM9RToK3LxmP9JqWa/J7XjuYLGZE3GdfAYRCHOafHzpL coVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VowFoDMcySSAkcm8hIL5ezwUu1Xa/HUDB2WkGqXarKA=; b=lJqZPugDSiltA21y094aGAbrjWaPz1obr0V7OyTxw90lYCBy9WTXJoqoxRssomMrw9 jn4UwrvLp5NlL48CXkmqjtotLI/1CUaq/84L/PK59h+A4Iu8LeTNrOCHIahHuVtQSEFo WzzHXWokm/ZQjZPReS76Ugv+MNrhvkAbplSXR32avLh76Q8c+myTXttVbODVVNbqtdLS 3rit5sZvNqSb8q1h5WxQBIo2H9I/DO8hyIh5GRwck6ilFaqv2zlJMHO8So3FADGb/Rjv C3UVDSYdZvCwBojFSDJJQUVJubopKvedwTYjeDQPlH7Rp4wes6JcS3xRhrmiWBfMaWVX TTpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="J2X/vIRR"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x5si390764edv.602.2021.06.08.12.05.47; Tue, 08 Jun 2021 12:05:47 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="J2X/vIRR"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236419AbhFHTGx (ORCPT + 12 others); Tue, 8 Jun 2021 15:06:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:44800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236939AbhFHTDg (ORCPT ); Tue, 8 Jun 2021 15:03:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 14A8261878; Tue, 8 Jun 2021 18:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623177942; bh=34CGAzeAK4npol0yn+k/3p8HDOAEu1dZrpwIwDWrdAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J2X/vIRRrFdAcK5tVVtywtMY3DDL03r+iMjzYPgsK1onwGM2x3gxL64xNcxEeqYsm JsJziiBNSdBbCn7bOBa1TLYola/vlWvl/esXE5v6TDedHotK22gyxvF6voiulwJs3W 90gsh3lWXC1ymtD/ma9810v3S52I3HLFB5JC5kpg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Nathan Chancellor , Jiri Kosina , Sasha Levin Subject: [PATCH 5.12 019/161] HID: i2c-hid: fix format string mismatch Date: Tue, 8 Jun 2021 20:25:49 +0200 Message-Id: <20210608175946.110799035@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210608175945.476074951@linuxfoundation.org> References: <20210608175945.476074951@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit dc5f9f55502e13ba05731d5046a14620aa2ff456 ] clang doesn't like printing a 32-bit integer using %hX format string: drivers/hid/i2c-hid/i2c-hid-core.c:994:18: error: format specifies type 'unsigned short' but the argument has type '__u32' (aka 'unsigned int') [-Werror,-Wformat] client->name, hid->vendor, hid->product); ^~~~~~~~~~~ drivers/hid/i2c-hid/i2c-hid-core.c:994:31: error: format specifies type 'unsigned short' but the argument has type '__u32' (aka 'unsigned int') [-Werror,-Wformat] client->name, hid->vendor, hid->product); ^~~~~~~~~~~~ Use an explicit cast to truncate it to the low 16 bits instead. Fixes: 9ee3e06610fd ("HID: i2c-hid: override HID descriptors for certain devices") Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/i2c-hid/i2c-hid-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.30.2 diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c index 9993133989a5..f9d28ad17d9c 100644 --- a/drivers/hid/i2c-hid/i2c-hid-core.c +++ b/drivers/hid/i2c-hid/i2c-hid-core.c @@ -990,8 +990,8 @@ int i2c_hid_core_probe(struct i2c_client *client, struct i2chid_ops *ops, hid->vendor = le16_to_cpu(ihid->hdesc.wVendorID); hid->product = le16_to_cpu(ihid->hdesc.wProductID); - snprintf(hid->name, sizeof(hid->name), "%s %04hX:%04hX", - client->name, hid->vendor, hid->product); + snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", + client->name, (u16)hid->vendor, (u16)hid->product); strlcpy(hid->phys, dev_name(&client->dev), sizeof(hid->phys)); ihid->quirks = i2c_hid_lookup_quirk(hid->vendor, hid->product);