From patchwork Mon Jun 14 10:28:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 459830 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp3190261jae; Mon, 14 Jun 2021 04:23:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbTDzOGNpi88aXxnNuVgHxn/IO5XSe2oE4iIVqEZ73tVoblVwy7rDD0p4nueMwVH42HGHT X-Received: by 2002:a05:6402:12d8:: with SMTP id k24mr16561335edx.47.1623669807244; Mon, 14 Jun 2021 04:23:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623669807; cv=none; d=google.com; s=arc-20160816; b=XFqGi0JbJqlsZN6KUiPiXHUDyQWjRnJ0OL2IzL+7V8ItnoQptLuo68z4faYywwpYmP fgit/IVf6g/zg6UtRAv2S/MV453tmsWCDhxGV0V6382qDfGfxD4GseuI/+vDDbqS8Z/0 PjlDiFlnSPvsgFNVETMybiboVqkYz+PMT08+ijtU4YYnKAIP0hcNSuAm/J/ZngUMFXZN IPw9A0slWuOyCFZ4VlYOyHKnWeXas7NqI6YAaK8bCIa+6ICH1czynjO9fiZM9mF6JcC2 TzBPejkeI3uH8VeJKfqdbOsee14E5btGHLFupikKuUzFtMpCChRXgOtfxwxgq0Tpxbem aaog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=adsvo7+gFsXc+lP/HyX7JwLGI+Tu6YfEU/hu+yUP06k=; b=hFsFXahBL5IY3YYxfHAK7TH2hMmva+/3K+QL2+ogq+HsyenmWYmSy1xWYqz3ayiIyA ZW1bw/MrSEV6uTgfzynpenVHKWYedaD5hrTrTADJrpFp/nCV9nPLsMWvUf849RntP1mv vl3fS54s+0rpybzpYZkgBSE0HlEw4GksABigLbgngMGu6LDKrhnTBvai4fXa23rvHPTw GPQdEoghYoNvltS4toHsqCV0OCS5ptzfh9d2OVBkiQwlkOvT/ZvYdIAv5bpkXYTaqfuy 0VXvdx2tRINIqb6CNoSM6QtYaFbF4q7NMLTuhcqJTxORPOvkFQU5B7t6c0kK2Ws/BERy nFPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=NoFrBneC; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l18si11240982ejq.514.2021.06.14.04.23.27; Mon, 14 Jun 2021 04:23:27 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=NoFrBneC; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234869AbhFNLZT (ORCPT + 12 others); Mon, 14 Jun 2021 07:25:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:50580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235581AbhFNLWj (ORCPT ); Mon, 14 Jun 2021 07:22:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0FFC461480; Mon, 14 Jun 2021 10:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623667980; bh=maORWLPVrr9ivQoLTNE0VfpAaNk2Qk2q3HQkmhtjt/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NoFrBneCkuJFa9K/S/sIjS2Q3K7hWweYXXLmKLKKl5IV/e1I154OQUOd3qiNs0/Sa r0IFKkrQSMaJyIKZD7zARRWM9v5wTFI5WEYaO9uIN3+yr05mUdySoiXnVFM/eKHo+t R81Jk2u3VjNbspVmsDXNCDfFCLGojSJIpGju30Cg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Andy Shevchenko , Bjorn Andersson , Bartosz Golaszewski Subject: [PATCH 5.12 149/173] gpio: wcd934x: Fix shift-out-of-bounds error Date: Mon, 14 Jun 2021 12:28:01 +0200 Message-Id: <20210614102703.128539930@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210614102658.137943264@linuxfoundation.org> References: <20210614102658.137943264@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Srinivas Kandagatla commit dbec64b11c65d74f31427e2b9d5746fbf17bf840 upstream. bit-mask for pins 0 to 4 is BIT(0) to BIT(4) however we ended up with BIT(n - 1) which is not right, and this was caught by below usban check UBSAN: shift-out-of-bounds in drivers/gpio/gpio-wcd934x.c:34:14 Fixes: 59c324683400 ("gpio: wcd934x: Add support to wcd934x gpio controller") Signed-off-by: Srinivas Kandagatla Reviewed-by: Andy Shevchenko Reviewed-by: Bjorn Andersson Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-wcd934x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpio/gpio-wcd934x.c +++ b/drivers/gpio/gpio-wcd934x.c @@ -7,7 +7,7 @@ #include #include -#define WCD_PIN_MASK(p) BIT(p - 1) +#define WCD_PIN_MASK(p) BIT(p) #define WCD_REG_DIR_CTL_OFFSET 0x42 #define WCD_REG_VAL_CTL_OFFSET 0x43 #define WCD934X_NPINS 5