From patchwork Mon Jul 19 14:50:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 479847 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp4203767jao; Mon, 19 Jul 2021 07:58:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgxGh7tRLjG9yY/CQFcTFOOtN5/3mVmw1FkmGsxBFYntOC392+3bxuSlB3pr4pExN6Q8Eh X-Received: by 2002:a6b:cf15:: with SMTP id o21mr19542247ioa.9.1626706711979; Mon, 19 Jul 2021 07:58:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626706711; cv=none; d=google.com; s=arc-20160816; b=anxEujIrzk+FIxnq31r5nw7nOwGUk1V/By6GZvbs6Op9DmySsbBhyqDf7aNMyY3QE0 TTKbkGlwEnFrJSWHDTSz5ixs58EePUWRu2/VJK5XADltftA4Wmuf4nvkRstn0uikwKb/ iALj7nlgymfx4fsYqbhSi6HEQEtiRfE1ilRARRqRWBWUVzVdsZmal3ra0+xWJgXRTGYj I5S0bIZWagjeBqIBgDD1MeuzDzSG/g2hXyW5AkP4wDYTBnOBmjwaWRcOzIeS/f6Z2Hci CtB7LZqsxWkBXWHhVScy/QTjs4sMjf2XdQchZH6Mhk1+brajDwxb9ntQTgyIY2BwVf+W ez9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=35LmbrjqIeFIJlSpp+FBb4pX4FMm7J1mpU0QX+EU3a4=; b=yTZvREFta1EWUAku3Hwu2EHG3sE0QDpwrqPFJbPEfXindYmfFe3xCIM6Wl1gQXBnKd KvVpIyh4pwlP5z2IV42HzUkxYv41mubFfv+w8LUrX7mOO9I0ns0k/b/qofpKnsmlteZg +1Kj9BcKi9yhQTjZVNutqOOsGkgkHIP4TCwNNMQC8OcF0GKeBKPnoRjr1gWr5Lwmn+rx BfJYJbjdzgJ4eDYHY1lPZx9jnW53TA+JYHErBpDDhw1TC5OMEpeCoCKMiSlf6pxBB49Y /AxmIqqLxiOJDjfi9Wk2HPEoOkckxSXiWWSozgcef2SK7PJgdKYpiiHUklU+FUCDsfQ8 8HRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mr6tYNI5; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r23si2768811iot.18.2021.07.19.07.58.31; Mon, 19 Jul 2021 07:58:31 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mr6tYNI5; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241834AbhGSORu (ORCPT + 12 others); Mon, 19 Jul 2021 10:17:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:51824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241876AbhGSORe (ORCPT ); Mon, 19 Jul 2021 10:17:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 96C9C6113C; Mon, 19 Jul 2021 14:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626706694; bh=IfQ+6XhX+XSWDe++IxnkzQxz7AJBoKZP595+xEwmzRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mr6tYNI5NSn40I9HrP8Xx4u1cdTvYk+L3XBAaSh4muT7Ff4THFl5wVpwoIZnlkP3q /4cqkuKoNAcvS2tpLdxryKrGIGhXX7GEV14BR7Jr8YE8CYZxe80mZNjTMORKepRjsa 5hA6qObb+/G6lXZEz0FTddS4r7veFaiANMd1ayck= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Ulf Hansson , Sasha Levin Subject: [PATCH 4.4 057/188] mmc: usdhi6rol0: fix error return code in usdhi6_probe() Date: Mon, 19 Jul 2021 16:50:41 +0200 Message-Id: <20210719144926.340059214@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144913.076563739@linuxfoundation.org> References: <20210719144913.076563739@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit 2f9ae69e5267f53e89e296fccee291975a85f0eb ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Link: https://lore.kernel.org/r/20210508020321.1677-1-thunder.leizhen@huawei.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/usdhi6rol0.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c index 2b6a9c6a6e96..49798a68299e 100644 --- a/drivers/mmc/host/usdhi6rol0.c +++ b/drivers/mmc/host/usdhi6rol0.c @@ -1751,6 +1751,7 @@ static int usdhi6_probe(struct platform_device *pdev) version = usdhi6_read(host, USDHI6_VERSION); if ((version & 0xfff) != 0xa0d) { + ret = -EPERM; dev_err(dev, "Version not recognized %x\n", version); goto e_clk_off; }