From patchwork Mon Jul 19 14:49:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 479909 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp4226921jao; Mon, 19 Jul 2021 08:22:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzetEspSHjYvujhU2OiHlZyt9OMjQ6u/6vYkPZKsmKzM7QxZHxMUwmV0yavQ9g1wvbnjQkF X-Received: by 2002:a5e:8619:: with SMTP id z25mr6722726ioj.13.1626708178077; Mon, 19 Jul 2021 08:22:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626708178; cv=none; d=google.com; s=arc-20160816; b=rHbD+oFUKwnRNbhiYQi43XcyKFJ+FVNxdOSqFhOQvhN6U5lWEseU7puoHDNz/XIjMj oin6+7lMA87qsDStMVwDe3BMQUcdMvvEqQ2uobD1jRobmdKRRKf39QUp1Nk89brHMe/r xvIK3NNRXA8Vu38HcA6ThqEvGzyyIU1+ULrsfg79RJo+rovMGmKZ7doCg6tvIgjdNBiD 3jL8onQmMJEw8EcUO9IHvVc3HdchiyUXaaz2u8uJwsfOSaALjhdgPZj+BSudyhEJgaKd vt3omj2t0FFqZYX+VGO2utWa6rvoL8bo6ZTVzvvTfzTpMMeZh/01vKm8mxsgIISZulI6 u3FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CXdimATJm77aHGtFIFzD5DvfzAoIkU0p2ls81gMM5A4=; b=S7zFL3HXLfUWGC03tL9RwUWqrS/Y5rOhX/bfAHNz9e42jOn7BpDhX4UAQVvLPwF3gh fQrSRda9+erqVE3Ex+0OBlTu4gB5esWqhKxPZDpBT5Mj0547hHNSOC13+toxMvKioWg7 BJIU5uzWocx4WF6BvSBi1RxedyfzWHMC5+AYc+YpjBbs5pAh4vYBv8EtGrV1t09duDOE piciLbQT5wyx+3ZGfxNgzcnLoizI+I6RgQue2QPrFJ1BgQifRKAz7fec0znfBsbHj7nH WfyO1MifhBLQcHnKovDuLqJ5E03ezly4mjGUjrEYA5Qx4zq+RhNUpk6Ix1dZK5kGwFe0 Ldxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jVoo7TWT; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si9692004iln.71.2021.07.19.08.22.57; Mon, 19 Jul 2021 08:22:58 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jVoo7TWT; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245415AbhGSOmO (ORCPT + 12 others); Mon, 19 Jul 2021 10:42:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:53816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245617AbhGSOjU (ORCPT ); Mon, 19 Jul 2021 10:39:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 86220611C1; Mon, 19 Jul 2021 15:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626707927; bh=X2EDxjvK0rOqzWQFst1vMJ4Jfp9h5hDeMfQyj/fXr0E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jVoo7TWTHX+u9JrJxCpt4rrzgfPwS8l4hodgmJZZGz0MSOka3TJiEtjGb31jU2JVi Xzrt/CP4VnNDVGdFa7Rwn5lGT4BOK1gvH9p6VKaJXfE+NXACrBlV7ylrdu+HADRdYf Af093JDjosUsGqwbVfGMtKRHaJAAgWjncmiL/nFs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Linus Walleij , Herbert Xu , Sasha Levin Subject: [PATCH 4.14 077/315] crypto: ux500 - Fix error return code in hash_hw_final() Date: Mon, 19 Jul 2021 16:49:26 +0200 Message-Id: <20210719144945.400610250@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144942.861561397@linuxfoundation.org> References: <20210719144942.861561397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit b01360384009ab066940b45f34880991ea7ccbfb ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 8a63b1994c50 ("crypto: ux500 - Add driver for HASH hardware") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Reviewed-by: Linus Walleij Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/ux500/hash/hash_core.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c index 17c8e2b28c42..7500ec9efa6a 100644 --- a/drivers/crypto/ux500/hash/hash_core.c +++ b/drivers/crypto/ux500/hash/hash_core.c @@ -1006,6 +1006,7 @@ static int hash_hw_final(struct ahash_request *req) goto out; } } else if (req->nbytes == 0 && ctx->keylen > 0) { + ret = -EPERM; dev_err(device_data->dev, "%s: Empty message with keylength > 0, NOT supported\n", __func__); goto out;