From patchwork Mon Jul 19 14:49:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 479890 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp4225252jao; Mon, 19 Jul 2021 08:21:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd9HhsxOwcUnDCv1kTRQfeEnaOgG8OwfbfPdw3iZNO6dcPloXF7G6yW+byVcjK4vfybm3j X-Received: by 2002:a17:907:2d23:: with SMTP id gs35mr27423791ejc.222.1626708076021; Mon, 19 Jul 2021 08:21:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626708076; cv=none; d=google.com; s=arc-20160816; b=wACKVXGE391K/Z7aPu6NO9/PxWRoDA/tVmSRZhZ9xvrx6QaWqWvE/o/+cER+AGd5Xw Qv9d9kthRF+ka1xdkhrmdp1L/BuOSbML0oqukYcTezTwD6JZr48LA4XjoW3nRW75Biee 4xpfoVb5GX/BLSyGMwjwupsGaq2+FwV+4t5ZYp1lRouEbQIp2GKifLzLWvyaL9P7eeu4 vxKcgvbSCwElJo4vbjYGJEAoAvQ5wEmTqTEnREUI3IA9rYggKIJOmXUbDje8Vf1yY+lo bHxP8TqFFr3vZ8zSdiZiRCz7bsDVi23l79RA6I+zdbrxmRkj5GtaysJXZtlx5O/gf1yv 1QKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=z6ZBmt3D3Z0OWoXONxhSgFFodaSbyhmCo4EfBWi/Cu0=; b=jk75xLxM86KHASHb7WZ6h/hafWOsRzLmJxiOnNFUZmV3u2KGH1fbIa6qvrBL+hkQpd mXzVhYPjaWQ71T7CcW6cUT+LFEKBQ9Pb8XEIFMG9Qk+AB+S9GSCmMbm+8VG/IGTvQLRV Wx5syM524M28w1DO3m3JeGCLtT4ff0DGL8Ec88tA9cpyKBXAaOB8pjgxOoSgPTsFE7rR KIVQEbAPATwKKBiC7Umd1VHBC36IyclSj59XffxPybYDH+GK8s0eZALzC5bn0T29dway Q9OS9ahqD519vWC/yFPtQs1+SjLMhs5LJwVGfUoUaXD/RDxgr7KY4POb6RlvXGe4HqVW vPwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aaYd6RBn; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si24719878ejo.634.2021.07.19.08.21.15; Mon, 19 Jul 2021 08:21:16 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aaYd6RBn; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243730AbhGSOkU (ORCPT + 12 others); Mon, 19 Jul 2021 10:40:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:57588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244661AbhGSOhv (ORCPT ); Mon, 19 Jul 2021 10:37:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 412A2610D2; Mon, 19 Jul 2021 15:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626707856; bh=iT+OCu+mLudaldS5mJURFj9y6qPcvVsGNcC2Qd4aLZY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aaYd6RBnw3+YSwHghXxdvyRuKIlVEbzPJCcg5MajRE3kWCXKpkCScj8k9PovuV9V3 WpEjB20/n1uWZADNrTTPd+egkktgprlWDIqu/wlfsrVFLA+kjJuMkNsr7eU0l3Rnsj xuHrH8K5d94kWb3OM0trzeJgvdZsDb6GlDoVHA1o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 085/315] media: tc358743: Fix error return code in tc358743_probe_of() Date: Mon, 19 Jul 2021 16:49:34 +0200 Message-Id: <20210719144945.672421354@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144942.861561397@linuxfoundation.org> References: <20210719144942.861561397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit a6b1e7093f0a099571fc8836ab4a589633f956a8 ] When the CSI bps per lane is not in the valid range, an appropriate error code -EINVAL should be returned. However, we currently do not explicitly assign this error code to 'ret'. As a result, 0 was incorrectly returned. Fixes: 256148246852 ("[media] tc358743: support probe from device tree") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/tc358743.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index f74c4f6814eb..b294433c8345 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1806,6 +1806,7 @@ static int tc358743_probe_of(struct tc358743_state *state) bps_pr_lane = 2 * endpoint->link_frequencies[0]; if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) { dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane); + ret = -EINVAL; goto disable_clk; }