From patchwork Mon Jul 19 14:49:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 479891 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp4225321jao; Mon, 19 Jul 2021 08:21:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy16qIka19jF9o6p+upiJsoADrZydOgHyx1zEZTT/tJbEit59C5NnsmuYFPrn0kC9M5Rm64 X-Received: by 2002:aa7:dd8d:: with SMTP id g13mr35105502edv.336.1626708079224; Mon, 19 Jul 2021 08:21:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626708079; cv=none; d=google.com; s=arc-20160816; b=XBHvslm9uDfkQdM29tcD1i7gQdVNNSPYe4AahibL7OFOvmHjNlP6+WIBOkcMiw50OE ksBtW3rcNfhE3r6RvaV3kls62EArQFd8Zo149jkN/32QyyQyNH9rpHxQZQenRmuPXJ9Y zgvLS3LbGH0i0HHxrKBry2G0+74jkZD8VIFGhyOStV49kXx+L+0cA6JuIkVBB1bLVyU4 wH52S2KTTdJCDabX94Q+3hCuldhXaopItNrB7/pLPlyUzFA6p1QOLbZiJ5tD1vdL6pgf /9W4N8retZn4LK1E8GmVndbCpsZjUClVTPWur72A0WFCHZTSS6gc0/heOuaS2lUbUo/P r+oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=V99axwrfrX/UzPpWCSEVuuf59bG2hvGfMzxI8A465fI=; b=z9cni17n9kVYc88S31fen3WdkpgeqNIb+j14FthJirV9RBR0twosZkczwCFFD1Cf1l IIMwPw2omJQsR9fh1o8tIfPKmUc9iPJKaU8J6Tbyu/4AftLXfT5FdP2919yvC+tgd6DS swCgZHpVnCC58kG6an737a54lqCGiM2sPuMLw6rMEX8BuJMnkoesy/kjhMN0mqeOF59O RIKDk65WN4gl+RJegJxXkK5tWy8I73SkUet8kB6Ed8CC8gV9S+clWE9P6Ou4TngN/Bne hVXitjI9DX1HHBJhman9DvSHpNB9uEsg01x/1FHXyt+uegftjc/mKPuO1bC/DNqPaAyC bOMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=L2Ux0Jms; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si24719878ejo.634.2021.07.19.08.21.19; Mon, 19 Jul 2021 08:21:19 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=L2Ux0Jms; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244046AbhGSOkW (ORCPT + 12 others); Mon, 19 Jul 2021 10:40:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:54952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245152AbhGSOhz (ORCPT ); Mon, 19 Jul 2021 10:37:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 857D061244; Mon, 19 Jul 2021 15:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626707862; bh=bJArV5wIlLilLfD7Ao1kwSLhVegh20igN+ZquuapfVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L2Ux0Jms0+n9D3/+3+Uksli+HZAoTSE8vPlTSWQEOhFqRGAvQA5Ofu1v98nF1i1I0 6okV7LLR6qX4AUzK/0IP8WH2a47TT+HHnnYIeWe13xtZSFKWNcKAN5TGns/J7jef8R te76u+dAi7tELZ16KQKEE9TtXZ6eyBhXhYcYoONM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Ulf Hansson , Sasha Levin Subject: [PATCH 4.14 087/315] mmc: usdhi6rol0: fix error return code in usdhi6_probe() Date: Mon, 19 Jul 2021 16:49:36 +0200 Message-Id: <20210719144945.736201743@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144942.861561397@linuxfoundation.org> References: <20210719144942.861561397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit 2f9ae69e5267f53e89e296fccee291975a85f0eb ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Link: https://lore.kernel.org/r/20210508020321.1677-1-thunder.leizhen@huawei.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/usdhi6rol0.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c index 76e31a30b0cf..d27ee9eb2eac 100644 --- a/drivers/mmc/host/usdhi6rol0.c +++ b/drivers/mmc/host/usdhi6rol0.c @@ -1809,6 +1809,7 @@ static int usdhi6_probe(struct platform_device *pdev) version = usdhi6_read(host, USDHI6_VERSION); if ((version & 0xfff) != 0xa0d) { + ret = -EPERM; dev_err(dev, "Version not recognized %x\n", version); goto e_clk_off; }