Hi! > Fix the compatible to make the driver probe and tell the > driver where to look for the "xo" clock to make sure everything > works. > > Then we get a happy (eh, happier) 8996: > > somainline-sdcard:/home/konrad# cat /sys/kernel/debug/clk/pwrcl_pll/clk_rate > 1152000000 > > Don't backport without "arm64: dts: qcom: msm8996: Add CPU opps", as > the system fails to boot without consumers for these clocks. Changelog says this has dependency on b502efda6480d7577f9f822fd450d6bc3a4ac2e6. But that one is not in 5.10 AFAICT. Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
On Fri, Jul 23, 2021 at 10:07:32PM +0200, Pavel Machek wrote: >Hi! >> Fix the compatible to make the driver probe and tell the >> driver where to look for the "xo" clock to make sure everything >> works. >> >> Then we get a happy (eh, happier) 8996: >> >> somainline-sdcard:/home/konrad# cat /sys/kernel/debug/clk/pwrcl_pll/clk_rate >> 1152000000 >> >> Don't backport without "arm64: dts: qcom: msm8996: Add CPU opps", as >> the system fails to boot without consumers for these clocks. > >Changelog says this has dependency on >b502efda6480d7577f9f822fd450d6bc3a4ac2e6. > >But that one is not in 5.10 AFAICT. I'll drop it from everywhere, thanks! -- Thanks, Sasha
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index fd6ae5464dea..b774d5457328 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -1741,9 +1741,14 @@ }; }; }; + kryocc: clock-controller@6400000 { - compatible = "qcom,apcc-msm8996"; + compatible = "qcom,msm8996-apcc"; reg = <0x06400000 0x90000>; + + clock-names = "xo"; + clocks = <&xo_board>; + #clock-cells = <1>; };