diff mbox series

[5.13,101/104] i40e: Add additional info to PHY type error

Message ID	20210802134347.326654469@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Lukasz Cieplicki <lukaszx.cieplicki@intel.com>, Michal Maloszewski <michal.maloszewski@intel.com>, Tony Brelinski <tonyx.brelinski@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com> Subject: [PATCH 5.13 101/104] i40e: Add additional info to PHY type error Date: Mon, 2 Aug 2021 15:45:38 +0200 Message-Id: <20210802134347.326654469@linuxfoundation.org> In-Reply-To: <20210802134344.028226640@linuxfoundation.org> References: <20210802134344.028226640@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [5.13,003/104] btrfs: fix lost inode on log replay after mix of fsync, rename and inode eviction [5.13,005/104] btrfs: mark compressed range uptodate only if all bio succeed [5.13,006/104] Revert "ACPI: resources: Add checks for ACPI IRQ override" [5.13,011/104] ocfs2: issue zeroout to EOF blocks [5.13,012/104] mm: memcontrol: fix blocking rstat function called from atomic cgroup1 thresholdin... [5.13,015/104] can: raw: raw_setsockopt(): fix raw_rcv panic for sock UAF [5.13,016/104] can: peak_usb: pcan_usb_handle_bus_evt(): fix reading rxerr/txerr values [5.13,020/104] can: esd_usb2: fix memory leak [5.13,021/104] alpha: register early reserved memory in memblock [5.13,022/104] HID: wacom: Re-enable touch by default for Cintiq 24HDT / 27QHDT [5.13,024/104] NIU: fix incorrect error return, missed in previous revert [5.13,025/104] drm/amd/display: ensure dentist display clock update finished in DCN20 [5.13,026/104] drm/amdgpu: Check pmops for desired suspend state [5.13,028/104] drm/amdgpu: Fix resource leak on probe error path [5.13,031/104] io_uring: fix io_prep_async_link locking [5.13,033/104] io_uring: fix poll requests leaking second poll entries [5.13,037/104] platform/x86: amd-pmc: Fix SMU firmware reporting mechanism [5.13,039/104] RDMA/rxe: Fix memory leak in error path code [5.13,040/104] netfilter: nf_tables: fix audit memory leak in nf_tables_commit [5.13,041/104] bpf: Fix OOB read when printing XDP link fdinfo [5.13,044/104] netfilter: nft_nat: allow to specify layer 4 protocol NAT only [5.13,045/104] i40e: Fix logic of disabling queues [5.13,047/104] i40e: Fix queue-to-TC mapping on Tx [5.13,048/104] i40e: Fix log TC creation failure when max num of queues is exceeded [5.13,050/104] tipc: fix sleeping in tipc accept routine [5.13,053/104] loop: reintroduce global lock for safe loop_validate_file() traversal [5.13,054/104] net: qrtr: fix memory leaks [5.13,057/104] ionic: remove intr coalesce update from napi [5.13,058/104] ionic: fix up dim accounting for tx and rx [5.13,060/104] can: mcp251xfd: mcp251xfd_irq(): stop timestamping worker in case error in IRQ [5.13,061/104] tipc: do not write skb_shinfo frags when doing decrytion [5.13,062/104] octeontx2-pf: Fix interface down flag on error [5.13,065/104] mlx4: Fix missing error code in mlx4_load_one() [5.13,067/104] drm/i915/bios: Fix ports mask [5.13,068/104] KVM: x86: Check the right feature bit for MSR_KVM_ASYNC_PF_ACK access [5.13,070/104] drm/msm/dpu: Fix sm8250_mdp register length [5.13,072/104] drm/msm/dp: Initialize the INTF_CONFIG register [5.13,074/104] bpf, sockmap: Zap ingress queues after stopping strparser [5.13,076/104] net/mlx5e: Disable Rx ntuple offload for uplink representor [5.13,079/104] net/mlx5e: RX, Avoid possible data corruption when relaxed ordering and LRO combined [5.13,080/104] net/mlx5e: Add NETIF_F_HW_TC to hw_features when HTB offload is available [5.13,084/104] net/mlx5e: Fix nullptr in mlx5e_hairpin_get_mdev() [5.13,088/104] tulip: windbond-840: Fix missing pci_disable_device() in probe and remove [5.13,090/104] can: hi311x: fix a signedness bug in hi3110_cmd() [5.13,091/104] bpf: Introduce BPF nospec instruction for mitigating Spectre v4 [5.13,093/104] bpf: Remove superfluous aux sanitation on subprog rejection [5.13,094/104] bpf: verifier: Allocate idmap scratch in verifier env [5.13,096/104] SMB3: fix readpage for large swap cache [5.13,098/104] powerpc/pseries: Fix regression while building external modules [5.13,099/104] Revert "perf map: Fix dso->nsinfo refcounting" [5.13,101/104] i40e: Add additional info to PHY type error [5.13,103/104] perf pmu: Fix alias matching [5.13,104/104] octeontx2-af: Remove unnecessary devm_kfree

Commit Message

Greg Kroah-Hartman Aug. 2, 2021, 1:45 p.m. UTC

From: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>

commit dc614c46178b0b89bde86ac54fc687a28580d2b7 upstream.

In case of PHY type error occurs, the message was too generic.
Add additional info to PHY type error indicating that it can be
wrong cable connected.

Fixes: 124ed15bf126 ("i40e: Add dual speed module support")
Signed-off-by: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
Signed-off-by: Michal Maloszewski <michal.maloszewski@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -980,7 +980,7 @@  static void i40e_get_settings_link_up(st
 	default:
 		/* if we got here and link is up something bad is afoot */
 		netdev_info(netdev,
-			    "WARNING: Link is up but PHY type 0x%x is not recognized.\n",
+			    "WARNING: Link is up but PHY type 0x%x is not recognized, or incorrect cable is in use\n",
 			    hw_link_info->phy_type);
 	}