From patchwork Thu Sep 16 16:00:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 513022 Delivered-To: patch@linaro.org Received: by 2002:a02:c816:0:0:0:0:0 with SMTP id p22csp1425090jao; Thu, 16 Sep 2021 10:21:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwETLdSjM8INlAjRcMkrudn1YUgSRNNKbwB+jhSrvZqqXJfeEaJ+hCsxA2R3KQZlQ2R24JI X-Received: by 2002:a92:3642:: with SMTP id d2mr4799110ilf.234.1631812874057; Thu, 16 Sep 2021 10:21:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631812874; cv=none; d=google.com; s=arc-20160816; b=MglnmnjakodHGCuy0fJir7aW3iC6uKzGYx6DRp0Ut7sH6QJuhFPzq0NZkEu4o1TFDy ohs3/HVawnKi9x+yPljP4DZbJzKxynZfqQWbIrbwvXEXXNresEFfxpQTLopeY0Dh+tBf EwHeVenLXCcoDDPDGcdeztWGlGQGqsxIfJgVOHWpflZT+jeoXouQmix8kak4/bv30XHV 3Fu43lwMOtqmdcdY2Wry6kG4k0NgKLpjAXrz2zYXZfGlphg0dATCfERJ8NWn0ucab/sd Pk8hg3iwkV17p0k5Yag+U4XTaPEKSXZU7pcRizWMVHWiaDSdQCEP9Do6q4uAsi/m+Ju3 cpRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RHaLnAGBfpOveec361pOc5qsR/ANAm1l8bbxGKroKmI=; b=CuAyV7bxr8inE2q7FM3OZLT+c/gZHMQs9Ulg1C3m+/sLWodoOuB6ZtRLiVo+wm8Gb2 sA/maRzmHrSQSaEy/VS+5D++h92Bw3/JiChlTaJVQy95mv2AfZFIAKWwi4Zibi/jL4Jv yw0BccSxGtmtSTTfW+DBAUuOIyI62N3uqEfqTXpDg2gOA5fMo9gi+Vdy0YH35XWjMf66 xTPby6oq03DQqHg3oURN4t8I+wVK1sDCPl5ePk5/SJAsemfb/mwHxFI31LlRPfREVk5h ttJ39ewP/W9lNBap27Grty4k6Y67YLTOYCf4x7niBWYh/CO9zjCs1gLGxfFDbAX9WyIZ t2Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V0tq3WLd; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k15si1932359ilo.140.2021.09.16.10.21.13; Thu, 16 Sep 2021 10:21:14 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V0tq3WLd; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350246AbhIPRWb (ORCPT + 11 others); Thu, 16 Sep 2021 13:22:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:54400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243555AbhIPQzp (ORCPT ); Thu, 16 Sep 2021 12:55:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 50AF86135A; Thu, 16 Sep 2021 16:30:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631809834; bh=n5trVym9rA9eKT958C+3eitE2IdRM6j8B2EA8KcOOJs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V0tq3WLd5y2WtYGcN56sKQvzwMgke1vCr2kuT1szWAFelAM7RKaH4dwUnGMYhsJFm zH8mP2Mgz5jBxJ607/q9DhyGmr7y54Uud1j+XRYlsjI7vrZip1ftJUAGzbPxeR6rdM 9GhCBK/9cPMUNuIXrGaZOrcwsy0LrQf+Z81bXhOs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Greg Ungerer , Sasha Levin Subject: [PATCH 5.13 300/380] m68knommu: only set CONFIG_ISA_DMA_API for ColdFire sub-arch Date: Thu, 16 Sep 2021 18:00:57 +0200 Message-Id: <20210916155814.266788937@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155803.966362085@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit db87db65c1059f3be04506d122f8ec9b2fa3b05e ] > Hi Arnd, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 2f73937c9aa561e2082839bc1a8efaac75d6e244 > commit: 47fd22f2b84765a2f7e3f150282497b902624547 [4771/5318] cs89x0: rework driver configuration > config: m68k-randconfig-c003-20210804 (attached as .config) > compiler: m68k-linux-gcc (GCC) 10.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=47fd22f2b84765a2f7e3f150282497b902624547 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 47fd22f2b84765a2f7e3f150282497b902624547 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from include/linux/kernel.h:19, > from include/linux/list.h:9, > from include/linux/module.h:12, > from drivers/net/ethernet/cirrus/cs89x0.c:51: > drivers/net/ethernet/cirrus/cs89x0.c: In function 'net_open': > drivers/net/ethernet/cirrus/cs89x0.c:897:20: error: implicit declaration of function 'isa_virt_to_bus'; did you mean 'virt_to_bus'? [-Werror=implicit-function-declaration] > 897 | (unsigned long)isa_virt_to_bus(lp->dma_buff)); > | ^~~~~~~~~~~~~~~ > include/linux/printk.h:141:17: note: in definition of macro 'no_printk' > 141 | printk(fmt, ##__VA_ARGS__); \ > | ^~~~~~~~~~~ > drivers/net/ethernet/cirrus/cs89x0.c:86:3: note: in expansion of macro 'pr_debug' > 86 | pr_##level(fmt, ##__VA_ARGS__); \ > | ^~~ > drivers/net/ethernet/cirrus/cs89x0.c:894:3: note: in expansion of macro 'cs89_dbg' > 894 | cs89_dbg(1, debug, "%s: dma %lx %lx\n", > | ^~~~~~~~ > >> drivers/net/ethernet/cirrus/cs89x0.c:914:3: error: implicit declaration of function 'disable_dma'; did you mean 'disable_irq'? [-Werror=implicit-function-declaration] As far as I can tell, this is a bug with the m68kmmu architecture, not with my driver: The CONFIG_ISA_DMA_API option is provided for coldfire, which implements it, but dragonball also sets the option as a side-effect, without actually implementing the interfaces. The patch below should fix it. Signed-off-by: Arnd Bergmann Signed-off-by: Greg Ungerer Signed-off-by: Sasha Levin --- arch/m68k/Kconfig.bus | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 diff --git a/arch/m68k/Kconfig.bus b/arch/m68k/Kconfig.bus index f1be832e2b74..d1e93a39cd3b 100644 --- a/arch/m68k/Kconfig.bus +++ b/arch/m68k/Kconfig.bus @@ -63,7 +63,7 @@ source "drivers/zorro/Kconfig" endif -if !MMU +if COLDFIRE config ISA_DMA_API def_bool !M5272