From patchwork Mon Sep 20 16:44:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 514375 Delivered-To: patch@linaro.org Received: by 2002:a02:c816:0:0:0:0:0 with SMTP id p22csp2338011jao; Mon, 20 Sep 2021 11:47:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/MiUOgtmNe9dcLidvBHZgYA0+YTRx6BdqFMU3wDP40tkhMRNLHVZehSuud5wtU1IApYt9 X-Received: by 2002:a05:6402:143b:: with SMTP id c27mr15057195edx.224.1632163626946; Mon, 20 Sep 2021 11:47:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632163626; cv=none; d=google.com; s=arc-20160816; b=RrJOUYEuAbYK8iUISbzgiN+jiiHkSIatSW0YTu9UGGseFFhMwI9j52fia+e9MNtB1K CVQS6a9pTT/j7Q2ObMnGv1hun0rJcAzn9OZ70X7ihWH7O1Bpn3BT2blb6gppoy0IKwvB QDdjM/8bft6IWSL/Ilu0deVm6Qt2lq+uBjIMi9QQoyPrhYF2lbXjaEwIYeBFGziOdfJe cLIqfJzTAm6RuTqhzsTVqouGAGg8yPyEjatuK1OzWH5WMN9VPZKDQWOokFpft25X5CT5 0wJYLhOiuNJ/XUbEJgaKTPSiw/4hwaQA1e0tLFKO6AgPxA3JDTX13y6itFYF8kI30lHm EgVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HKL3F1oDwhJmHD95lXpuFSYWItAq26hF2I7NfcMbDkI=; b=uNspLHaHl/OZcOLN3WXj2AL0C739HrGzOVBlF/H6sKsmjOo2L40cMQbbpASXd6260t JEyKn/tggUKK9we08mvRgD1KuzE222ihYhQY2avoFZ8Zq0EGHod34Zclt9P28/82Vsvm Z3OBht6vEdNSJ0qMFdxJHQ5Pkok/g/EDKhs3Zf9+0DCLtPQ202SUSvm93UCGIK6XbeB5 TUOduGJQ657S/brFdnNpigLNbcn2UYlTC4fvvfiJ6nUShT2pTc94k5Z0WYziuCpuKkot lbqOuvwZUgcFhgpfdhIXXUZE1DpFaJUwCoc/TGMyFXrDD+1V0QC3yLPHVi6/Du+xu3qY HEqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=utNnSxlL; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y20si14446786edc.166.2021.09.20.11.47.06; Mon, 20 Sep 2021 11:47:06 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=utNnSxlL; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384637AbhITSsc (ORCPT + 11 others); Mon, 20 Sep 2021 14:48:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:33380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384049AbhITSq3 (ORCPT ); Mon, 20 Sep 2021 14:46:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A63EB61B00; Mon, 20 Sep 2021 17:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632159205; bh=J++Xue/OUKFhVvOxY3tDh0wvNGzwBHc61OJQ/vIxcDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=utNnSxlLUDbghXRzPou4ztxtm+xSqsWAY8eKYbbQHXNixkopNHdDxL5mpSXwXpxHn hLCKAF4vLW8iCFm1R2ckzuvl3S6+kRml4sERBYmDKWAgPoyJ3VHN4VUmxGRRLnp02L cSq66nF03uw+72mqNYoj1viXngxGb0r6ZGziAWNo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , Lorenzo Pieralisi , Bjorn Helgaas , Srinath Mannam , Roman Bacik , Bharat Gooty , Abhishek Shah , Jitendra Bhivare , Ray Jui , Florian Fainelli , BCM Kernel Feedback , Scott Branden , Sasha Levin Subject: [PATCH 5.14 124/168] PCI: of: Dont fail devm_pci_alloc_host_bridge() on missing ranges Date: Mon, 20 Sep 2021 18:44:22 +0200 Message-Id: <20210920163925.737206408@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210920163921.633181900@linuxfoundation.org> References: <20210920163921.633181900@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Rob Herring [ Upstream commit d277f6e88c88729b1d57d40bbfb00d0bfc961972 ] Commit 669cbc708122 ("PCI: Move DT resource setup into devm_pci_alloc_host_bridge()") made devm_pci_alloc_host_bridge() fail on any DT resource parsing errors, but Broadcom iProc uses devm_pci_alloc_host_bridge() on BCMA bus devices that don't have DT resources. In particular, there is no 'ranges' property. Fix iProc by making 'ranges' optional. If 'ranges' is required by a platform, there's going to be more errors latter on if it is missing. Link: https://lore.kernel.org/r/20210803215656.3803204-1-robh@kernel.org Fixes: 669cbc708122 ("PCI: Move DT resource setup into devm_pci_alloc_host_bridge()") Reported-by: Rafał Miłecki Tested-by: Rafał Miłecki Signed-off-by: Rob Herring Signed-off-by: Lorenzo Pieralisi Acked-by: Bjorn Helgaas Cc: Srinath Mannam Cc: Roman Bacik Cc: Bharat Gooty Cc: Abhishek Shah Cc: Jitendra Bhivare Cc: Ray Jui Cc: Florian Fainelli Cc: BCM Kernel Feedback Cc: Scott Branden Cc: Bjorn Helgaas Cc: Lorenzo Pieralisi Signed-off-by: Sasha Levin --- drivers/pci/of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/pci/of.c b/drivers/pci/of.c index a143b02b2dcd..d84381ce82b5 100644 --- a/drivers/pci/of.c +++ b/drivers/pci/of.c @@ -310,7 +310,7 @@ static int devm_of_pci_get_host_bridge_resources(struct device *dev, /* Check for ranges property */ err = of_pci_range_parser_init(&parser, dev_node); if (err) - goto failed; + return 0; dev_dbg(dev, "Parsing ranges property...\n"); for_each_of_pci_range(&parser, &range) {