From patchwork Fri Dec 10 23:50:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Biggers X-Patchwork-Id: 523055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50BFCC4332F for ; Fri, 10 Dec 2021 23:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345240AbhLJXz3 (ORCPT ); Fri, 10 Dec 2021 18:55:29 -0500 Received: from sin.source.kernel.org ([145.40.73.55]:49264 "EHLO sin.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243873AbhLJXzX (ORCPT ); Fri, 10 Dec 2021 18:55:23 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 73F93CE2DB3; Fri, 10 Dec 2021 23:51:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AA34C341CB; Fri, 10 Dec 2021 23:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639180304; bh=5/+k4tp0vJzi77gqOdpvNYg+I1vduCjzDK3HKrPDBEY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ahlxjv9aX53gi1Ba+61CKmgTTZMmN7Cn6F9C9LcX6r/6l6tSNaCQPtKO2EvlFmRvg 1VD+kWw6Axz8d1nK7DaKIfX2ECf16v5lou6c8B3TCavQWGqWHz3O2nY+5uIBddRXDa DLqz4EtScAefbkBAkDOKeupJtLg3mejRdRYHzIzVeZPCya3bCoKvqxAi7t04elejQB NXTtnMAu+gyhjtfrTMbVvl0R2tVOA1wvcm3KZTxVGTYNpJYmV1UUIFV+JYbVCBhhks Nx6AIqbHEvH5icvxGwBItrqlUKpnAU9ThQ2L9G+liF8lXk+NPeT2WFNjrpOh/g/bqy OKKJVlqCjZuqQ== From: Eric Biggers To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Linus Torvalds Subject: [PATCH 5.4 3/5] signalfd: use wake_up_pollfree() Date: Fri, 10 Dec 2021 15:50:52 -0800 Message-Id: <20211210235054.40103-4-ebiggers@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211210235054.40103-1-ebiggers@kernel.org> References: <20211210235054.40103-1-ebiggers@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Eric Biggers commit 9537bae0da1f8d1e2361ab6d0479e8af7824e160 upstream. wake_up_poll() uses nr_exclusive=1, so it's not guaranteed to wake up all exclusive waiters. Yet, POLLFREE *must* wake up all waiters. epoll and aio poll are fortunately not affected by this, but it's very fragile. Thus, the new function wake_up_pollfree() has been introduced. Convert signalfd to use wake_up_pollfree(). Reported-by: Linus Torvalds Fixes: d80e731ecab4 ("epoll: introduce POLLFREE to flush ->signalfd_wqh before kfree()") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20211209010455.42744-4-ebiggers@kernel.org Signed-off-by: Eric Biggers --- fs/signalfd.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/fs/signalfd.c b/fs/signalfd.c index 5b78719be4455..3e94d181930fd 100644 --- a/fs/signalfd.c +++ b/fs/signalfd.c @@ -35,17 +35,7 @@ void signalfd_cleanup(struct sighand_struct *sighand) { - wait_queue_head_t *wqh = &sighand->signalfd_wqh; - /* - * The lockless check can race with remove_wait_queue() in progress, - * but in this case its caller should run under rcu_read_lock() and - * sighand_cachep is SLAB_TYPESAFE_BY_RCU, we can safely return. - */ - if (likely(!waitqueue_active(wqh))) - return; - - /* wait_queue_entry_t->func(POLLFREE) should do remove_wait_queue() */ - wake_up_poll(wqh, EPOLLHUP | POLLFREE); + wake_up_pollfree(&sighand->signalfd_wqh); } struct signalfd_ctx {