From patchwork Thu Apr 28 23:26:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Kolchmeyer X-Patchwork-Id: 567755 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F1B8C433F5 for ; Thu, 28 Apr 2022 23:26:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353268AbiD1X3n (ORCPT ); Thu, 28 Apr 2022 19:29:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234016AbiD1X3m (ORCPT ); Thu, 28 Apr 2022 19:29:42 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AF21BCB4D for ; Thu, 28 Apr 2022 16:26:26 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-2f84aeb403fso53636207b3.22 for ; Thu, 28 Apr 2022 16:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=yHn7VkdEiG7nyywZ806Ja4HL84YfXUIIFhfk9KGhrTg=; b=ps3Ij1OJIhQkiIlDn8MMrreqhgfWZuebOZIGsLjaaMt5qLuC40TMsuY6t2TuX0xmcF AWl2ySDmNOu9xJlN3821JrFLszkbOqL5Sxm16cOaWUOtkx10NW39PuKDptfzT48uVck2 v/h075o0PU/kfZq9APW2Eck9p6qoihKUiFkI3MsTYOcMfXxlP90T6V6cvWZjecjQY7eD shnMEse2vl+oF9Uekmev6hj/5EVOWsxfvNtrQXPyz8bhOXpDB3KlFq2T9PFrWMrCqlMy uMg7tqw5FgJyZUE8yn65JAzG4HzzME9xnuQ8aNWBXfvR2xm97HZq/q3cwuCtncESocbV wJ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=yHn7VkdEiG7nyywZ806Ja4HL84YfXUIIFhfk9KGhrTg=; b=5nMj8W4akg7mNc/tabBQUwYWG0OHlNHtEdfHdx/VnbJs1SmkqgxZbhTi9kcLI89OCD uusu997U6DN1Wgm98yZpvTVEjnRbfXHvUzh7Ay9LbOCxb4HyYX6UnR1fxyjqutDGj383 VQYS/7j5AAeNhviM1mwGkUPK9zxTLyFoJBgP/w8W/T4QGhbtvgdm5H6syU9l25qWQTJP JD1e1gdbYU47ghsNE6yqeze3eEuK7wZNlKE4RCpebP9BucqEQPxme8z8w2USoo6ayKxx 1Y9gsKFwo8R4YHmobzRvKJEPoAqdO/nbS/DNoym5nrlSzop2c46ljphB8SbxCj3lQP+X pw+Q== X-Gm-Message-State: AOAM532hW9qsJxsCOldCOTy4f5C8hh8HRS1ZwdiPMn/DI8ywHJeyVHdL Ufe8QihhoXA8NWMmBhi2xVseTeSajiBJWjA0YaaFGZVPUhaR8e5lfeyicGPMvYt9IO/4mViawvv GucrFZuceb/XiMCVyfGwru07RChX9ZKcSfQUShkI86n1bQZqAImoN9r5SC7StAq8AY94WQZ4TbQ == X-Google-Smtp-Source: ABdhPJzICw5s5xX5nvMp067u4XsheGuC9g+pMneAKc0AtHUI3u5koq19XQFT2DFA/l6vZMqFfnuAuK6FFz7Nsqk3OA== X-Received: from rkolchmeyer.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:7f04]) (user=rkolchmeyer job=sendgmr) by 2002:a05:6902:1381:b0:633:3683:78da with SMTP id x1-20020a056902138100b00633368378damr32297508ybu.275.1651188385456; Thu, 28 Apr 2022 16:26:25 -0700 (PDT) Date: Thu, 28 Apr 2022 16:26:05 -0700 Message-Id: <20220428232605.1231397-1-rkolchmeyer@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.36.0.464.gb9c8b46e94-goog Subject: [PATCH 4.14] net/sched: cls_u32: fix netns refcount changes in u32_change() From: Robert Kolchmeyer To: stable@vger.kernel.org Cc: gregkh@linuxfoundation.org, edumazet@google.com, rkolchmeyer@google.com, syzbot , Cong Wang , Jiri Pirko , Jamal Hadi Salim , Jakub Kicinski Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Eric Dumazet commit 3db09e762dc79584a69c10d74a6b98f89a9979f8 upstream. We are now able to detect extra put_net() at the moment they happen, instead of much later in correct code paths. u32_init_knode() / tcf_exts_init() populates the ->exts.net pointer, but as mentioned in tcf_exts_init(), the refcount on netns has not been elevated yet. The refcount is taken only once tcf_exts_get_net() is called. So the two u32_destroy_key() calls from u32_change() are attempting to release an invalid reference on the netns. syzbot report: refcount_t: decrement hit 0; leaking memory. WARNING: CPU: 0 PID: 21708 at lib/refcount.c:31 refcount_warn_saturate+0xbf/0x1e0 lib/refcount.c:31 Modules linked in: CPU: 0 PID: 21708 Comm: syz-executor.5 Not tainted 5.18.0-rc2-next-20220412-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:refcount_warn_saturate+0xbf/0x1e0 lib/refcount.c:31 Code: 1d 14 b6 b2 09 31 ff 89 de e8 6d e9 89 fd 84 db 75 e0 e8 84 e5 89 fd 48 c7 c7 40 aa 26 8a c6 05 f4 b5 b2 09 01 e8 e5 81 2e 05 <0f> 0b eb c4 e8 68 e5 89 fd 0f b6 1d e3 b5 b2 09 31 ff 89 de e8 38 RSP: 0018:ffffc900051af1b0 EFLAGS: 00010286 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: 0000000000040000 RSI: ffffffff8160a0c8 RDI: fffff52000a35e28 RBP: 0000000000000004 R08: 0000000000000000 R09: 0000000000000000 R10: ffffffff81604a9e R11: 0000000000000000 R12: 1ffff92000a35e3b R13: 00000000ffffffef R14: ffff8880211a0194 R15: ffff8880577d0a00 FS: 00007f25d183e700(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f19c859c028 CR3: 0000000051009000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: __refcount_dec include/linux/refcount.h:344 [inline] refcount_dec include/linux/refcount.h:359 [inline] ref_tracker_free+0x535/0x6b0 lib/ref_tracker.c:118 netns_tracker_free include/net/net_namespace.h:327 [inline] put_net_track include/net/net_namespace.h:341 [inline] tcf_exts_put_net include/net/pkt_cls.h:255 [inline] u32_destroy_key.isra.0+0xa7/0x2b0 net/sched/cls_u32.c:394 u32_change+0xe01/0x3140 net/sched/cls_u32.c:909 tc_new_tfilter+0x98d/0x2200 net/sched/cls_api.c:2148 rtnetlink_rcv_msg+0x80d/0xb80 net/core/rtnetlink.c:6016 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2495 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline] netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345 netlink_sendmsg+0x904/0xe00 net/netlink/af_netlink.c:1921 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:725 ____sys_sendmsg+0x6e2/0x800 net/socket.c:2413 ___sys_sendmsg+0xf3/0x170 net/socket.c:2467 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2496 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7f25d0689049 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f25d183e168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00007f25d079c030 RCX: 00007f25d0689049 RDX: 0000000000000000 RSI: 0000000020000340 RDI: 0000000000000005 RBP: 00007f25d06e308d R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffd0b752e3f R14: 00007f25d183e300 R15: 0000000000022000 Fixes: 35c55fc156d8 ("cls_u32: use tcf_exts_get_net() before call_rcu()") Signed-off-by: Eric Dumazet Reported-by: syzbot Cc: Cong Wang Cc: Jiri Pirko Acked-by: Jamal Hadi Salim Signed-off-by: Jakub Kicinski [rkolchmeyer: Backported to 4.14: adjusted u32_destroy_key() signature] Signed-off-by: Robert Kolchmeyer --- u32_destroy_key() takes an additional argument (struct tcf_proto *tp) on 4.14, so I updated the patch to include this. But u32_destroy_key() doesn't actually use this argument, so the semantics of the patch aren't impacted by this change. The patch context here is slightly different from the 4.19 patch. net/sched/cls_u32.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 0c9bc29dcf97a..fdbdcba44917e 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -395,15 +395,20 @@ static int u32_init(struct tcf_proto *tp) return 0; } -static int u32_destroy_key(struct tcf_proto *tp, struct tc_u_knode *n, - bool free_pf) +static void __u32_destroy_key(struct tc_u_knode *n) { struct tc_u_hnode *ht = rtnl_dereference(n->ht_down); tcf_exts_destroy(&n->exts); - tcf_exts_put_net(&n->exts); if (ht && --ht->refcnt == 0) kfree(ht); + kfree(n); +} + +static void u32_destroy_key(struct tcf_proto *tp, struct tc_u_knode *n, + bool free_pf) +{ + tcf_exts_put_net(&n->exts); #ifdef CONFIG_CLS_U32_PERF if (free_pf) free_percpu(n->pf); @@ -412,8 +417,7 @@ static int u32_destroy_key(struct tcf_proto *tp, struct tc_u_knode *n, if (free_pf) free_percpu(n->pcpu_success); #endif - kfree(n); - return 0; + __u32_destroy_key(n); } /* u32_delete_key_rcu should be called when free'ing a copied @@ -942,13 +946,13 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, tca[TCA_RATE], ovr); if (err) { - u32_destroy_key(tp, new, false); + __u32_destroy_key(new); return err; } err = u32_replace_hw_knode(tp, new, flags); if (err) { - u32_destroy_key(tp, new, false); + __u32_destroy_key(new); return err; }