diff mbox series

[5.17,113/114] net: phy: micrel: Fix incorrect variable type in micrel

Message ID 20220516193628.717414239@linuxfoundation.org
State New
Headers show
Series None | expand

Commit Message

Greg Kroah-Hartman May 16, 2022, 7:37 p.m. UTC
From: Wan Jiabing <wanjiabing@vivo.com>

commit 12a4d677b1c34717443470c1492fe520638ef39a upstream.

In lanphy_read_page_reg, calling __phy_read() might return a negative
error code. Use 'int' to check the error code.

Fixes: 7c2dcfa295b1 ("net: phy: micrel: Add support for LAN8804 PHY")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220509144519.2343399-1-wanjiabing@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 drivers/net/phy/micrel.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1594,7 +1594,7 @@  static int ksz886x_cable_test_get_status
 static int lanphy_read_page_reg(struct phy_device *phydev, int page, u32 addr)
-	u32 data;
+	int data;
 	__phy_write(phydev, LAN_EXT_PAGE_ACCESS_CONTROL, page);