mbox series

[v1,00/15] add basic driver support for broadcom NS3 soc

Message ID 20200517081945.21282-1-rayagonda.kokatanur@broadcom.com
Headers show
Series add basic driver support for broadcom NS3 soc | expand

Message

Rayagonda Kokatanur May 17, 2020, 8:19 a.m. UTC
This is the second patch set series prepared on top of the
first patch set ("add initial support for broadcom NS3 soc").

This patch set will add following,
-dt nodes and defconfig options for basic device like pinctrl,
 gpio, mmc, qspi, wdt, i2c and pcie.
-start wdt service
-Enable GPT commands
-Enable EXT4 and FAT fs support

Pramod Kumar (2):
  arm: dts: ns3: add emmc node
  arm: dts: ns3: add sp805 watchdog node

Rayagonda Kokatanur (12):
  configs: ns3: enable pinctrl driver
  dt-bindings: pinctrl: add ns3 pads definition
  arm: dts: ns3: add pinctrl node
  arm: dts: ns3: add gpio node
  configs: ns3: enable BCM IPROC mmc driver
  configs: ns3: enable mmc commands
  arm: dts: ns3: add qspi node
  arm: dts: ns3: add i2c node
  configs: ns3: enable gpt commands
  configs: ns3: enable EXT4 and FAT fs support
  configs: ns3: enable sp805 watchdog driver
  board: ns3: start sp805 watchdog service

Srinath Mannam (1):
  arm: dts: ns3: add PAXB PCIe host and phy node

 arch/arm/dts/ns3-board.dts                    |  58 ++++
 arch/arm/dts/ns3-pinctrl.dtsi                 | 321 ++++++++++++++++++
 arch/arm/dts/ns3.dtsi                         | 224 ++++++++++++
 board/broadcom/bcmns3/ns3.c                   |  56 +++
 configs/bcm_ns3_defconfig                     |  19 ++
 .../dt-bindings/pinctrl/brcm,pinctrl-ns3.h    |  41 +++
 6 files changed, 719 insertions(+)
 create mode 100644 arch/arm/dts/ns3-pinctrl.dtsi
 create mode 100644 include/dt-bindings/pinctrl/brcm,pinctrl-ns3.h

Comments

Tom Rini May 18, 2020, 7:16 p.m. UTC | #1
On Sun, May 17, 2020 at 01:49:30PM +0530, Rayagonda Kokatanur wrote:

> This is the second patch set series prepared on top of the
> first patch set ("add initial support for broadcom NS3 soc").
> 
> This patch set will add following,
> -dt nodes and defconfig options for basic device like pinctrl,
>  gpio, mmc, qspi, wdt, i2c and pcie.
> -start wdt service
> -Enable GPT commands
> -Enable EXT4 and FAT fs support

All of the dts changes not in a -u-boot.dtsi file either come from
mainline Linux or at least linux-next and have had some level upstream
review, right?  Thanks!
Rayagonda Kokatanur May 19, 2020, 5:09 p.m. UTC | #2
Hi Tom,


On Tue, May 19, 2020 at 12:46 AM Tom Rini <trini at konsulko.com> wrote:
>
> On Sun, May 17, 2020 at 01:49:30PM +0530, Rayagonda Kokatanur wrote:
>
> > This is the second patch set series prepared on top of the
> > first patch set ("add initial support for broadcom NS3 soc").
> >
> > This patch set will add following,
> > -dt nodes and defconfig options for basic device like pinctrl,
> >  gpio, mmc, qspi, wdt, i2c and pcie.
> > -start wdt service
> > -Enable GPT commands
> > -Enable EXT4 and FAT fs support
>
> All of the dts changes not in a -u-boot.dtsi file either come from
> mainline Linux or at least linux-next and have had some level upstream
> review, right?  Thanks!

Yes. All the DTS changes are merged in the Linux and are available at
arch/arm64/boot/dts/broadcom/stingray/

Best regards,
Rayagonda

>
> --
> Tom
Tom Rini May 19, 2020, 5:31 p.m. UTC | #3
On Tue, May 19, 2020 at 10:39:49PM +0530, Rayagonda Kokatanur wrote:
> Hi Tom,
> 
> 
> On Tue, May 19, 2020 at 12:46 AM Tom Rini <trini at konsulko.com> wrote:
> >
> > On Sun, May 17, 2020 at 01:49:30PM +0530, Rayagonda Kokatanur wrote:
> >
> > > This is the second patch set series prepared on top of the
> > > first patch set ("add initial support for broadcom NS3 soc").
> > >
> > > This patch set will add following,
> > > -dt nodes and defconfig options for basic device like pinctrl,
> > >  gpio, mmc, qspi, wdt, i2c and pcie.
> > > -start wdt service
> > > -Enable GPT commands
> > > -Enable EXT4 and FAT fs support
> >
> > All of the dts changes not in a -u-boot.dtsi file either come from
> > mainline Linux or at least linux-next and have had some level upstream
> > review, right?  Thanks!
> 
> Yes. All the DTS changes are merged in the Linux and are available at
> arch/arm64/boot/dts/broadcom/stingray/

Great.  Please reference the release you're taking these from as that
will make future resyncs easier.  Thanks!
Rayagonda Kokatanur May 19, 2020, 5:45 p.m. UTC | #4
On Tue, May 19, 2020 at 11:01 PM Tom Rini <trini at konsulko.com> wrote:
>
> On Tue, May 19, 2020 at 10:39:49PM +0530, Rayagonda Kokatanur wrote:
> > Hi Tom,
> >
> >
> > On Tue, May 19, 2020 at 12:46 AM Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Sun, May 17, 2020 at 01:49:30PM +0530, Rayagonda Kokatanur wrote:
> > >
> > > > This is the second patch set series prepared on top of the
> > > > first patch set ("add initial support for broadcom NS3 soc").
> > > >
> > > > This patch set will add following,
> > > > -dt nodes and defconfig options for basic device like pinctrl,
> > > >  gpio, mmc, qspi, wdt, i2c and pcie.
> > > > -start wdt service
> > > > -Enable GPT commands
> > > > -Enable EXT4 and FAT fs support
> > >
> > > All of the dts changes not in a -u-boot.dtsi file either come from
> > > mainline Linux or at least linux-next and have had some level upstream
> > > review, right?  Thanks!
> >
> > Yes. All the DTS changes are merged in the Linux and are available at
> > arch/arm64/boot/dts/broadcom/stingray/
>
> Great.  Please reference the release you're taking these from as that
> will make future resyncs easier.  Thanks!

It's Linux v5.6.

Best regards,
Rayagonda

>
>
> --
> Tom
Thomas Fitzsimmons May 20, 2020, 2:04 a.m. UTC | #5
Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com> writes:

> On Tue, May 19, 2020 at 11:01 PM Tom Rini <trini at konsulko.com> wrote:
>>
>> On Tue, May 19, 2020 at 10:39:49PM +0530, Rayagonda Kokatanur wrote:
>> > Hi Tom,
>> >
>> >
>> > On Tue, May 19, 2020 at 12:46 AM Tom Rini <trini at konsulko.com> wrote:
>> > >
>> > > On Sun, May 17, 2020 at 01:49:30PM +0530, Rayagonda Kokatanur wrote:
>> > >
>> > > > This is the second patch set series prepared on top of the
>> > > > first patch set ("add initial support for broadcom NS3 soc").
>> > > >
>> > > > This patch set will add following,
>> > > > -dt nodes and defconfig options for basic device like pinctrl,
>> > > >  gpio, mmc, qspi, wdt, i2c and pcie.
>> > > > -start wdt service
>> > > > -Enable GPT commands
>> > > > -Enable EXT4 and FAT fs support
>> > >
>> > > All of the dts changes not in a -u-boot.dtsi file either come from
>> > > mainline Linux or at least linux-next and have had some level upstream
>> > > review, right?  Thanks!
>> >
>> > Yes. All the DTS changes are merged in the Linux and are available at
>> > arch/arm64/boot/dts/broadcom/stingray/
>>
>> Great.  Please reference the release you're taking these from as that
>> will make future resyncs easier.  Thanks!
>
> It's Linux v5.6.

What's the relationship between e.g., bcm958742t.dts and ns3.dts?  I
looked at the mainline Linux device trees and I couldn't easily see the
correspondence.  Will the renaming complicate synchronization?

Thomas
Rayagonda Kokatanur May 20, 2020, 5:19 a.m. UTC | #6
Hi Thomas,

On Wed, May 20, 2020 at 7:34 AM Thomas Fitzsimmons <fitzsim at fitzsim.org> wrote:
>
> Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com> writes:
>
> > On Tue, May 19, 2020 at 11:01 PM Tom Rini <trini at konsulko.com> wrote:
> >>
> >> On Tue, May 19, 2020 at 10:39:49PM +0530, Rayagonda Kokatanur wrote:
> >> > Hi Tom,
> >> >
> >> >
> >> > On Tue, May 19, 2020 at 12:46 AM Tom Rini <trini at konsulko.com> wrote:
> >> > >
> >> > > On Sun, May 17, 2020 at 01:49:30PM +0530, Rayagonda Kokatanur wrote:
> >> > >
> >> > > > This is the second patch set series prepared on top of the
> >> > > > first patch set ("add initial support for broadcom NS3 soc").
> >> > > >
> >> > > > This patch set will add following,
> >> > > > -dt nodes and defconfig options for basic device like pinctrl,
> >> > > >  gpio, mmc, qspi, wdt, i2c and pcie.
> >> > > > -start wdt service
> >> > > > -Enable GPT commands
> >> > > > -Enable EXT4 and FAT fs support
> >> > >
> >> > > All of the dts changes not in a -u-boot.dtsi file either come from
> >> > > mainline Linux or at least linux-next and have had some level upstream
> >> > > review, right?  Thanks!
> >> >
> >> > Yes. All the DTS changes are merged in the Linux and are available at
> >> > arch/arm64/boot/dts/broadcom/stingray/
> >>
> >> Great.  Please reference the release you're taking these from as that
> >> will make future resyncs easier.  Thanks!
> >
> > It's Linux v5.6.
>
> What's the relationship between e.g., bcm958742t.dts and ns3.dts?  I
> looked at the mainline Linux device trees and I couldn't easily see the
> correspondence.  Will the renaming complicate synchronization?

Do we need to maintain the same dt file between linux and uboot ?
Also in uboot we don't enable all devices,  how do we handle this ?
Please let me know.

Best regards,
Rayagonda

>
> Thomas
Simon Glass May 20, 2020, 2:20 p.m. UTC | #7
Hi Rayagonda,

On Tue, 19 May 2020 at 23:19, Rayagonda Kokatanur
<rayagonda.kokatanur at broadcom.com> wrote:
>
> Hi Thomas,
>
> On Wed, May 20, 2020 at 7:34 AM Thomas Fitzsimmons <fitzsim at fitzsim.org> wrote:
> >
> > Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com> writes:
> >
> > > On Tue, May 19, 2020 at 11:01 PM Tom Rini <trini at konsulko.com> wrote:
> > >>
> > >> On Tue, May 19, 2020 at 10:39:49PM +0530, Rayagonda Kokatanur wrote:
> > >> > Hi Tom,
> > >> >
> > >> >
> > >> > On Tue, May 19, 2020 at 12:46 AM Tom Rini <trini at konsulko.com> wrote:
> > >> > >
> > >> > > On Sun, May 17, 2020 at 01:49:30PM +0530, Rayagonda Kokatanur wrote:
> > >> > >
> > >> > > > This is the second patch set series prepared on top of the
> > >> > > > first patch set ("add initial support for broadcom NS3 soc").
> > >> > > >
> > >> > > > This patch set will add following,
> > >> > > > -dt nodes and defconfig options for basic device like pinctrl,
> > >> > > >  gpio, mmc, qspi, wdt, i2c and pcie.
> > >> > > > -start wdt service
> > >> > > > -Enable GPT commands
> > >> > > > -Enable EXT4 and FAT fs support
> > >> > >
> > >> > > All of the dts changes not in a -u-boot.dtsi file either come from
> > >> > > mainline Linux or at least linux-next and have had some level upstream
> > >> > > review, right?  Thanks!
> > >> >
> > >> > Yes. All the DTS changes are merged in the Linux and are available at
> > >> > arch/arm64/boot/dts/broadcom/stingray/
> > >>
> > >> Great.  Please reference the release you're taking these from as that
> > >> will make future resyncs easier.  Thanks!
> > >
> > > It's Linux v5.6.
> >
> > What's the relationship between e.g., bcm958742t.dts and ns3.dts?  I
> > looked at the mainline Linux device trees and I couldn't easily see the
> > correspondence.  Will the renaming complicate synchronization?
>
> Do we need to maintain the same dt file between linux and uboot ?
> Also in uboot we don't enable all devices,  how do we handle this ?

If there is no U-Boot driver for a particular node then it will be
ignored. It is easier to keep them in sync if they are the same in
U-Boot and Linux.

> Please let me know.

That is implied by your question above :-)

Regards,
SImon