| Message ID | 20250328-topic-sm8x50-spmi-fix-v1-0-a7548d3aef0d@linaro.org |
|---|---|
| Headers | show |
| Series | spmi: msm: fix pid mapping for v5 & v7 controllers | expand |
On 3/28/25 09:53, Neil Armstrong wrote: > The v5 & v7 controllers has complex mapping for > different Execution Environment, and v7 supports > two busses within the same controller so it needs > some special care when parsing the hardware map > table to get the proper read & write channels. > > Test are welcome, especially for v5 controllers. > > Tested on HDK8550, QRD8550 & QRD8650. Buttons still work for me at least :D Tested-by: <caleb.connolly@linaro.org> # sdm845 Not sure I'm familiar enough with SPMI to leave an R-b, but the patches look good! Kind regards, > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Neil Armstrong (4): > spmi: msm: use real number of channels for v5 & v7 > spmi: msm: factor out channel mapping for v5 & v7 > spmi: msm: introduce SPMI_CHANNEL_VALID flag > spmi: msm: correctly handle multiple mapping entries > > drivers/spmi/spmi-msm.c | 59 ++++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 49 insertions(+), 10 deletions(-) > --- > base-commit: 4adbf64ff8d8c730223fd8ae299d770bebb6fe86 > change-id: 20250328-topic-sm8x50-spmi-fix-1e2b433a6ffd > > Best regards,
On Fri, 28 Mar 2025 09:53:20 +0100, Neil Armstrong wrote: > The v5 & v7 controllers has complex mapping for > different Execution Environment, and v7 supports > two busses within the same controller so it needs > some special care when parsing the hardware map > table to get the proper read & write channels. > > Test are welcome, especially for v5 controllers. > > [...] Applied, thanks! [1/4] spmi: msm: use real number of channels for v5 & v7 https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/66399360db72 [2/4] spmi: msm: factor out channel mapping for v5 & v7 https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/d2f9f2ce5335 [3/4] spmi: msm: introduce SPMI_CHANNEL_VALID flag https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/7706c62fcfa7 [4/4] spmi: msm: correctly handle multiple mapping entries https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/c03a52e82616 Best regards,
The v5 & v7 controllers has complex mapping for different Execution Environment, and v7 supports two busses within the same controller so it needs some special care when parsing the hardware map table to get the proper read & write channels. Test are welcome, especially for v5 controllers. Tested on HDK8550, QRD8550 & QRD8650. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- Neil Armstrong (4): spmi: msm: use real number of channels for v5 & v7 spmi: msm: factor out channel mapping for v5 & v7 spmi: msm: introduce SPMI_CHANNEL_VALID flag spmi: msm: correctly handle multiple mapping entries drivers/spmi/spmi-msm.c | 59 ++++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 49 insertions(+), 10 deletions(-) --- base-commit: 4adbf64ff8d8c730223fd8ae299d770bebb6fe86 change-id: 20250328-topic-sm8x50-spmi-fix-1e2b433a6ffd Best regards,