mbox series

[0/6] Qualcomm: cleanup OF_LIVE fixup and fix RB1/2

Message ID 20250409-livetree-fixup-v1-0-76dfea80b07f@linaro.org
Headers show
Series Qualcomm: cleanup OF_LIVE fixup and fix RB1/2 | expand

Message

Caleb Connolly April 9, 2025, 5:17 p.m. UTC
Introduce a new event to signal that the live tree has been built,
allowing boards to perform fixups on the tree before devices are bound.
Crucially this allows for devices to be enabled or disabled, but also
allows for properties that are parsed during the bind stage to be
modified (such as dr_mode for dwc3).

With this in place, mach-snapdragon is switched over to use the event
and some hacky U-Boot specific DT overrides (which had to be undone
prior to booting an image) are removed in favour of fixing up the
livetree (which is not passed on to further boot stages).

Finally, some minor fixes are made for the QCM2290 RB1 board, the sdcard
is enabled and it now uses USB host mode in U-Boot like it's bigger
sibling the RB2.

---
Caleb Connolly (6):
      event: signal when livetree has been built
      mach-snapdragon: use EVT_OF_LIVE_INIT to apply DT fixups
      mach-snapdragon: of_fixup: skip disabled USB nodes
      clk/qcom: qcm2290: show clock name in set_rate()
      mach-snapdragon: of_fixup: set dr_mode for RB1/2 boards
      pinctrl: qcom: qcm2290: fix off by 1 in pin_count

 arch/arm/dts/qrb4210-rb2-u-boot.dtsi   |  6 -----
 arch/arm/mach-snapdragon/board.c       |  1 -
 arch/arm/mach-snapdragon/of_fixup.c    | 41 ++++++++++++++++++++--------------
 arch/arm/mach-snapdragon/qcom-priv.h   | 14 ------------
 common/event.c                         |  3 +++
 drivers/clk/qcom/clock-qcm2290.c       |  2 +-
 drivers/pinctrl/qcom/pinctrl-qcm2290.c |  2 +-
 include/event.h                        |  9 ++++++++
 lib/of_live.c                          |  3 +++
 9 files changed, 41 insertions(+), 40 deletions(-)
---
base-commit: e4ffc6a323586d700d88c73c319c25c740aedb49
change-id: 20250409-livetree-fixup-0d7451cc3af3

Caleb Connolly <caleb.connolly@linaro.org>

Comments

Sumit Garg April 10, 2025, 8:41 a.m. UTC | #1
Hi Caleb,

On Wed, Apr 09, 2025 at 07:17:23PM +0200, Caleb Connolly wrote:
> Introduce a new event to signal that the live tree has been built,
> allowing boards to perform fixups on the tree before devices are bound.
> Crucially this allows for devices to be enabled or disabled, but also
> allows for properties that are parsed during the bind stage to be
> modified (such as dr_mode for dwc3).

Looks like a nice platform override available with OF_LIVE.

> 
> With this in place, mach-snapdragon is switched over to use the event
> and some hacky U-Boot specific DT overrides (which had to be undone
> prior to booting an image) are removed in favour of fixing up the
> livetree (which is not passed on to further boot stages).
>

Nice.

> Finally, some minor fixes are made for the QCM2290 RB1 board, the sdcard
> is enabled and it now uses USB host mode in U-Boot like it's bigger
> sibling the RB2.

FWIW, for the series:

Tested-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
> ---
> Caleb Connolly (6):
>       event: signal when livetree has been built
>       mach-snapdragon: use EVT_OF_LIVE_INIT to apply DT fixups
>       mach-snapdragon: of_fixup: skip disabled USB nodes
>       clk/qcom: qcm2290: show clock name in set_rate()
>       mach-snapdragon: of_fixup: set dr_mode for RB1/2 boards
>       pinctrl: qcom: qcm2290: fix off by 1 in pin_count
> 
>  arch/arm/dts/qrb4210-rb2-u-boot.dtsi   |  6 -----
>  arch/arm/mach-snapdragon/board.c       |  1 -
>  arch/arm/mach-snapdragon/of_fixup.c    | 41 ++++++++++++++++++++--------------
>  arch/arm/mach-snapdragon/qcom-priv.h   | 14 ------------
>  common/event.c                         |  3 +++
>  drivers/clk/qcom/clock-qcm2290.c       |  2 +-
>  drivers/pinctrl/qcom/pinctrl-qcm2290.c |  2 +-
>  include/event.h                        |  9 ++++++++
>  lib/of_live.c                          |  3 +++
>  9 files changed, 41 insertions(+), 40 deletions(-)
> ---
> base-commit: e4ffc6a323586d700d88c73c319c25c740aedb49
> change-id: 20250409-livetree-fixup-0d7451cc3af3
> 
> Caleb Connolly <caleb.connolly@linaro.org>
>
Caleb Connolly April 10, 2025, 9:54 a.m. UTC | #2
On Wed, 09 Apr 2025 19:17:23 +0200, Caleb Connolly wrote:
> Introduce a new event to signal that the live tree has been built,
> allowing boards to perform fixups on the tree before devices are bound.
> Crucially this allows for devices to be enabled or disabled, but also
> allows for properties that are parsed during the bind stage to be
> modified (such as dr_mode for dwc3).
> 
> With this in place, mach-snapdragon is switched over to use the event
> and some hacky U-Boot specific DT overrides (which had to be undone
> prior to booting an image) are removed in favour of fixing up the
> livetree (which is not passed on to further boot stages).
> 
> [...]

Applied, thanks!

[1/6] event: signal when livetree has been built
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/1c057be814e1
[2/6] mach-snapdragon: use EVT_OF_LIVE_INIT to apply DT fixups
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/f27e9c349b03
[3/6] mach-snapdragon: of_fixup: skip disabled USB nodes
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/6d81cb1c01bc
[4/6] clk/qcom: qcm2290: show clock name in set_rate()
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/bd7b4fa55310
[5/6] mach-snapdragon: of_fixup: set dr_mode for RB1/2 boards
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/dfb173f8080b
[6/6] pinctrl: qcom: qcm2290: fix off by 1 in pin_count
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/9511f4381bdf

Best regards,