From patchwork Fri May 8 17:07:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Harkin X-Patchwork-Id: 48179 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3B3E12121F for ; Fri, 8 May 2015 17:08:51 +0000 (UTC) Received: by wicmx19 with SMTP id mx19sf9020987wic.3 for ; Fri, 08 May 2015 10:08:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=bjYj+2OW8/U0zyCoA38vYsru7Kwy0tjY0G5SZvCbWIQ=; b=fK+ah1dTJD7RE8wg7kXQLwsbUd5kunlun9kTXDC/4ShvF1OzpSFoAIqH6QLnZ/kq1C VnA+ql5Z/HszgVHZseIV5clhxQKaqUoCuQ8QrLJvl5r3zMY7IcPwOnlGbnesTnqvwc0w iFssx104U3fzNtuso2cbI/uYfgSzfSiQfEhp5pFoo6DkTJd2NaqVPI6QB2s9GpKqBBYi NjB6DVayjBqF+xlrgTjvFQG9D8F4kOK2NZuo43S4FjPVXV/f3Abtbm/aJrfqMSALApcG XW2GE2n5eJm39fBtxXe5/bqmq0jRh++P7H0XO6Wg3anwOp65QoTFm08CmdrkiNdNpzar blsQ== X-Gm-Message-State: ALoCoQnz0p4rc1GfXTWpaDyejIy4Dg1sGL69ne5+w4vyIAH2mZszRGKjWwXkYT0b+FghiM1/mpua X-Received: by 10.112.171.41 with SMTP id ar9mr2527355lbc.24.1431104930515; Fri, 08 May 2015 10:08:50 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.4.73 with SMTP id i9ls378562lai.100.gmail; Fri, 08 May 2015 10:08:50 -0700 (PDT) X-Received: by 10.152.21.170 with SMTP id w10mr3546305lae.27.1431104930369; Fri, 08 May 2015 10:08:50 -0700 (PDT) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com. [209.85.215.45]) by mx.google.com with ESMTPS id qv7si3629227lbb.162.2015.05.08.10.08.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 May 2015 10:08:50 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) client-ip=209.85.215.45; Received: by laat2 with SMTP id t2so57040591laa.1 for ; Fri, 08 May 2015 10:08:50 -0700 (PDT) X-Received: by 10.112.204.72 with SMTP id kw8mr217564lbc.88.1431104930245; Fri, 08 May 2015 10:08:50 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp142030lbb; Fri, 8 May 2015 10:08:49 -0700 (PDT) X-Received: by 10.180.97.129 with SMTP id ea1mr8197766wib.24.1431104929651; Fri, 08 May 2015 10:08:49 -0700 (PDT) Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id el4si10112332wid.33.2015.05.08.10.08.48; Fri, 08 May 2015 10:08:49 -0700 (PDT) Received-SPF: none (google.com: u-boot-bounces@lists.denx.de does not designate permitted sender hosts) client-ip=85.214.87.163; Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 383DC4B66A; Fri, 8 May 2015 19:08:20 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0SIiaxJGCudW; Fri, 8 May 2015 19:08:19 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 785484B62B; Fri, 8 May 2015 19:08:19 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9D4094B61A for ; Fri, 8 May 2015 19:08:16 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S_Ykvp82zPCS for ; Fri, 8 May 2015 19:08:16 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by theia.denx.de (Postfix) with ESMTPS id 2D02C4B6DC for ; Fri, 8 May 2015 19:08:10 +0200 (CEST) Received: by wicmx19 with SMTP id mx19so40936651wic.1 for ; Fri, 08 May 2015 10:08:10 -0700 (PDT) X-Received: by 10.181.11.193 with SMTP id ek1mr7965315wid.15.1431104890085; Fri, 08 May 2015 10:08:10 -0700 (PDT) Received: from localhost.localdomain (82-69-54-187.dsl.in-addr.zen.co.uk. [82.69.54.187]) by mx.google.com with ESMTPSA id di7sm9712681wib.23.2015.05.08.10.08.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 May 2015 10:08:09 -0700 (PDT) From: Ryan Harkin To: linus.walleij@linaro.org, ryan.harkin@linaro.org, u-boot@lists.denx.de Date: Fri, 8 May 2015 18:07:52 +0100 Message-Id: <1431104872-8645-1-git-send-email-ryan.harkin@linaro.org> X-Mailer: git-send-email 2.1.0 Subject: [U-Boot] [PATCH] vexpress64: specify CONFIG_SYS_FLASH_CFI_WIDTH X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ryan.harkin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Testing on the ARM Versatile Express Juno board showed intermittent CFI flash detection problems. Debug output in exception cases showed that the NOR flash was returning incorrect values to a query command: fwc addr 0000000008000000 cmd f0 f0f0f0f0 32bit x 8 bit fwc addr 0000000008000000 cmd ff ffffffff 32bit x 8 bit fwc addr 0000000008000154 cmd 98 98989898 32bit x 8 bit is= cmd 51(Q) addr 0000000008000040 is= 00800051 51515151 fwc addr 0000000008001554 cmd 98 98989898 32bit x 8 bit is= cmd 51(Q) addr 0000000008000040 is= 00800051 51515151 fwc addr 0000000008000000 cmd f0 00f000f0 32bit x 16 bit fwc addr 0000000008000000 cmd ff 00ff00ff 32bit x 16 bit fwc addr 0000000008000154 cmd 98 00980098 32bit x 16 bit is= cmd 51(Q) addr 0000000008000040 is= 00800051 00510051 fwc addr 0000000008001554 cmd 98 00980098 32bit x 16 bit is= cmd 51(Q) addr 0000000008000040 is= 00800051 00510051 Debugging showed that the problem could be solved by preventing u-boot from scanning different flash widths by specifying CONFIG_SYS_FLASH_CFI_WIDTH so that only using the 'correct' width was used. Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij --- include/configs/vexpress_aemv8a.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/vexpress_aemv8a.h b/include/configs/vexpress_aemv8a.h index 032010b..18edd5d 100644 --- a/include/configs/vexpress_aemv8a.h +++ b/include/configs/vexpress_aemv8a.h @@ -264,6 +264,7 @@ #define CONFIG_CMD_ARMFLASH #define CONFIG_SYS_FLASH_CFI 1 #define CONFIG_FLASH_CFI_DRIVER 1 +#define CONFIG_SYS_FLASH_CFI_WIDTH FLASH_CFI_32BIT #define CONFIG_SYS_FLASH_BASE 0x08000000 #define CONFIG_SYS_FLASH_SIZE 0x04000000 /* 64 MiB */ #define CONFIG_SYS_MAX_FLASH_BANKS 2