From patchwork Fri Apr 29 11:59:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 66942 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp747709qge; Fri, 29 Apr 2016 05:08:24 -0700 (PDT) X-Received: by 10.28.178.129 with SMTP id b123mr3687877wmf.76.1461931704900; Fri, 29 Apr 2016 05:08:24 -0700 (PDT) Return-Path: Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id c17si3839730wmh.115.2016.04.29.05.08.24; Fri, 29 Apr 2016 05:08:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) client-ip=85.214.87.163; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id DAF1DA7777; Fri, 29 Apr 2016 14:08:19 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PpHAmMBH1mHa; Fri, 29 Apr 2016 14:08:19 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6D5CDA777B; Fri, 29 Apr 2016 14:04:02 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2F8F5A76D4 for ; Fri, 29 Apr 2016 14:00:04 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vh1UKg73slCi for ; Fri, 29 Apr 2016 14:00:04 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by theia.denx.de (Postfix) with ESMTPS id 91797A773F for ; Fri, 29 Apr 2016 13:59:34 +0200 (CEST) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id u3TBxUsw011313; Fri, 29 Apr 2016 06:59:31 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id u3TBxUBZ010105; Fri, 29 Apr 2016 06:59:30 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.224.2; Fri, 29 Apr 2016 06:59:30 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id u3TBxU8i010602; Fri, 29 Apr 2016 06:59:30 -0500 Received: from localhost (a0272616local.am.dhcp.ti.com [172.22.131.160]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id u3TBxU909861; Fri, 29 Apr 2016 06:59:30 -0500 (CDT) From: Dan Murphy To: Date: Fri, 29 Apr 2016 06:59:27 -0500 Message-ID: <1461931167-24110-7-git-send-email-dmurphy@ti.com> X-Mailer: git-send-email 2.7.2.333.g70bd996 In-Reply-To: <1461931167-24110-1-git-send-email-dmurphy@ti.com> References: <1461931167-24110-1-git-send-email-dmurphy@ti.com> MIME-Version: 1.0 Cc: michal.simek@xilinx.com, trini@konsulko.com Subject: [U-Boot] [PATCH v7 7/7] net: phy: dp83867: Add SGMII helper for configuration X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The code assumed that if the interface is not RGMII configured then it must be SGMII configured. This device has the ability to support most of the MII interfaces. Therefore add the helper for SGMII and only configure the device if the interface is configured for SGMII. Signed-off-by: Dan Murphy Reviewed-by: Mugunthan V N Reviewed-by: Michal Simek --- v7 - no changes from v6 drivers/net/phy/ti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.8.1.116.g7b0d47b _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c index 4c19353..c55dd97 100644 --- a/drivers/net/phy/ti.c +++ b/drivers/net/phy/ti.c @@ -221,7 +221,7 @@ static int dp83867_config(struct phy_device *phydev) (dp83867->fifo_depth << DP83867_PHYCR_FIFO_DEPTH_SHIFT)); if (ret) goto err_out; - } else { + } else if (phy_interface_is_sgmii(phydev)) { phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, (BMCR_ANENABLE | BMCR_FULLDPLX | BMCR_SPEED1000));