From patchwork Fri Dec 30 14:20:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 89368 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp6460794qgi; Fri, 30 Dec 2016 06:20:52 -0800 (PST) X-Received: by 10.194.246.170 with SMTP id xx10mr40465691wjc.174.1483107651909; Fri, 30 Dec 2016 06:20:51 -0800 (PST) Return-Path: Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id n127si33792111wmf.41.2016.12.30.06.20.51; Fri, 30 Dec 2016 06:20:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) client-ip=85.214.87.163; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B76C9B388C; Fri, 30 Dec 2016 15:20:50 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rR50dJnASvcU; Fri, 30 Dec 2016 15:20:50 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 07A54A761F; Fri, 30 Dec 2016 15:20:50 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id BBF1BA761F for ; Fri, 30 Dec 2016 15:20:45 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tVGcljlGNPg4 for ; Fri, 30 Dec 2016 15:20:45 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from conuserg-11.nifty.com (conuserg-11.nifty.com [210.131.2.78]) by theia.denx.de (Postfix) with ESMTPS id 088BBA7609 for ; Fri, 30 Dec 2016 15:20:41 +0100 (CET) Received: from grover.sesame (FL1-111-169-71-157.osk.mesh.ad.jp [111.169.71.157]) (authenticated) by conuserg-11.nifty.com with ESMTP id uBUEKHc2021011; Fri, 30 Dec 2016 23:20:19 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com uBUEKHc2021011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1483107620; bh=UMN+zOIp96by0GPB8Mixy85tcYmoSaP8pAvji+U+mxM=; h=From:To:Cc:Subject:Date:From; b=q6G1YufJ7HQ8bfugzsP1+FrIG462khdjzNrLCQ5C6aRFYdj5NEvp8RIEynih6sRFx ZMQ+mkymDGsRRfceNxL+tgkHaXthhIvDxndLqQBZ9qPrrSMTi2P5UXRZgH7Mtfd4T8 K4ioEpmJdIZmpsMbwaWFcxEvyH1IhRs32rvqUVEwZUEuHYeAwRb9x267YJUldAzzuj tgJqdtGUxmf+No5Th4XzRRtmeL3pW/lGxp8WWG7y23SA2PnvtPZNZMtD46+/w0iq6y Zv5LiH6E18N9b4fTW9YDXwBLWZNDzjmIEtJtQshRkYJO1iDgjQ5E1CauBpqhif/XEK r2PovUnsV87rw== X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: u-boot@lists.denx.de Date: Fri, 30 Dec 2016 23:20:14 +0900 Message-Id: <1483107614-16815-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Subject: [U-Boot] [PATCH] mmc: uniphier-sd: fix Kconfig dependency X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Some MMC drivers describe operations with the DM_MMC_OPS form, but there are still several drivers with older implementation. We can not compile drivers from different groups at the same time because the core framework is shared with #ifdef CONFIG_DM_MMC_OPS. Every driver should have "depends on DM_MMC_OPS" (or !DM_MMC_OPS) explicitly to express which framework it is based on. This will avoid enabling drivers with incompatible interface at the same time. It is incorrect to make a driver "select DM_MMC_OPS". While we are here, add "depends on OF_CONTROL" as well because this driver can be configured only by Device Tree. Signed-off-by: Masahiro Yamada --- drivers/mmc/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index ff4344f..75b6ba1 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -107,8 +107,8 @@ config ROCKCHIP_SDHCI config MMC_UNIPHIER bool "UniPhier SD/MMC Host Controller support" depends on ARCH_UNIPHIER - depends on BLK - select DM_MMC_OPS + depends on BLK && DM_MMC_OPS + depends on OF_CONTROL help This selects support for the SD/MMC Host Controller on UniPhier SoCs.