diff mbox series

[Patchv4,3/3] arm: dts: Add cd-gpio for eMMC

Message ID 20200122120620.8699-4-linux.amoon@gmail.com
State New
Headers show
Series Odroid n2 using eMMC would fail to boot up | expand

Commit Message

Anand Moon Jan. 22, 2020, 12:06 p.m. UTC
Add cd-gpio property for eMMC node.

Signed-off-by: Anand Moon <linux.amoon at gmail.com>
---
New patch in this series
---
 arch/arm/dts/meson-g12b-odroid-n2.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Neil Armstrong Jan. 22, 2020, 12:15 p.m. UTC | #1
Hi,

On 22/01/2020 13:06, Anand Moon wrote:
> Add cd-gpio property for eMMC node.
> 
> Signed-off-by: Anand Moon <linux.amoon at gmail.com>
> ---
> New patch in this series
> ---
>  arch/arm/dts/meson-g12b-odroid-n2.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/dts/meson-g12b-odroid-n2.dts b/arch/arm/dts/meson-g12b-odroid-n2.dts
> index 888429b1cc..23ec14abe7 100644
> --- a/arch/arm/dts/meson-g12b-odroid-n2.dts
> +++ b/arch/arm/dts/meson-g12b-odroid-n2.dts
> @@ -449,6 +449,7 @@
>  	max-frequency = <200000000>;
>  	disable-wp;
>  
> +	cd-gpios = <&gpio GPIOH_7 GPIO_ACTIVE_LOW>; /* eMMC_nDET */
>  	mmc-pwrseq = <&emmc_pwrseq>;
>  	vmmc-supply = <&vcc_3v3>;
>  	vqmmc-supply = <&flash_1v8>;
> 

If it's missing, submit it to linux-amlogic and move it to the -u-boot.dtsi file.

Neil
Anand Moon Jan. 22, 2020, 3:52 p.m. UTC | #2
Hi Neil,

On Wed, 22 Jan 2020 at 17:45, Neil Armstrong <narmstrong at baylibre.com> wrote:
>
> Hi,
>
> On 22/01/2020 13:06, Anand Moon wrote:
> > Add cd-gpio property for eMMC node.
> >
> > Signed-off-by: Anand Moon <linux.amoon at gmail.com>
> > ---
> > New patch in this series
> > ---
> >  arch/arm/dts/meson-g12b-odroid-n2.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/dts/meson-g12b-odroid-n2.dts b/arch/arm/dts/meson-g12b-odroid-n2.dts
> > index 888429b1cc..23ec14abe7 100644
> > --- a/arch/arm/dts/meson-g12b-odroid-n2.dts
> > +++ b/arch/arm/dts/meson-g12b-odroid-n2.dts
> > @@ -449,6 +449,7 @@
> >       max-frequency = <200000000>;
> >       disable-wp;
> >
> > +     cd-gpios = <&gpio GPIOH_7 GPIO_ACTIVE_LOW>; /* eMMC_nDET */
> >       mmc-pwrseq = <&emmc_pwrseq>;
> >       vmmc-supply = <&vcc_3v3>;
> >       vqmmc-supply = <&flash_1v8>;
> >
>
> If it's missing, submit it to linux-amlogic and move it to the -u-boot.dtsi file.
>
> Neil

Thanks for your review.
Ok I will submit this patch to linux-amlogic

-Anand
diff mbox series

Patch

diff --git a/arch/arm/dts/meson-g12b-odroid-n2.dts b/arch/arm/dts/meson-g12b-odroid-n2.dts
index 888429b1cc..23ec14abe7 100644
--- a/arch/arm/dts/meson-g12b-odroid-n2.dts
+++ b/arch/arm/dts/meson-g12b-odroid-n2.dts
@@ -449,6 +449,7 @@ 
 	max-frequency = <200000000>;
 	disable-wp;
 
+	cd-gpios = <&gpio GPIOH_7 GPIO_ACTIVE_LOW>; /* eMMC_nDET */
 	mmc-pwrseq = <&emmc_pwrseq>;
 	vmmc-supply = <&vcc_3v3>;
 	vqmmc-supply = <&flash_1v8>;