diff mbox series

[20/21] test: Enable console recording in tests

Message ID	20200127084920.20.I0d843e524c54d3c7a29919c95929b1909b9eaa61@changeid
State	Accepted
Commit	cfccff8000cb3f5b8eaee9a12568bc14eadfae8e
Headers	show List-Id: U-Boot discussion <u-boot.lists.denx.de> From: sjg at chromium.org (Simon Glass) Date: Mon, 27 Jan 2020 08:49:55 -0700 Subject: [PATCH 20/21] test: Enable console recording in tests In-Reply-To: <20200127154956.64368-1-sjg@chromium.org> References: <20200127154956.64368-1-sjg@chromium.org> Message-ID: <20200127084920.20.I0d843e524c54d3c7a29919c95929b1909b9eaa61@changeid>
Series	dm: Various enhancements to prepare for ACPI \| expand [00/21] dm: Various enhancements to prepare for ACPI [01/21] dm: core: Use const where possible in device.h [02/21] dm: pci: Update the PCI read_config() method to const dev * [03/21] dm: pci: Update a few more interfaces for const udevice * [04/21] dm: core: Use const device for the devfdt...() interface [05/21] dm: core: Use const device for the dev_read_...() interface [06/21] test: Add underscore prefix to macro parameters [07/21] dm: core: Update comment for ofnode_get_chosen_node() [08/21] dm: core: Rename ofnode_get_chosen_prop() [09/21] dm: core: Add ofnode_read_prop() [10/21] dm: core: Reimplement ofnode_read_size() [11/21] dm: core: Add ofnode_get_chosen_prop() [12/21] dm: core: Add a way to read platdata for all child devices [13/21] dm: core: Add a way to iterate through children, probing each [14/21] dm: core: Drop uclass_find_next_free_req_seq() conditions [15/21] bloblist: Add a new function to add or check size [16/21] bloblist: Tidy up a few comments and code-style nits [17/21] bloblist: Zero records when adding [18/21] sandbox: pmic: Correct i2c pmic emulator platdata method [19/21] console: Add a function to read a line of the output / eof [20/21] test: Enable console recording in tests [21/21] test: Add a way to check each line of console output

Commit Message

Simon Glass Jan. 27, 2020, 3:49 p.m. UTC

At present we reset the console buffer before each test but do not
actually set the recording flag. Without this, the output is not
recorded.

Update the code to set the flag before the test and clear it afterwards.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 test/dm/test-main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/test/dm/test-main.c b/test/dm/test-main.c
index 72648162a9..d7dc8d1f91 100644
--- a/test/dm/test-main.c
+++ b/test/dm/test-main.c
@@ -97,11 +97,11 @@  static int dm_do_test(struct unit_test_state *uts, struct unit_test *test,
 	 * Silence the console and rely on console recording to get
 	 * our output.
 	 */
-	console_record_reset();
+	console_record_reset_enable();
 	if (!state->show_test_output)
 		gd->flags |= GD_FLG_SILENT;
 	test->func(uts);
-	gd->flags &= ~GD_FLG_SILENT;
+	gd->flags &= ~(GD_FLG_SILENT | GD_FLG_RECORD);
 	state_set_skip_delays(false);
 
 	ut_assertok(dm_test_destroy(uts));