Message ID | 20200308214442.v2.8.I0e67688e96b62650b8218c3d536f9fc4de9d13b4@changeid |
---|---|
State | Superseded |
Headers | show |
Series | dm: Add programmatic generation of ACPI tables (part A) | expand |
-----"Simon Glass" <sjg at chromium.org> schrieb: ----- > > Some files are taken or modified from coreboot, but the files are > no-longer part of the coreboot project. Fix the wording in a few places. > > Signed-off-by: Simon Glass <sjg at chromium.org> > Reviewed-by: Bin Meng <bmeng.cn at gmail.com> > --- > > Changes in v2: None > > arch/x86/cpu/coreboot/timestamp.c | 4 ++-- > arch/x86/include/asm/arch-coreboot/timestamp.h | 4 ++-- > arch/x86/include/asm/intel_pinctrl_defs.h | 2 -- > 3 files changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
On Mon, Mar 9, 2020 at 5:47 AM Simon Glass <sjg at chromium.org> wrote: > > Some files are taken or modified from coreboot, but the files are > no-longer part of the coreboot project. Fix the wording in a few places. > > Signed-off-by: Simon Glass <sjg at chromium.org> > Reviewed-by: Bin Meng <bmeng.cn at gmail.com> > --- > > Changes in v2: None > > arch/x86/cpu/coreboot/timestamp.c | 4 ++-- > arch/x86/include/asm/arch-coreboot/timestamp.h | 4 ++-- > arch/x86/include/asm/intel_pinctrl_defs.h | 2 -- > 3 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/cpu/coreboot/timestamp.c b/arch/x86/cpu/coreboot/timestamp.c > index e698200d70..e8ccaf2212 100644 > --- a/arch/x86/cpu/coreboot/timestamp.c > +++ b/arch/x86/cpu/coreboot/timestamp.c > @@ -1,8 +1,8 @@ > // SPDX-License-Identifier: GPL-2.0+ > /* > - * This file is part of the coreboot project. > - * > * Copyright (C) 2011 The ChromiumOS Authors. All rights reserved. > + * > + * Modified from the coreboot version Perhaps leave the period at the end of the line to follow English punctuation? > */ > > #include <common.h> > diff --git a/arch/x86/include/asm/arch-coreboot/timestamp.h b/arch/x86/include/asm/arch-coreboot/timestamp.h > index 9320afba56..85d42c02c4 100644 > --- a/arch/x86/include/asm/arch-coreboot/timestamp.h > +++ b/arch/x86/include/asm/arch-coreboot/timestamp.h > @@ -1,8 +1,8 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * This file is part of the coreboot project. > - * > * Copyright (C) 2011 The ChromiumOS Authors. All rights reserved. > + * > + * Taken from the coreboot version > */ > > #ifndef __COREBOOT_TIMESTAMP_H__ > diff --git a/arch/x86/include/asm/intel_pinctrl_defs.h b/arch/x86/include/asm/intel_pinctrl_defs.h > index 6da06bb52b..1ea141f082 100644 > --- a/arch/x86/include/asm/intel_pinctrl_defs.h > +++ b/arch/x86/include/asm/intel_pinctrl_defs.h > @@ -1,7 +1,5 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > /* > - * This file is part of the coreboot project. > - * > * Copyright (C) 2015-2016 Intel Corp. > * Copyright 2019 Google LLC > * > -- > 2.25.1.481.gfbce0eb801-goog >
Hi Andy, On Mon, 9 Mar 2020 at 01:44, Andy Shevchenko <andy.shevchenko at gmail.com> wrote: > > On Mon, Mar 9, 2020 at 5:47 AM Simon Glass <sjg at chromium.org> wrote: > > > > Some files are taken or modified from coreboot, but the files are > > no-longer part of the coreboot project. Fix the wording in a few places. > > > > Signed-off-by: Simon Glass <sjg at chromium.org> > > Reviewed-by: Bin Meng <bmeng.cn at gmail.com> > > --- > > > > Changes in v2: None > > > > arch/x86/cpu/coreboot/timestamp.c | 4 ++-- > > arch/x86/include/asm/arch-coreboot/timestamp.h | 4 ++-- > > arch/x86/include/asm/intel_pinctrl_defs.h | 2 -- > > 3 files changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/arch/x86/cpu/coreboot/timestamp.c b/arch/x86/cpu/coreboot/timestamp.c > > index e698200d70..e8ccaf2212 100644 > > --- a/arch/x86/cpu/coreboot/timestamp.c > > +++ b/arch/x86/cpu/coreboot/timestamp.c > > @@ -1,8 +1,8 @@ > > // SPDX-License-Identifier: GPL-2.0+ > > /* > > - * This file is part of the coreboot project. > > - * > > * Copyright (C) 2011 The ChromiumOS Authors. All rights reserved. > > + * > > + * Modified from the coreboot version > > Perhaps leave the period at the end of the line to follow English punctuation? This is actually something I try to avoid. It is not a sentence and turning it into one by adding more words doesn't improve its value IMO. Regards, Simon
diff --git a/arch/x86/cpu/coreboot/timestamp.c b/arch/x86/cpu/coreboot/timestamp.c index e698200d70..e8ccaf2212 100644 --- a/arch/x86/cpu/coreboot/timestamp.c +++ b/arch/x86/cpu/coreboot/timestamp.c @@ -1,8 +1,8 @@ // SPDX-License-Identifier: GPL-2.0+ /* - * This file is part of the coreboot project. - * * Copyright (C) 2011 The ChromiumOS Authors. All rights reserved. + * + * Modified from the coreboot version */ #include <common.h> diff --git a/arch/x86/include/asm/arch-coreboot/timestamp.h b/arch/x86/include/asm/arch-coreboot/timestamp.h index 9320afba56..85d42c02c4 100644 --- a/arch/x86/include/asm/arch-coreboot/timestamp.h +++ b/arch/x86/include/asm/arch-coreboot/timestamp.h @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * This file is part of the coreboot project. - * * Copyright (C) 2011 The ChromiumOS Authors. All rights reserved. + * + * Taken from the coreboot version */ #ifndef __COREBOOT_TIMESTAMP_H__ diff --git a/arch/x86/include/asm/intel_pinctrl_defs.h b/arch/x86/include/asm/intel_pinctrl_defs.h index 6da06bb52b..1ea141f082 100644 --- a/arch/x86/include/asm/intel_pinctrl_defs.h +++ b/arch/x86/include/asm/intel_pinctrl_defs.h @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * This file is part of the coreboot project. - * * Copyright (C) 2015-2016 Intel Corp. * Copyright 2019 Google LLC *