From patchwork Thu Apr 9 21:08:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 237584 List-Id: U-Boot discussion From: sjg at chromium.org (Simon Glass) Date: Thu, 9 Apr 2020 15:08:35 -0600 Subject: [PATCH v2 08/28] buildman: Use yellow consistently for warning lines In-Reply-To: <20200409210856.160952-1-sjg@chromium.org> References: <20200409210856.160952-1-sjg@chromium.org> Message-ID: <20200409150840.v2.8.Ifbcc1c7085c9545bd1533d4b0685145aacd5a7f0@changeid> At present warnings are shown in yellow in the summary (-s) but magenta in the detail listing (-e). Use yellow in both. Signed-off-by: Simon Glass Signed-off-by: Simon Glass --- Changes in v2: None tools/buildman/builder.py | 2 +- tools/buildman/test.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py index 621147696ed..01d8bf46e45 100644 --- a/tools/buildman/builder.py +++ b/tools/buildman/builder.py @@ -1279,7 +1279,7 @@ class Builder: _OutputErrLines(better_err, colour=self.col.GREEN) _OutputErrLines(worse_err, colour=self.col.RED) _OutputErrLines(better_warn, colour=self.col.CYAN) - _OutputErrLines(worse_warn, colour=self.col.MAGENTA) + _OutputErrLines(worse_warn, colour=self.col.YELLOW) if show_sizes: self.PrintSizeSummary(board_selected, board_dict, show_detail, diff --git a/tools/buildman/test.py b/tools/buildman/test.py index b1435b45c03..c494a158be6 100644 --- a/tools/buildman/test.py +++ b/tools/buildman/test.py @@ -264,7 +264,7 @@ class TestBuild(unittest.TestCase): self.assertEqual(line.text, add_line_prefix('w+', boards1234, errors[0])) - self.assertEqual(line.colour, col.MAGENTA) + self.assertEqual(line.colour, col.YELLOW) # Third commit: Still fails self.assertEqual(next(lines).text, '03: %s' % commits[2][1]) @@ -299,7 +299,7 @@ class TestBuild(unittest.TestCase): line = next(lines) self.assertEqual(line.text, add_line_prefix('w+', boards34, errors[2])) - self.assertEqual(line.colour, col.MAGENTA) + self.assertEqual(line.colour, col.YELLOW) # Fifth commit self.assertEqual(next(lines).text, '05: %s' % commits[4][1]) @@ -353,7 +353,7 @@ class TestBuild(unittest.TestCase): expect = '\n'.join(expect) line = next(lines) self.assertEqual(line.text, add_line_prefix('w+', boards4, expect)) - self.assertEqual(line.colour, col.MAGENTA) + self.assertEqual(line.colour, col.YELLOW) def testOutput(self): """Test basic builder operation and output