diff mbox series

[4/4] defconfig: veyron: no need for CONFIG_SPL_PINCTRL_FULL

Message ID 20200513191523.3141-5-urjaman@gmail.com
State Accepted
Commit 5e50f8787cefd7f35f8d33983876d56d1dc5463a
Headers show
Series Making veyrons boot, 2020 edition | expand

Commit Message

Urja Rannikko May 13, 2020, 7:15 p.m. UTC
Veyrons do not need full pinctrl support for SPL.
The full pinctrl support does nothing when enabled with OF_PLATDATA,
thus was already unused.
This frees about 4kB of SPL size.

Signed-off-by: Urja Rannikko <urjaman at gmail.com>
---
 configs/chromebit_mickey_defconfig  | 3 +--
 configs/chromebook_jerry_defconfig  | 3 +--
 configs/chromebook_minnie_defconfig | 3 +--
 configs/chromebook_speedy_defconfig | 1 +
 4 files changed, 4 insertions(+), 6 deletions(-)

Comments

Kever Yang May 15, 2020, 1:58 a.m. UTC | #1
On 2020/5/14 ??3:15, Urja Rannikko wrote:
> Veyrons do not need full pinctrl support for SPL.
> The full pinctrl support does nothing when enabled with OF_PLATDATA,
> thus was already unused.
> This frees about 4kB of SPL size.
>
> Signed-off-by: Urja Rannikko <urjaman at gmail.com>

Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   configs/chromebit_mickey_defconfig  | 3 +--
>   configs/chromebook_jerry_defconfig  | 3 +--
>   configs/chromebook_minnie_defconfig | 3 +--
>   configs/chromebook_speedy_defconfig | 1 +
>   4 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/configs/chromebit_mickey_defconfig b/configs/chromebit_mickey_defconfig
> index b290f0fcb9..23efafb0d2 100644
> --- a/configs/chromebit_mickey_defconfig
> +++ b/configs/chromebit_mickey_defconfig
> @@ -73,8 +73,7 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
>   CONFIG_PINCTRL=y
>   CONFIG_PINCONF=y
>   CONFIG_SPL_PINCTRL=y
> -# CONFIG_SPL_PINMUX is not set
> -CONFIG_SPL_PINCONF=y
> +# CONFIG_SPL_PINCTRL_FULL is not set
>   CONFIG_DM_PMIC=y
>   # CONFIG_SPL_PMIC_CHILDREN is not set
>   CONFIG_PMIC_RK8XX=y
> diff --git a/configs/chromebook_jerry_defconfig b/configs/chromebook_jerry_defconfig
> index f6bdf80aee..443e3cdace 100644
> --- a/configs/chromebook_jerry_defconfig
> +++ b/configs/chromebook_jerry_defconfig
> @@ -75,8 +75,7 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
>   CONFIG_PINCTRL=y
>   CONFIG_PINCONF=y
>   CONFIG_SPL_PINCTRL=y
> -# CONFIG_SPL_PINMUX is not set
> -CONFIG_SPL_PINCONF=y
> +# CONFIG_SPL_PINCTRL_FULL is not set
>   CONFIG_DM_PMIC=y
>   # CONFIG_SPL_PMIC_CHILDREN is not set
>   CONFIG_PMIC_RK8XX=y
> diff --git a/configs/chromebook_minnie_defconfig b/configs/chromebook_minnie_defconfig
> index c229177f64..99ac0e0674 100644
> --- a/configs/chromebook_minnie_defconfig
> +++ b/configs/chromebook_minnie_defconfig
> @@ -75,8 +75,7 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
>   CONFIG_PINCTRL=y
>   CONFIG_PINCONF=y
>   CONFIG_SPL_PINCTRL=y
> -# CONFIG_SPL_PINMUX is not set
> -CONFIG_SPL_PINCONF=y
> +# CONFIG_SPL_PINCTRL_FULL is not set
>   CONFIG_DM_PMIC=y
>   # CONFIG_SPL_PMIC_CHILDREN is not set
>   CONFIG_PMIC_RK8XX=y
> diff --git a/configs/chromebook_speedy_defconfig b/configs/chromebook_speedy_defconfig
> index be434871ff..5a5152541b 100644
> --- a/configs/chromebook_speedy_defconfig
> +++ b/configs/chromebook_speedy_defconfig
> @@ -74,6 +74,7 @@ CONFIG_SPI_FLASH_GIGADEVICE=y
>   CONFIG_PINCTRL=y
>   CONFIG_PINCONF=y
>   CONFIG_SPL_PINCTRL=y
> +# CONFIG_SPL_PINCTRL_FULL is not set
>   CONFIG_DM_PMIC=y
>   # CONFIG_SPL_PMIC_CHILDREN is not set
>   CONFIG_PMIC_RK8XX=y
diff mbox series

Patch

diff --git a/configs/chromebit_mickey_defconfig b/configs/chromebit_mickey_defconfig
index b290f0fcb9..23efafb0d2 100644
--- a/configs/chromebit_mickey_defconfig
+++ b/configs/chromebit_mickey_defconfig
@@ -73,8 +73,7 @@  CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_PINCTRL=y
 CONFIG_PINCONF=y
 CONFIG_SPL_PINCTRL=y
-# CONFIG_SPL_PINMUX is not set
-CONFIG_SPL_PINCONF=y
+# CONFIG_SPL_PINCTRL_FULL is not set
 CONFIG_DM_PMIC=y
 # CONFIG_SPL_PMIC_CHILDREN is not set
 CONFIG_PMIC_RK8XX=y
diff --git a/configs/chromebook_jerry_defconfig b/configs/chromebook_jerry_defconfig
index f6bdf80aee..443e3cdace 100644
--- a/configs/chromebook_jerry_defconfig
+++ b/configs/chromebook_jerry_defconfig
@@ -75,8 +75,7 @@  CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_PINCTRL=y
 CONFIG_PINCONF=y
 CONFIG_SPL_PINCTRL=y
-# CONFIG_SPL_PINMUX is not set
-CONFIG_SPL_PINCONF=y
+# CONFIG_SPL_PINCTRL_FULL is not set
 CONFIG_DM_PMIC=y
 # CONFIG_SPL_PMIC_CHILDREN is not set
 CONFIG_PMIC_RK8XX=y
diff --git a/configs/chromebook_minnie_defconfig b/configs/chromebook_minnie_defconfig
index c229177f64..99ac0e0674 100644
--- a/configs/chromebook_minnie_defconfig
+++ b/configs/chromebook_minnie_defconfig
@@ -75,8 +75,7 @@  CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_PINCTRL=y
 CONFIG_PINCONF=y
 CONFIG_SPL_PINCTRL=y
-# CONFIG_SPL_PINMUX is not set
-CONFIG_SPL_PINCONF=y
+# CONFIG_SPL_PINCTRL_FULL is not set
 CONFIG_DM_PMIC=y
 # CONFIG_SPL_PMIC_CHILDREN is not set
 CONFIG_PMIC_RK8XX=y
diff --git a/configs/chromebook_speedy_defconfig b/configs/chromebook_speedy_defconfig
index be434871ff..5a5152541b 100644
--- a/configs/chromebook_speedy_defconfig
+++ b/configs/chromebook_speedy_defconfig
@@ -74,6 +74,7 @@  CONFIG_SPI_FLASH_GIGADEVICE=y
 CONFIG_PINCTRL=y
 CONFIG_PINCONF=y
 CONFIG_SPL_PINCTRL=y
+# CONFIG_SPL_PINCTRL_FULL is not set
 CONFIG_DM_PMIC=y
 # CONFIG_SPL_PMIC_CHILDREN is not set
 CONFIG_PMIC_RK8XX=y