From patchwork Thu May 21 20:32:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rini X-Patchwork-Id: 246169 List-Id: U-Boot discussion From: trini at konsulko.com (Tom Rini) Date: Thu, 21 May 2020 16:32:20 -0400 Subject: [PATCH] checkpatch.pl: Add check for defining CONFIG_CMD_xxx via config files Message-ID: <20200521203220.17428-1-trini@konsulko.com> All of our cmds have a Kconfig entry. Making enabling a CMD via the config file an error to checkpatch.pl. Signed-off-by: Tom Rini Reviewed-by: Simon Glass --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c2641bc995e8..5c0317c67fdb 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6502,6 +6502,12 @@ sub process { "#define of '$1' is wrong - use Kconfig variables or standard guards instead\n" . $herecurr); } +# Defining new CONFIG_CMD is wrong. + if ($line =~ /\+\s*#\s*define\s+(CONFIG_CMD\w*)\b/) { + ERROR("DEFINE_CONFIG_CMD", + "#define of '$1' is wrong - use Kconfig entries instead\n" . $herecurr); + } + # likely/unlikely comparisons similar to "(likely(foo) > 0)" if ($perl_version_ok && $line =~ /\b((?:un)?likely)\s*\(\s*$FuncArg\s*\)\s*$Compare/) {