From patchwork Wed May 27 12:58:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 246719 List-Id: U-Boot discussion From: sjg at chromium.org (Simon Glass) Date: Wed, 27 May 2020 06:58:48 -0600 Subject: [PATCH v2 3/4] x86: spl: Print the error on SPL failure In-Reply-To: <20200527125849.165241-1-sjg@chromium.org> References: <20200527125849.165241-1-sjg@chromium.org> Message-ID: <20200527065838.v2.3.I69f4fdf91be179c655b605f9d51250a4041f336f@changeid> The error code is often useful to figure out what is going on. Printing it does not increase code size much, so print out the error and then hang. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/lib/spl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/lib/spl.c b/arch/x86/lib/spl.c index b6f9a70ba7..cf22fa2d7b 100644 --- a/arch/x86/lib/spl.c +++ b/arch/x86/lib/spl.c @@ -164,8 +164,8 @@ void board_init_f(ulong flags) ret = x86_spl_init(); if (ret) { - debug("Error %d\n", ret); - panic("x86_spl_init fail"); + printf("x86_spl_init: error %d\n", ret); + hang(); } #if IS_ENABLED(CONFIG_TPL) || IS_ENABLED(CONFIG_SYS_COREBOOT) gd->bd = malloc(sizeof(*gd->bd));