From patchwork Mon Jul 13 02:50:00 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Nicolas Boichat <drinkcat@chromium.org>
X-Patchwork-Id: 241404
List-Id: U-Boot discussion <u-boot.lists.denx.de>
From: drinkcat at chromium.org (Nicolas Boichat)
Date: Mon, 13 Jul 2020 10:50:00 +0800
Subject: [PATCH 1/2] patman: Make sure sendemail.suppresscc is (un)set
 correctly
Message-ID: <20200713104956.1.Id4bca8ef9bec7d51122a498ded4f8746ee3f8775@changeid>

Setting sendemail.suppresscc to all or cccmd leads to --cc-cmd
parameter being ignored, and emails going either nowhere, or
just to the To: line maintainer.

Signed-off-by: Nicolas Boichat <drinkcat at chromium.org>
Reviewed-by: Simon Glass <sjg at chromium.org>
---

 tools/patman/gitutil.py | 25 +++++++++++++++++++++++++
 tools/patman/main.py    |  2 ++
 2 files changed, 27 insertions(+)

diff --git a/tools/patman/gitutil.py b/tools/patman/gitutil.py
index 5189840eab..022cc6416a 100644
--- a/tools/patman/gitutil.py
+++ b/tools/patman/gitutil.py
@@ -333,6 +333,31 @@ def BuildEmailList(in_list, tag=None, alias=None, raise_on_error=True):
         return ['%s %s%s%s' % (tag, quote, email, quote) for email in result]
     return result
 
+def CheckSuppressCCConfig():
+    """Check if sendemail.suppresscc is configured correctly.
+
+    Returns:
+        True if the option is configured correctly, False otherwise.
+    """
+    suppresscc = command.OutputOneLine('git', 'config', 'sendemail.suppresscc',
+                                       raise_on_error=False)
+
+    # Other settings should be fine.
+    if suppresscc == 'all' or suppresscc == 'cccmd':
+        col = terminal.Color()
+
+        print((col.Color(col.RED, "error") +
+            ": git config sendemail.suppresscc set to %s\n"  % (suppresscc)) +
+            "  patman needs --cc-cmd to be run to set the cc list.\n" +
+            "  Please run:\n" +
+            "    git config --unset sendemail.suppresscc\n" +
+            "  Or read the man page:\n" +
+            "    git send-email --help\n" +
+            "  and set an option that runs --cc-cmd\n")
+        return False
+
+    return True
+
 def EmailPatches(series, cover_fname, args, dry_run, raise_on_error, cc_fname,
         self_only=False, alias=None, in_reply_to=None, thread=False,
         smtp_server=None):
diff --git a/tools/patman/main.py b/tools/patman/main.py
index 28a9a26087..a4aa5274c9 100755
--- a/tools/patman/main.py
+++ b/tools/patman/main.py
@@ -167,6 +167,8 @@ else:
                                 not options.ignore_bad_tags,
                                 options.add_maintainers, options.limit)
 
+    ok = ok and gitutil.CheckSuppressCCConfig()
+
     # Email the patches out (giving the user time to check / cancel)
     cmd = ''
     its_a_go = ok or options.ignore_errors