From patchwork Fri Nov 11 16:20:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilias Apalodimas X-Patchwork-Id: 623747 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp886533pvb; Fri, 11 Nov 2022 08:20:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf54jaTWITQa13P+bNfKnzQxZbZnLjv7yGkRS8/DZSfOq/7Kmd6/vMed+jxkSWqvHdGVeULZ X-Received: by 2002:a50:c04b:0:b0:463:9b53:cbf6 with SMTP id u11-20020a50c04b000000b004639b53cbf6mr2197469edd.173.1668183651845; Fri, 11 Nov 2022 08:20:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668183651; cv=none; d=google.com; s=arc-20160816; b=0NrHmw3zZDnunOZXOm9PiwVuaYAGoERMPl8462tZjbWwAfdnH2MjhmWYTfhdlqtza8 1LNncMxsDrppkWn0LoYhNKEq9vxzUrj3f7yECXZeCiXJCbt8mCzo5I6O8ais1c33Y+LG gzrEDjjz/ODkXjcc93a3qRzoQqI0EWp1HVn/MZlFKZVPePxm9xfbVUyXyRnpTO4DgzKG xy4a9e7f0b7VQ9+YrrHq5aYBCZG9p1PUnkK6dMo2o8z3Ew7A0obWD3z7v3fHlUo19dGj 2Tlcuy4h4DQjjQlaLXhKwG184N4Wu5mW5FsfkuqGgdBNRpLi3+iFnDn9j68pBuM58rMk WtrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=Xtmh0q2vzIg+VXqo3VpZBv2Wz1lp6IGwBaOWIYDFizg=; b=QnGONZyl4xrtiHLIYWhzsQPjBAmx561qjIusMLBJhNjY3b36xRWeqi+GGBDQ2qqrED IaXmcXhiQpNgoAxz1zJtkCybENG459Ls6A884vpFo/H2295SRqzyPGWweZJsLlSXfq9w WrXGaCs1WplCxha6wow1Dv0kOKeAL++alHu+Hr9ytEFAKWcGzGMXlnzBprFRlB95XFB3 mjSQY5oum5FEgdBlP906yHoFo9BAdPWeWzAlZAYxNYz+iq5moZbzYqSVEBGQfBmVCMfo LOW6dEEegoB1tQetabAvggSB3YUHRf8Htb8aiawZSHU/69mvsrg35ZLIAealSLIHqBA8 ps+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=miIwu3ns; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id x62-20020a50bac4000000b004621e2c473dsi2361390ede.354.2022.11.11.08.20.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 08:20:51 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=miIwu3ns; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1254284DF8; Fri, 11 Nov 2022 17:20:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="miIwu3ns"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 73B33850E2; Fri, 11 Nov 2022 17:20:48 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0E93083EFC for ; Fri, 11 Nov 2022 17:20:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x536.google.com with SMTP id u24so8232503edd.13 for ; Fri, 11 Nov 2022 08:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Xtmh0q2vzIg+VXqo3VpZBv2Wz1lp6IGwBaOWIYDFizg=; b=miIwu3nsrB7YK6xwxwaHgRasP1b2UHRkbfhuGBXvqdLreMezAh9UTWFNc3q5Yys8PX 7cAlzoMCAoGnmBrZTK9rXAZY/BjOirHf6CI/9Pu0gbm78m2vrTN40E+O97OeHSZdWm8v j14gr+4qo/hsozhzR92CXRjWN6AjgBsu/jzqpdPF8Huw+vMkW3zJekhG2vnNIH3m+izC 0gslkyidZu/SkyJZk20r7naa76xEKqaV9rkaOb7inHPglnSqdq6PekeRhk2R4WtddHJ6 hrORM1Y1iQFI8oky9A0OLcfIbzDJsDmyiMw6pOEH33+fWTcdsCPaFcrg4NINe5RaWmOU +QHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Xtmh0q2vzIg+VXqo3VpZBv2Wz1lp6IGwBaOWIYDFizg=; b=KGYi9UZZ/8JcAL8GLbEd8LFVYHSMr/0XcOPo1SLvbGJ1QWpGuVGsQtYNoTbJQi6y4H vTcZIO2kWt1I8Yzalca5k7UpXrUwHOs2ktijz2mPY+RGrQJyVFgXZVd6hxIZ+afK0vDP RlmnJI0Fi83cBSoXQwsr+FwqfnGHkPJj2VAjZL4Hiy/Pyka6uYtZtBgVEQ7W6G0PZ348 4EFRkrdpfeqW55w/MlQ5KrmVHxav0k7UulGkuRVjOLo2mqCRtLnR8wC9G5ZispIR3zRT 9eIdkl+YljAZRPI1aUaxiZzU4LBcKB54HEXPxdib3u8XmLoT+5JMlHOIyYnHryQ12rTe sT+A== X-Gm-Message-State: ANoB5pldrcr6yUD5FqOdqmnXdWfF42UKjnQ+6R4WhvrKGmrBkehcDojF o1MagUTyu5ADsCV6EwlNW3JoE22fic4S8EVG X-Received: by 2002:a50:9503:0:b0:457:1edb:996c with SMTP id u3-20020a509503000000b004571edb996cmr2094909eda.363.1668183645688; Fri, 11 Nov 2022 08:20:45 -0800 (PST) Received: from localhost.localdomain ([2a02:85f:fc35:4b7e:d6cf:3799:6c58:2ce]) by smtp.gmail.com with ESMTPSA id ku21-20020a170907789500b007ae1ab8f887sm1072986ejc.14.2022.11.11.08.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 08:20:45 -0800 (PST) From: Ilias Apalodimas To: u-boot@lists.denx.de Cc: heinrich.schuchardt@canonical.com, Ilias Apalodimas , Heinrich Schuchardt Subject: [PATCH] efi_loader: add missing EFI_CALL when closing a file Date: Fri, 11 Nov 2022 18:20:37 +0200 Message-Id: <20221111162037.1290769-1-ilias.apalodimas@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Closing the files uses the EFI protocol and specifically it's .close callback. This needs to be wrapped on an EFI_CALL() Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt --- lib/efi_loader/efi_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_file.c b/lib/efi_loader/efi_file.c index 9e6c2b118900..750d380ad967 100644 --- a/lib/efi_loader/efi_file.c +++ b/lib/efi_loader/efi_file.c @@ -1131,7 +1131,7 @@ struct efi_file_handle *efi_file_from_path(struct efi_device_path *fp) if (!EFI_DP_TYPE(fp, MEDIA_DEVICE, FILE_PATH)) { printf("bad file path!\n"); - f->close(f); + EFI_CALL(f->close(f)); return NULL; }