From patchwork Mon Dec 4 12:04:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Uvarov X-Patchwork-Id: 750018 Delivered-To: patch@linaro.org Received: by 2002:adf:9b9d:0:b0:333:3a04:f257 with SMTP id d29csp1087247wrc; Mon, 4 Dec 2023 04:07:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IG80BRR1aUcdfHRiMuqvx04f3hz3YDPlmz98r46CizZIHC0//QQIyBWkYAeuiKSPimaBGVG X-Received: by 2002:a17:902:d2cf:b0:1cf:dce0:4d98 with SMTP id n15-20020a170902d2cf00b001cfdce04d98mr1993641plc.27.1701691670472; Mon, 04 Dec 2023 04:07:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701691670; cv=none; d=google.com; s=arc-20160816; b=EeJw0sonqLqVQFr1xyKezCs7PhYL3HF5oItOHBaB8zVQjFtbx5ZjjQ5k7uBx+GVvXc P7N2QxOM/G0XTQ0ZHfdXot8n97S1kqaE4/yMi/oAS2kSdOiPn/5DMbPV6g3q94AatYQQ okTzLhGjWCw/NC0G+ywQOs5i6lMZnQ/Rz9WcJIVMEccDXLDbgkScsc7sjxUwXbi6DoXw pqeaLNT8dvIehmx6+qbVpUSIr2q8IktcEarUD/WN5Kw9o5E6ZfgPRO53ZRqKQxLHd1jr JgIKdoYRtCsStNx+WMm4tcRDzWXhbdrew93Lobvc1tTE/2TttAG+D6J16O7araO69Njz QJWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4RT7RsSzsdLSxuFFY+pzbV0GIbjwfPtWfJC6y2Apj2w=; fh=al8TO5kxNSCLdK6Wct4/S1Ky9QCKGaknFfrx/Rr/20U=; b=N5E5tYeX8mK3hb0SUQsqHS1omi0kpKHZRwsmTpPA4urdVw1rWSkPCg0ccIG2bInOam jfhW6o23zs2+uRUWKtDEEHmZrOipWytNY8O/71L49prKLLrNfMHy9Ixawi2UD+nml+wR ABgmScTtgO79sQ5CmjfzC17qQ1jJnu1Ce26VKbk8x+6iM55j6OEvh5gR+DHDi5uMHc1M CADNisfLU0EPF0lyol5MdB5jGYOTe3u5kt2vfbhB6MxFtGHoFTBXvL7POJAJ3nzKzRrM g2NVZoKiK6FKulPy4Ml2Kyux05Y8IKM/UdlMLLHy6/EcBNNCiB2ltp4nf38IeO+KUyq4 3BpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m8j2r7U7; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id k5-20020a170902c40500b001d082f4bd7esi2918448plk.250.2023.12.04.04.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 04:07:50 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m8j2r7U7; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 93FAB8754A; Mon, 4 Dec 2023 13:07:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="m8j2r7U7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F417387626; Mon, 4 Dec 2023 13:07:13 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E8B95875B6 for ; Mon, 4 Dec 2023 13:07:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maxim.uvarov@linaro.org Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50bfd7be487so452377e87.0 for ; Mon, 04 Dec 2023 04:07:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701691631; x=1702296431; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4RT7RsSzsdLSxuFFY+pzbV0GIbjwfPtWfJC6y2Apj2w=; b=m8j2r7U7Tlu78+KcI5M5vECTV3ttOHGJc+aNKKm4PfmMldtgQCQzhOSnt17TyeiOz+ JWc9GJXcMZTu5aCumEXcmajpHhUNGTI8A3Q6Oww/xUwCMaNUfPSVKuEJI/JX5nEHoF20 jnrJKCH/TJ5JCE1gK/PH21rqPAuRRpWzxbXFoBvO/bsLAkV/Qqgz3kGlIxOngN5R5e/A acGLeYctznlQCCbrUuJNo7yjHETpCFSWEBR6Sd54rkdLKtQ0A55qmcdLSpMMdXtbiG5n ccH04cVNhF46b7yrg/Gz/WCttFrVQvNE4sY//5UAMEeGvoOETP2QivJGkQE7s4ufK+Kn ph9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701691631; x=1702296431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4RT7RsSzsdLSxuFFY+pzbV0GIbjwfPtWfJC6y2Apj2w=; b=wGlK9wzmwsyRU5jgB5reRDw3EvCnHBtBHoUVC6jr/NBrSPnZxLhkjEmeEx4ZBi9+JK x8MsIduLklYpRVFYg3ga3SCihpi3db1mwgc+IJQzXXnCeJH5J2gte3mxSM96qNbJO2Nd ZuSJ9p28781NrxSil5s57DHkYDTTYSWahPtEVTvzQyujKN52TD9FSJeS2BV18+nmfXIk 1U+ZJYvQ5H3tT2eKfTz060skR4CLmWxksH1t7i+8L1ALFcEpJtV2rwyocs19NHXK020x dOwlyUUGBVwVRL/oKtl7idJxZPotKABY77t+1ujCgQrzYi/5S7tw69+fGlopmChrq6ko b5uQ== X-Gm-Message-State: AOJu0YyBn0U9Uvs+nB/mVZuMwfkCE8AYjql80Kr99K26yzbhOscyOUDY 9Wlap8Kk9Smy+w6AxSX+GxqT93ZgL1lWsHxWP7xntw== X-Received: by 2002:ac2:5185:0:b0:50b:fb28:4530 with SMTP id u5-20020ac25185000000b0050bfb284530mr461861lfi.119.1701691631158; Mon, 04 Dec 2023 04:07:11 -0800 (PST) Received: from localhost.localdomain ([45.82.14.220]) by smtp.gmail.com with ESMTPSA id g33-20020a0565123ba100b0050befebf0ccsm541675lfv.292.2023.12.04.04.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 04:07:10 -0800 (PST) From: Maxim Uvarov To: u-boot@lists.denx.de Cc: simon.k.r.goldschmidt@gmail.com, tien.fong.chee@intel.com, sjg@chromium.org, joe.hershberger@ni.com, rfried.dev@gmail.com, bharat.gooty@broadcom.com, rayagonda.kokatanur@broadcom.com, trini@konsulko.com, Maxim Uvarov Subject: [PATHv1 3/9] net/smc911x: fix return from smc911x_send Date: Mon, 4 Dec 2023 18:04:40 +0600 Message-Id: <20231204120446.3277-4-maxim.uvarov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231204120446.3277-1-maxim.uvarov@linaro.org> References: <20231204120446.3277-1-maxim.uvarov@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean return value of smc911x_send is ignored, but on sucesseful send we need return 0 and or error -ETIMEOUT, not opposite. Signed-off-by: Maxim Uvarov Reviewed-by: Tom Rini --- drivers/net/smc911x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 5c5ad8b84a..616b7ce174 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -403,7 +403,7 @@ static int smc911x_send(struct udevice *dev, void *packet, int length) ret = smc911x_send_common(priv, packet, length); - return ret ? 0 : -ETIMEDOUT; + return ret ? -ETIMEDOUT : 0; } static int smc911x_recv(struct udevice *dev, int flags, uchar **packetp)