From patchwork Tue Jan 30 14:04:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 768070 Delivered-To: patch@linaro.org Received: by 2002:adf:ee41:0:b0:33a:e5bd:fedd with SMTP id w1csp1385642wro; Tue, 30 Jan 2024 06:06:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWGntfNVdMt0grjYUFgyFKgiInsl4c0mQrRLWm+c5KBg8XKHrJyOwRYSCyUBIMrLANu/cp X-Received: by 2002:adf:fe12:0:b0:33a:fe6f:a6c8 with SMTP id n18-20020adffe12000000b0033afe6fa6c8mr262739wrr.51.1706623594463; Tue, 30 Jan 2024 06:06:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706623594; cv=none; d=google.com; s=arc-20160816; b=HPQdyEyghlRRklE40qMuxMjAEjwFUF40SZ8+bu0MbmPaeLrxGBhKX7VCviAB2ujjzX zlJaJilblSHY5qUu7u92SItMTk62K5pD24BA5GGmAC8UjruHz+PiH0ZR4yLrUkgCaYbA rAtkn33WjnI1MF3VdXqWMwkQ4MXKKwOvwLev/EG+5WGCOpkImEGFXwzpnbillUlkRx6T ZuLdmXQM0iRP9itrc5AmCnLWnAGDe0ycTEB47+D+W2iNAxAPO6EQXBdkJP/LIMKdhYk1 HsyCT8nwauXJnaoRUfZEKrkABerkNShtfVEN/poGSjFxNfhaMYUV5k5WPtBNWOZPOVYt vuYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=k+Z/itasEdVl+93wmdY3Hqkz2ZxgLcPT57V/RsMNa8o=; fh=GB9E9KzRIiNXhkRWIZbZpSMjbCjxnqnvE8nYuQxq8UI=; b=Gb/+PflgqX0xSYOwkF2lzSGWWWidJXDfOAJsx6ZySeXdjWPL28igVMWGbJ6/iXPQiV QmnQs5CYcvXxw6m68EFSs2osKAs2dKDRKomtPXL1yhEb6kvlrg76GXc7Zs4hbM5mP9gx U/HJi7XjzrPwmjfl6p1w38DumIErkm7pstV6CK2MylXIxVcGd0TDb+hnqP+8kn8FKvJX fWCab2MdjE1g/1wTPsdSiAI8fihq64zWCjOvXv2yRuXh0dbi8sY83rzcJz8uOg/V8TIt RbBJOwuAWvug+Rkzyr/pWJxEDalwFt6YNWoM8YEiaNmoZ1QwWFTqd6q+TAEOWmLOd0lk EFYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cweJZu5F; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id x10-20020adfffca000000b0033afb42e191si781252wrs.46.2024.01.30.06.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 06:06:34 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cweJZu5F; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8AE4B87CEA; Tue, 30 Jan 2024 15:05:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="cweJZu5F"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 811F887DD9; Tue, 30 Jan 2024 15:05:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9AAB387D07 for ; Tue, 30 Jan 2024 15:05:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-51028acdcf0so4935247e87.0 for ; Tue, 30 Jan 2024 06:05:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706623516; x=1707228316; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k+Z/itasEdVl+93wmdY3Hqkz2ZxgLcPT57V/RsMNa8o=; b=cweJZu5FWJlOeyBh6z5FV5t790XtCdj22VjgIaiCAAbZAd1nSF01GyHgpitF9AEjMZ elEwlHuFzDWrrRxEKIK1wFoIlP4mdhP1QmN6r/OgNq2WNRjD3ePl/ig8rTy2YBm+Y8eO NXSethJ9an/6K2XFS36gLcdtmDm/Cm+OTTZ+ALESgW2gOjh8hf+121NxhwOQtsGs3boP Or6Fw9KdBJvq5rokL8eTIQ6F71pHqHFmfZVayr5/UALDwq2toNAaVxNd9v4G9mr2xzyd SDB3rszEJ1tyoWH/ZPPofnbk8ehYNfgMR5Bwd4DuK/BboAxxBwV82ZgqkWF/wKiRxxPK Y8FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706623516; x=1707228316; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k+Z/itasEdVl+93wmdY3Hqkz2ZxgLcPT57V/RsMNa8o=; b=wZRcWNeOrUEefnAQl7Qi2qa9B1FFJOM3jYTf1GWnircmz7utGWWQONC/vj3FxC/Z3e Fbgb5acGwnxJtFTaPjRr28pcb63ALWW9549hRwsOCr92/BbGTRfJPF0L3vQTHK0Zwfvi ub2HIIgrn5SoJplSHIR6PzetjRcqRhxvO3OcA8DcAeZQwl3hzev4N1C8uSMNPg1WZgvY 4BXdZP7eP5RduotzjI+YBGB7XdI1J0+4rmXhmR6nWNrZzHfUL/zDYMjIQDBKw4tvRV5Z HyLijJH0xKa6g1z5JoXyliQAsISXhFKA05jIJMA/KDFq3sGifIUtksbjmggpoQYSQfnJ WzEQ== X-Gm-Message-State: AOJu0Yy6fCd/hfJDoj+6/VQCacvCbGSLyn2YfBb1I+BiDJc/q9kJ++2Y Osz8z/m7oG3nGw+gghvbvkLVj6fhzwf7WGNeYy9WDcXMmTW8XRVmiixIyewex9w= X-Received: by 2002:a19:2d1c:0:b0:510:28a9:9b31 with SMTP id k28-20020a192d1c000000b0051028a99b31mr5229602lfj.59.1706623516074; Tue, 30 Jan 2024 06:05:16 -0800 (PST) Received: from lion.localdomain (host-92-17-96-232.as13285.net. [92.17.96.232]) by smtp.gmail.com with ESMTPSA id g11-20020a05600c310b00b0040f035bebfcsm1799017wmo.12.2024.01.30.06.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 06:05:15 -0800 (PST) From: Caleb Connolly Date: Tue, 30 Jan 2024 14:04:55 +0000 Subject: [PATCH v3 07/36] serial: msm: add debug UART MIME-Version: 1.0 Message-Id: <20240130-b4-qcom-common-target-v3-7-e523cbf9e556@linaro.org> References: <20240130-b4-qcom-common-target-v3-0-e523cbf9e556@linaro.org> In-Reply-To: <20240130-b4-qcom-common-target-v3-0-e523cbf9e556@linaro.org> To: Neil Armstrong , Sumit Garg , Ramon Fried , Dzmitry Sankouski , Caleb Connolly , Peng Fan , Jaehoon Chung , Rayagonda Kokatanur , Lukasz Majewski , Sean Anderson , Jorge Ramirez-Ortiz , Stephan Gerhold Cc: Marek Vasut , u-boot@lists.denx.de X-Mailer: b4 0.13-dev-4bd13 X-Developer-Signature: v=1; a=openpgp-sha256; l=2295; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=RaT7eBsp95EvNEXnKYsIOkzZtK/fF0MvZbISQ03N2mA=; b=owGbwMvMwCFYaeA6f6eBkTjjabUkhtSdTAJrmNzPbS7zeMjz/l458zTp3CsPev7oSX9gs52WG cnFaZ/fUcrCIMjBICumyCJ+Ypll09rL9hrbF1yAmcPKBDKEgYtTACYSu5SRYW3yNbtdCctaPjM2 +5aqx0vl7xc98n/zydP1GjITL0bNFGFkWHHXv/Zfy91XacqOgapMu5XW8r/68colNaRqxZdfJ8W aJwIA X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Introduce support for early debugging. This relies on the previous stage bootloader to initialise the UART clocks, when running with U-Boot as the primary bootloader this feature doesn't work. It will require a way to configure the clocks before the driver model is available. Signed-off-by: Caleb Connolly --- drivers/serial/Kconfig | 8 ++++++++ drivers/serial/serial_msm.c | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 26460c4e0cab..fbd351a47859 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -319,6 +319,14 @@ config DEBUG_UART_S5P will need to provide parameters to make this work. The driver will be available until the real driver-model serial is running. +config DEBUG_UART_MSM + bool "Qualcomm QUP UART debug" + depends on ARCH_SNAPDRAGON + help + Select this to enable a debug UART using the serial_msm driver. You + will need to provide parameters to make this work. The driver will + be available until the real driver-model serial is running. + config DEBUG_UART_MSM_GENI bool "Qualcomm snapdragon" depends on ARCH_SNAPDRAGON diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c index a22623c316ed..19a5a3a788f7 100644 --- a/drivers/serial/serial_msm.c +++ b/drivers/serial/serial_msm.c @@ -253,3 +253,35 @@ U_BOOT_DRIVER(serial_msm) = { .probe = msm_serial_probe, .ops = &msm_serial_ops, }; + +#ifdef CONFIG_DEBUG_UART_MSM + +static struct msm_serial_data init_serial_data = { + .base = CONFIG_VAL(DEBUG_UART_BASE), + .clk_bit_rate = UART_DM_CLK_RX_TX_BIT_RATE, +}; + +#include + +static inline void _debug_uart_init(void) +{ + uart_dm_init(&init_serial_data); +} + +static inline void _debug_uart_putc(int ch) +{ + struct msm_serial_data *priv = &init_serial_data; + + while (!(readl(priv->base + UARTDM_SR) & UARTDM_SR_TX_EMPTY) && + !(readl(priv->base + UARTDM_ISR) & UARTDM_ISR_TX_READY)) + ; + + writel(UARTDM_CR_CMD_RESET_TX_READY, priv->base + UARTDM_CR); + + writel(1, priv->base + UARTDM_NCF_TX); + writel(ch, priv->base + UARTDM_TF); +} + +DEBUG_UART_FUNCS + +#endif