From patchwork Fri Mar 15 15:06:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 780507 Delivered-To: patch@linaro.org Received: by 2002:a5d:46c1:0:b0:33e:7753:30bd with SMTP id g1csp250342wrs; Fri, 15 Mar 2024 08:06:50 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV2WmAUl038odCRNedFdvDmXxbgS0Fc4J9bChMvZRZvfrti/w/mR4u4eGDOfRtYzMEhF4PNzIccVpfIB7sVXrXo X-Google-Smtp-Source: AGHT+IF6US/xfqvCfNuXVdKRBmBuuS82POFdAiM6TJ5a0A7Es3f7HFPIYXNwLzq4xpWlq+98Y4gs X-Received: by 2002:a05:600c:3ca8:b0:414:273:67d4 with SMTP id bg40-20020a05600c3ca800b00414027367d4mr1252374wmb.30.1710515210351; Fri, 15 Mar 2024 08:06:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1710515210; cv=none; d=google.com; s=arc-20160816; b=IR5oQUoBOm+jmBdVltUrqnjubqlGFwWVk0bbhQW/nCidvXf2d9w/low4Aw+hHs0FkR WcmtNm1r6yMwzM+Ap/ZYn4mmkoTCIQrcgF9SNS598kUN2V3aQhl/urhkVqYFBSEfdmf/ MQ+im0WMmgrjLk/N7BjSWN62d6U6euYc8Nwy9tnm+hLNSLAm2QOogdOKrEUTX/eqpiKf Hp08sme1D1PZy8eY6+nZyWGHGUQFo4DuaBel25odx7+ZphUxvJ/8WkdUqt81P7voOAlG 2enGHAdrdo+w2fwRIJGSCbcq+wlk6/JECOkHNa7/og0wRN3ZZf0bnH4UEYllOGWZoUcz hl8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=e9PNn3A0M8j5XRDzvbl1vLHxbY2HeF4JRZJRcDlmjgE=; fh=UJLfQHigVNNxRTyupVH3iuVYJLWMjRXGBkTXuIfaL+0=; b=QL9M54di+XLCp1p49wUhXyUQQwN/T2YpasA2BSxIrhoMYzJFCCXI1gqYDj09TlnDoL a6VKEqHD0l8+LGCt/Yjg5kSq/Z10kFtKQrPC/SGExQ878LIp/b79eAR4i/aWZ75MFuXv tZmDc3bEOO3AsY8ZBGP3StL8PVSUZsSJcNZRb4kZQ0i0gY9kj0m11AyqeEUNxhc+2fY3 4Ndqs5rBSPbBY+D4EdzCgbsj+J5/IJxpNaH3l7aQGSizcWn/vNi9o7j96nl3RUlv8fIT XClXjYXAGVlgDA+ZfdCVppAYSGl5VP55n2nsABFduZg9qnN1ZFJz1eXQg6ke43Dkbo6I OkDA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XHHQ8Y2X; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id l15-20020adfe58f000000b0033ec2ea5e1asi1683232wrm.889.2024.03.15.08.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 08:06:50 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XHHQ8Y2X; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B025E87FFF; Fri, 15 Mar 2024 16:06:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="XHHQ8Y2X"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8FCE887FDD; Fri, 15 Mar 2024 16:06:15 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 069508800B for ; Fri, 15 Mar 2024 16:06:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-5131a9b3d5bso2634441e87.0 for ; Fri, 15 Mar 2024 08:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710515169; x=1711119969; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e9PNn3A0M8j5XRDzvbl1vLHxbY2HeF4JRZJRcDlmjgE=; b=XHHQ8Y2XpHeG7uMhfEfLxw1mq4xoKJIFydTi0oYZ2Lk6ENr8DD1WwDVjOFoNrnQibd B7fdWzOZz7Pnop6BhawGz/+xKxEoT6+gRi60oiOihMjUucodbDzzjiNRgvesp8WtvRVw o7h19FhYrKyen1w3hoOTafV2yZagWzPm8SXh1Cp1eAInQAsFqSzPHiDMZcS5dKgO5aq0 d1XsGOC1vHi4cSweSLGgn8X3aF46rvsPDY/IAIYmhW6KAPICmm+AYn9NT1X/g4op94g7 Sm9Akj3buiRSvlQ7ESiY4cidEM0C1+DIQ/qjHloA/FtR7OuLCq0w9Wo6iFbqxcu2WUvz UIKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710515169; x=1711119969; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e9PNn3A0M8j5XRDzvbl1vLHxbY2HeF4JRZJRcDlmjgE=; b=jnIPbV3tlQvZi/bvb2d2M5lK7alKLvSX/8nuXODkLDb1aMC1RICKleQjoYf+l/ofwG wHS2NpcrBq0LpnLjxEjaXXzC9V5cuA8/cuYOY3SSmU3rbJibwilF0wIirMQ3vZLrKc62 RLCRXc8Wf1E6Z7whWu7fzKruhf2iNLY7L0EO22Mj+QkECYDmwsnQB1UOK1fG0x5QJJj5 /MUuHDueVopFsfPErY13Nf8e5zo1yJRZR0Iw+PzrFvehI4eqaw8Vr9ifjvcsHfW2ixPR g4wIYrPEfy5jKRzc5pNtKwKBh/b91ICk6FXsav6jANhAdiNsy7/v1muW0+CvPmdNsSzO Zu8g== X-Gm-Message-State: AOJu0YxADFl17vwm79kX6Hjw+5egAmVMmsHTEf6lx1MGdYf7et8kgksI lxxN5QStNjhWy7WYjR7K22ZqcNs6g9vZTdY68dW0S60pf0TbcyG39USnVynRHIw= X-Received: by 2002:a19:5f04:0:b0:513:cd2e:ceae with SMTP id t4-20020a195f04000000b00513cd2eceaemr3541890lfb.20.1710515169373; Fri, 15 Mar 2024 08:06:09 -0700 (PDT) Received: from lion.localdomain (host-92-17-96-232.as13285.net. [92.17.96.232]) by smtp.gmail.com with ESMTPSA id jg28-20020a05600ca01c00b0041401fbe446sm1939502wmb.11.2024.03.15.08.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 08:06:08 -0700 (PDT) From: Caleb Connolly Date: Fri, 15 Mar 2024 15:06:02 +0000 Subject: [PATCH v2 3/5] usb: gadget: CDC ACM: call usb_gadget_initialize MIME-Version: 1.0 Message-Id: <20240315-b4-qcom-usb-v2-3-5467ec27cb26@linaro.org> References: <20240315-b4-qcom-usb-v2-0-5467ec27cb26@linaro.org> In-Reply-To: <20240315-b4-qcom-usb-v2-0-5467ec27cb26@linaro.org> To: Marek Vasut , Tom Rini , Lukasz Majewski , Mattijs Korpershoek , Caleb Connolly , Neil Armstrong , Sumit Garg Cc: u-boot@lists.denx.de X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1071; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=iF44ey0WhRVVVgOg2Xo34JBjuNlV4OImTlpeBMxGr20=; b=owGbwMvMwCFYaeA6f6eBkTjjabUkhtQvyXc1Fuc4y10SOP4idWL8zd8PuFdWNW8OF1S8GFk74 51mpgxjRykLgyAHg6yYIov4iWWWTWsv22tsX3ABZg4rE8gQBi5OAZhI+29GhtbSpud+Jpc/58RK fK28s+3ZA8cQtffP/livL7nU2eccupqRYUptx/nwmxJ/Z3sxyPgwNTu4Wt24PdV59u2+lyH1NjF nLwIA X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean To actually use the gadget the peripheral driver must be probed and we must call g_dnl_clear_detach(). Otherwise acm_stdio_start() will always fail to find a UDC on DT platforms. Reviewed-by: Mattijs Korpershoek Signed-off-by: Caleb Connolly --- drivers/usb/gadget/f_acm.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_acm.c index de42e0189e8d..ba216128ab27 100644 --- a/drivers/usb/gadget/f_acm.c +++ b/drivers/usb/gadget/f_acm.c @@ -622,14 +622,23 @@ static void acm_stdio_puts(struct stdio_dev *dev, const char *str) } static int acm_stdio_start(struct stdio_dev *dev) { + struct udevice *udc; int ret; if (dev->priv) { /* function already exist */ return 0; } + ret = udc_device_get_by_index(0, &udc); + if (ret) { + pr_err("USB init failed: %d\n", ret); + return ret; + } + + g_dnl_clear_detach(); + ret = g_dnl_register("usb_serial_acm"); if (ret) return ret;